xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Stefano Stabellini <stefano.stabellini@citrix.com>,
	Mukesh Rathor <mukesh.rathor@oracle.com>
Cc: Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
Subject: [PATCH 10/14] privcmd: refer to autotranslate not PVH in arch interfaces / comments.
Date: Thu, 4 Oct 2012 16:11:51 +0100	[thread overview]
Message-ID: <1349363515-26190-10-git-send-email-ian.campbell@citrix.com> (raw)
In-Reply-To: <1349363496.866.49.camel@zakaz.uk.xensource.com>

PVH is X86 specific while this functionality is also used on ARM.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
 arch/x86/xen/mmu.c    |   10 +++++-----
 drivers/xen/privcmd.c |   46 ++++++++++++++++++++++------------------------
 include/xen/xen-ops.h |    8 ++++----
 3 files changed, 31 insertions(+), 33 deletions(-)

diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
index 26097cb..3e781f9 100644
--- a/arch/x86/xen/mmu.c
+++ b/arch/x86/xen/mmu.c
@@ -2506,7 +2506,7 @@ struct pvh_remap_data {
 	unsigned long fgmfn;		/* foreign domain's gmfn */
 	pgprot_t prot;
 	domid_t  domid;
-	struct xen_pvh_pfn_info *pvhinfop;
+	struct xen_remap_mfn_info *pvhinfop;
 };
 
 static int pvh_map_pte_fn(pte_t *ptep, pgtable_t token, unsigned long addr, 
@@ -2514,7 +2514,7 @@ static int pvh_map_pte_fn(pte_t *ptep, pgtable_t token, unsigned long addr,
 {
 	int rc;
 	struct pvh_remap_data *remapp = data;
-	struct xen_pvh_pfn_info *pvhp = remapp->pvhinfop;
+	struct xen_remap_mfn_info *pvhp = remapp->pvhinfop;
 	unsigned long pfn = page_to_pfn(pvhp->pi_paga[pvhp->pi_next_todo++]);
 	pte_t pteval = pte_mkspecial(pfn_pte(pfn, remapp->prot));
 
@@ -2531,7 +2531,7 @@ static int pvh_map_pte_fn(pte_t *ptep, pgtable_t token, unsigned long addr,
 static int pvh_remap_gmfn_range(struct vm_area_struct *vma,
 				unsigned long addr, unsigned long mfn, int nr,
 				pgprot_t prot, unsigned domid,
-				struct xen_pvh_pfn_info *pvhp)
+				struct xen_remap_mfn_info *pvhp)
 {
 	int err;
 	struct pvh_remap_data pvhdata;
@@ -2574,7 +2574,7 @@ int xen_remap_domain_mfn_range(struct vm_area_struct *vma,
 			       unsigned long addr,
 			       unsigned long mfn, int nr,
 			       pgprot_t prot, unsigned domid,
-			       struct xen_pvh_pfn_info *pvhp)
+			       struct xen_remap_mfn_info *pvhp)
 
 {
 	struct remap_data rmd;
@@ -2629,7 +2629,7 @@ EXPORT_SYMBOL_GPL(xen_remap_domain_mfn_range);
 
 /* Returns: Number of pages unmapped */
 int xen_unmap_domain_mfn_range(struct vm_area_struct *vma,
-			       struct xen_pvh_pfn_info *pvhp)
+			       struct xen_remap_mfn_info *pvhp)
 {
 	int count = 0;
 
diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c
index bf4d62a..ebf3c8d 100644
--- a/drivers/xen/privcmd.c
+++ b/drivers/xen/privcmd.c
@@ -265,18 +265,16 @@ struct mmap_batch_state {
 	xen_pfn_t __user *user_mfn;
 };
 
-/* PVH dom0 fyi: if domU being created is PV, then mfn is mfn(addr on bus). If
- * it's PVH then mfn is pfn (input to HAP). */
 static int mmap_batch_fn(void *data, void *state)
 {
 	xen_pfn_t *mfnp = data;
 	struct mmap_batch_state *st = state;
 	struct vm_area_struct *vma = st->vma;
-	struct xen_pvh_pfn_info *pvhp = vma ? vma->vm_private_data : NULL;
+	struct xen_remap_mfn_info *info = vma ? vma->vm_private_data : NULL;
 	int ret;
 
 	ret = xen_remap_domain_mfn_range(st->vma, st->va & PAGE_MASK, *mfnp, 1,
-					 st->vma->vm_page_prot, st->domain, pvhp);
+					 st->vma->vm_page_prot, st->domain, info);
 
 	/* Store error code for second pass. */
 	*(st->err++) = ret;
@@ -315,33 +313,33 @@ static int mmap_return_errors_v1(void *data, void *state)
 /* Allocate pfns that are then mapped with gmfns from foreign domid. Update
  * the vma with the page info to use later.
  * Returns: 0 if success, otherwise -errno
- */ 
-static int pvh_privcmd_resv_pfns(struct vm_area_struct *vma, int numpgs)
+ */
+static int alloc_empty_pages(struct vm_area_struct *vma, int numpgs)
 {
 	int rc;
-	struct xen_pvh_pfn_info *pvhp;
+	struct xen_remap_mfn_info *info;
 
-	pvhp = kzalloc(sizeof(struct xen_pvh_pfn_info), GFP_KERNEL);
-	if (pvhp == NULL)
+	info = kzalloc(sizeof(struct xen_remap_mfn_info), GFP_KERNEL);
+	if (info == NULL)
 		return -ENOMEM;
 
-	pvhp->pi_paga = kcalloc(numpgs, sizeof(pvhp->pi_paga[0]), GFP_KERNEL);
-	if (pvhp->pi_paga == NULL) {
-		kfree(pvhp);
+	info->pi_paga = kcalloc(numpgs, sizeof(info->pi_paga[0]), GFP_KERNEL);
+	if (info->pi_paga == NULL) {
+		kfree(info);
 		return -ENOMEM;
 	}
 
-	rc = alloc_xenballooned_pages(numpgs, pvhp->pi_paga, 0);
+	rc = alloc_xenballooned_pages(numpgs, info->pi_paga, 0);
 	if (rc != 0) {
 		pr_warn("%s Could not alloc %d pfns rc:%d\n", __FUNCTION__, 
 			numpgs, rc);
-		kfree(pvhp->pi_paga);
-		kfree(pvhp);
+		kfree(info->pi_paga);
+		kfree(info);
 		return -ENOMEM;
 	}
-	pvhp->pi_num_pgs = numpgs;
+	info->pi_num_pgs = numpgs;
 	BUG_ON(vma->vm_private_data != (void *)1);
-	vma->vm_private_data = pvhp;
+	vma->vm_private_data = info;
 
 	return 0;
 }
@@ -414,7 +412,7 @@ static long privcmd_ioctl_mmap_batch(void __user *udata, int version)
 		goto out;
 	}
 	if (xen_feature(XENFEAT_auto_translated_physmap)) {
-		if ((ret = pvh_privcmd_resv_pfns(vma, m.num))) {
+		if ((ret = alloc_empty_pages(vma, m.num))) {
 			up_write(&mm->mmap_sem);
 			goto out;
 		}
@@ -490,16 +488,16 @@ static long privcmd_ioctl(struct file *file,
 static void privcmd_close(struct vm_area_struct *vma)
 {
 	int count;
-	struct xen_pvh_pfn_info *pvhp = vma ? vma->vm_private_data : NULL;
+	struct xen_remap_mfn_info *info = vma ? vma->vm_private_data : NULL;
 
-	if (!pvhp || !xen_feature(XENFEAT_auto_translated_physmap))
+	if (!info || !xen_feature(XENFEAT_auto_translated_physmap))
 		return;
 
-	count = xen_unmap_domain_mfn_range(vma, pvhp);
+	count = xen_unmap_domain_mfn_range(vma, info);
 	while (count--)
-		free_xenballooned_pages(1, &pvhp->pi_paga[count]);
-	kfree(pvhp->pi_paga);
-	kfree(pvhp);
+		free_xenballooned_pages(1, &info->pi_paga[count]);
+	kfree(info->pi_paga);
+	kfree(info);
 }
 
 static int privcmd_fault(struct vm_area_struct *vma, struct vm_fault *vmf)
diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
index 6c5ad83..2f3cb06 100644
--- a/include/xen/xen-ops.h
+++ b/include/xen/xen-ops.h
@@ -24,16 +24,16 @@ int xen_create_contiguous_region(unsigned long vstart, unsigned int order,
 void xen_destroy_contiguous_region(unsigned long vstart, unsigned int order);
 
 struct vm_area_struct;
-struct xen_pvh_pfn_info;
+struct xen_remap_mfn_info;
 int xen_remap_domain_mfn_range(struct vm_area_struct *vma,
 			       unsigned long addr,
 			       unsigned long mfn, int nr,
 			       pgprot_t prot, unsigned domid,
-			       struct xen_pvh_pfn_info *pvhp);
+			       struct xen_remap_mfn_info *pvhp);
 int xen_unmap_domain_mfn_range(struct vm_area_struct *vma,
-			       struct xen_pvh_pfn_info *pvhp);
+			       struct xen_remap_mfn_info *pvhp);
 
-struct xen_pvh_pfn_info {
+struct xen_remap_mfn_info {
 	struct page **pi_paga;		/* pfn info page array */
 	int 	      pi_num_pgs;
 	int 	      pi_next_todo;
-- 
1.7.2.5

  parent reply	other threads:[~2012-10-04 15:11 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-04 15:11 [RFC 00/14] arm: implement ballooning and privcmd foreign mappings based on x86 PVH Ian Campbell
2012-10-04 15:11 ` [PATCH 01/14] Build fixes which I beleive others have already fixed properly elsewhere Ian Campbell
2012-10-04 15:15   ` Konrad Rzeszutek Wilk
2012-10-04 15:11 ` [PATCH 02/14] xenbus: include features header Ian Campbell
2012-10-04 15:11 ` [PATCH 03/14] xen events: xen_callback_vector is x86 specific Ian Campbell
2012-10-05 11:43   ` Stefano Stabellini
2012-10-05 11:47     ` Ian Campbell
2012-10-05 18:40       ` Mukesh Rathor
2012-10-04 15:11 ` [PATCH 04/14] xen: balloon: don't include e820.h Ian Campbell
2012-10-04 15:11 ` [PATCH 05/14] xen: balloon: use correct type for frame_list Ian Campbell
2012-10-05 11:48   ` Stefano Stabellini
2012-10-05 12:32     ` Ian Campbell
2012-10-05 14:02       ` Stefano Stabellini
2012-10-05 14:33         ` Ian Campbell
2012-10-05 14:54           ` Stefano Stabellini
2012-10-05 16:11           ` Ian Campbell
2012-10-05 16:17             ` Ian Campbell
2012-10-09 12:31             ` Stefano Stabellini
2012-10-04 15:11 ` [PATCH 06/14] arm: make p2m operations NOPs Ian Campbell
2012-10-05 11:53   ` Stefano Stabellini
2012-10-04 15:11 ` [PATCH 07/14] xen: balloon: do not update stage 1 pagetable for autotranslated guests Ian Campbell
2012-10-05 12:05   ` Stefano Stabellini
2012-10-05 19:10     ` Mukesh Rathor
2012-10-04 15:11 ` [PATCH 08/14] xen: balloon: allow PVMMU interfaces to be compiled out Ian Campbell
2012-10-05 13:19   ` Stefano Stabellini
2012-10-05 13:33     ` Ian Campbell
2012-10-05 14:04       ` Stefano Stabellini
2012-10-05 14:05         ` Stefano Stabellini
2012-10-05 14:35         ` Ian Campbell
2012-10-04 15:11 ` [PATCH 09/14] xen: arm: enable balloon driver Ian Campbell
2012-10-05 13:18   ` Stefano Stabellini
2012-10-04 15:11 ` Ian Campbell [this message]
2012-10-05 13:37   ` [PATCH 10/14] privcmd: refer to autotranslate not PVH in arch interfaces / comments Stefano Stabellini
2012-10-05 13:39     ` Ian Campbell
2012-10-04 15:11 ` [PATCH 11/14] arm: implement remap interfaces needed for privcmd mappings Ian Campbell
2012-10-04 15:24   ` Konrad Rzeszutek Wilk
2012-10-04 15:48     ` Ian Campbell
2012-10-04 15:54       ` Konrad Rzeszutek Wilk
2012-10-05 13:36   ` Stefano Stabellini
2012-10-05 13:42     ` Ian Campbell
2012-10-09  0:59       ` Mukesh Rathor
2012-10-04 15:11 ` [PATCH 12/14] arm: xen: explain the EXPERIMENTAL dependency in the Kconfig help Ian Campbell
2012-10-05 13:21   ` Stefano Stabellini
2012-10-05 13:29     ` Ian Campbell
2012-10-04 15:11 ` [PATCH 13/14] xen: use xen_pft_t in struct xen_remove_from_physmap Ian Campbell
2012-10-05 13:22   ` Stefano Stabellini
2012-10-04 15:11 ` [PATCH 14/14] arm: implement foreign mapping using XENMEM_add_to_physmap_range Ian Campbell
2012-10-05 13:36   ` Stefano Stabellini
2012-10-05 13:51     ` Ian Campbell
2012-10-04 15:27 ` [RFC 00/14] arm: implement ballooning and privcmd foreign mappings based on x86 PVH Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1349363515-26190-10-git-send-email-ian.campbell@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=mukesh.rathor@oracle.com \
    --cc=stefano.stabellini@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).