xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Stefano Stabellini <stefano.stabellini@citrix.com>,
	Mukesh Rathor <mukesh.rathor@oracle.com>
Cc: Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
Subject: [PATCH 07/14] xen: balloon: do not update stage 1 pagetable for autotranslated guests
Date: Thu, 4 Oct 2012 16:11:48 +0100	[thread overview]
Message-ID: <1349363515-26190-7-git-send-email-ian.campbell@citrix.com> (raw)
In-Reply-To: <1349363496.866.49.camel@zakaz.uk.xensource.com>

This is unnecessary (since the page will be removed from the p2m) and
can be tricky if the page is in the middle of a superpage, as it is on
ARM.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
Also effects PVH but in a benign way I think.
---
 drivers/xen/balloon.c |   23 +++--------------------
 1 files changed, 3 insertions(+), 20 deletions(-)

diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
index 7885a19..1b56ae0 100644
--- a/drivers/xen/balloon.c
+++ b/drivers/xen/balloon.c
@@ -357,15 +357,7 @@ static enum bp_state increase_reservation(unsigned long nr_pages)
 		BUG_ON(!xen_feature(XENFEAT_auto_translated_physmap) &&
 		       phys_to_machine_mapping_valid(pfn));
 
-		if (xen_pv_domain() && 
-		    xen_feature(XENFEAT_auto_translated_physmap)) {
-			/* PVH: we just need to update native page table */
-			pte_t *ptep;
-			unsigned int level;
-			void *addr = __va(pfn << PAGE_SHIFT);
-			ptep = lookup_address((unsigned long)addr, &level);
-			set_pte(ptep, pfn_pte(pfn, PAGE_KERNEL));
-		} else
+		if (!xen_feature(XENFEAT_auto_translated_physmap))
 			set_phys_to_machine(pfn, frame_list[i]);
 
 		/* Link back into the page tables if not highmem. */
@@ -427,21 +419,12 @@ static enum bp_state decrease_reservation(unsigned long nr_pages, gfp_t gfp)
 
 		scrub_page(page);
 
-		if (xen_pv_domain() && !PageHighMem(page)) {
-			if (xen_feature(XENFEAT_auto_translated_physmap)) {
-				unsigned int level;
-				pte_t *ptep;
-				void *addr = __va(pfn << PAGE_SHIFT);
-				ptep = lookup_address((unsigned long)addr, 
-							&level);
-				set_pte(ptep, __pte(0));
-
-			} else {
+		if (xen_pv_domain() && !PageHighMem(page) &&
+		    !xen_feature(XENFEAT_auto_translated_physmap)) {
 				ret = HYPERVISOR_update_va_mapping(
 					(unsigned long)__va(pfn << PAGE_SHIFT),
 					__pte_ma(0), 0);
 				BUG_ON(ret);
-			}
 		}
 	}
 
-- 
1.7.2.5

  parent reply	other threads:[~2012-10-04 15:11 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-04 15:11 [RFC 00/14] arm: implement ballooning and privcmd foreign mappings based on x86 PVH Ian Campbell
2012-10-04 15:11 ` [PATCH 01/14] Build fixes which I beleive others have already fixed properly elsewhere Ian Campbell
2012-10-04 15:15   ` Konrad Rzeszutek Wilk
2012-10-04 15:11 ` [PATCH 02/14] xenbus: include features header Ian Campbell
2012-10-04 15:11 ` [PATCH 03/14] xen events: xen_callback_vector is x86 specific Ian Campbell
2012-10-05 11:43   ` Stefano Stabellini
2012-10-05 11:47     ` Ian Campbell
2012-10-05 18:40       ` Mukesh Rathor
2012-10-04 15:11 ` [PATCH 04/14] xen: balloon: don't include e820.h Ian Campbell
2012-10-04 15:11 ` [PATCH 05/14] xen: balloon: use correct type for frame_list Ian Campbell
2012-10-05 11:48   ` Stefano Stabellini
2012-10-05 12:32     ` Ian Campbell
2012-10-05 14:02       ` Stefano Stabellini
2012-10-05 14:33         ` Ian Campbell
2012-10-05 14:54           ` Stefano Stabellini
2012-10-05 16:11           ` Ian Campbell
2012-10-05 16:17             ` Ian Campbell
2012-10-09 12:31             ` Stefano Stabellini
2012-10-04 15:11 ` [PATCH 06/14] arm: make p2m operations NOPs Ian Campbell
2012-10-05 11:53   ` Stefano Stabellini
2012-10-04 15:11 ` Ian Campbell [this message]
2012-10-05 12:05   ` [PATCH 07/14] xen: balloon: do not update stage 1 pagetable for autotranslated guests Stefano Stabellini
2012-10-05 19:10     ` Mukesh Rathor
2012-10-04 15:11 ` [PATCH 08/14] xen: balloon: allow PVMMU interfaces to be compiled out Ian Campbell
2012-10-05 13:19   ` Stefano Stabellini
2012-10-05 13:33     ` Ian Campbell
2012-10-05 14:04       ` Stefano Stabellini
2012-10-05 14:05         ` Stefano Stabellini
2012-10-05 14:35         ` Ian Campbell
2012-10-04 15:11 ` [PATCH 09/14] xen: arm: enable balloon driver Ian Campbell
2012-10-05 13:18   ` Stefano Stabellini
2012-10-04 15:11 ` [PATCH 10/14] privcmd: refer to autotranslate not PVH in arch interfaces / comments Ian Campbell
2012-10-05 13:37   ` Stefano Stabellini
2012-10-05 13:39     ` Ian Campbell
2012-10-04 15:11 ` [PATCH 11/14] arm: implement remap interfaces needed for privcmd mappings Ian Campbell
2012-10-04 15:24   ` Konrad Rzeszutek Wilk
2012-10-04 15:48     ` Ian Campbell
2012-10-04 15:54       ` Konrad Rzeszutek Wilk
2012-10-05 13:36   ` Stefano Stabellini
2012-10-05 13:42     ` Ian Campbell
2012-10-09  0:59       ` Mukesh Rathor
2012-10-04 15:11 ` [PATCH 12/14] arm: xen: explain the EXPERIMENTAL dependency in the Kconfig help Ian Campbell
2012-10-05 13:21   ` Stefano Stabellini
2012-10-05 13:29     ` Ian Campbell
2012-10-04 15:11 ` [PATCH 13/14] xen: use xen_pft_t in struct xen_remove_from_physmap Ian Campbell
2012-10-05 13:22   ` Stefano Stabellini
2012-10-04 15:11 ` [PATCH 14/14] arm: implement foreign mapping using XENMEM_add_to_physmap_range Ian Campbell
2012-10-05 13:36   ` Stefano Stabellini
2012-10-05 13:51     ` Ian Campbell
2012-10-04 15:27 ` [RFC 00/14] arm: implement ballooning and privcmd foreign mappings based on x86 PVH Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1349363515-26190-7-git-send-email-ian.campbell@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=mukesh.rathor@oracle.com \
    --cc=stefano.stabellini@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).