xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Anthony PERARD <anthony.perard@citrix.com>
To: Xen Devel <xen-devel@lists.xen.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH V3 0/3] Cleanup: flexarray taking gc.
Date: Fri, 5 Oct 2012 10:04:28 +0100	[thread overview]
Message-ID: <1349427871-31195-1-git-send-email-anthony.perard@citrix.com> (raw)

This two patches do a bit of cleanup in the memomy managment in libxl,
regarding the use of flexarray.

The first one modify flexarray_make to take gc as argument and update every
user in libxl to pass gc and to not call flexarray_free anymore.

The second one does some cleanup only in libxl_json to make it use the gc.

Change since v2:
  - New patch to expose gc_is_real to libxl.

Change since v1:
  - Change order of the two patch to not end up with leaks.
  - Add a comment on the first patch to tell why it OK to store the gc in the
    flexarray struct.
  - Keep the _free functions (libxl__json_object_free and flexarray_free, as
    they can be used if gc in NOGC.


Anthony PERARD (3):
  libxl: Move gc_is_real to libxl_internal.h.
  libxl: Have flexarray using the GC
  libxl_json: Use libxl alloc function.

 tools/libxl/flexarray.c      | 43 +++++++++++--------
 tools/libxl/flexarray.h      |  7 +++-
 tools/libxl/libxl.c          | 99 +++++++++-----------------------------------
 tools/libxl/libxl_dm.c       | 15 ++-----
 tools/libxl/libxl_internal.c | 11 ++---
 tools/libxl/libxl_internal.h |  5 +++
 tools/libxl/libxl_json.c     | 93 +++++++++--------------------------------
 tools/libxl/libxl_pci.c      | 18 ++------
 tools/libxl/libxl_qmp.c      | 29 ++-----------
 9 files changed, 86 insertions(+), 234 deletions(-)

-- 
Anthony PERARD

             reply	other threads:[~2012-10-05  9:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-05  9:04 Anthony PERARD [this message]
2012-10-05  9:04 ` [PATCH V3 1/3] libxl: Move gc_is_real to libxl_internal.h Anthony PERARD
2012-10-05 10:15   ` Ian Jackson
2012-10-05  9:04 ` [PATCH V3 2/3] libxl: Have flexarray using the GC Anthony PERARD
2012-10-05 10:15   ` Ian Jackson
2012-10-05  9:04 ` [PATCH V3 3/3] libxl_json: Use libxl alloc function Anthony PERARD
2012-10-05 13:44 ` [PATCH V3 0/3] Cleanup: flexarray taking gc Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1349427871-31195-1-git-send-email-anthony.perard@citrix.com \
    --to=anthony.perard@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).