xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] libxl: Add a comment about NOGC usage with flexarray
@ 2012-10-05 14:49 Anthony PERARD
  2012-10-05 16:39 ` Ian Jackson
  0 siblings, 1 reply; 3+ messages in thread
From: Anthony PERARD @ 2012-10-05 14:49 UTC (permalink / raw)
  To: Xen Devel; +Cc: Anthony PERARD, Ian Jackson, Ian Campbell

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

---
 tools/libxl/flexarray.h | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/tools/libxl/flexarray.h b/tools/libxl/flexarray.h
index aade417..a1e8647 100644
--- a/tools/libxl/flexarray.h
+++ b/tools/libxl/flexarray.h
@@ -26,7 +26,13 @@ typedef struct flexarray {
     struct libxl__gc *gc;
 } flexarray_t;
 
-_hidden flexarray_t *flexarray_make(struct libxl__gc *gc, int size, int autogrow);
+/*
+ * NOGC can be used with flexarrays, but flexarray_free will need to be called
+ * to free the struct. The content of the flexarray will not be freed through
+ * flexarray_free.
+ */
+_hidden flexarray_t *flexarray_make(struct libxl__gc *gc_opt,
+                                    int size, int autogrow);
 _hidden void flexarray_free(flexarray_t *array);
 _hidden void flexarray_grow(flexarray_t *array, int extents);
 _hidden int flexarray_set(flexarray_t *array, unsigned int index, void *ptr);
-- 
Anthony PERARD

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] libxl: Add a comment about NOGC usage with flexarray
  2012-10-05 14:49 [PATCH] libxl: Add a comment about NOGC usage with flexarray Anthony PERARD
@ 2012-10-05 16:39 ` Ian Jackson
  2012-10-08 11:19   ` Ian Campbell
  0 siblings, 1 reply; 3+ messages in thread
From: Ian Jackson @ 2012-10-05 16:39 UTC (permalink / raw)
  To: Anthony PERARD; +Cc: Ian Campbell, Xen Devel

Anthony PERARD writes ("[PATCH] libxl: Add a comment about NOGC usage with flexarray"):
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] libxl: Add a comment about NOGC usage with flexarray
  2012-10-05 16:39 ` Ian Jackson
@ 2012-10-08 11:19   ` Ian Campbell
  0 siblings, 0 replies; 3+ messages in thread
From: Ian Campbell @ 2012-10-08 11:19 UTC (permalink / raw)
  To: Ian Jackson; +Cc: Anthony Perard, Xen Devel

On Fri, 2012-10-05 at 17:39 +0100, Ian Jackson wrote:
> Anthony PERARD writes ("[PATCH] libxl: Add a comment about NOGC usage with flexarray"):
> > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> 
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-10-08 11:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-05 14:49 [PATCH] libxl: Add a comment about NOGC usage with flexarray Anthony PERARD
2012-10-05 16:39 ` Ian Jackson
2012-10-08 11:19   ` Ian Campbell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).