From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH 3 of 8] xen: let the (credit) scheduler know
 about `node affinity`
Date: Tue, 9 Oct 2012 11:29:01 +0100
Message-ID: <1349778541.3610.62.camel@Abyss>
References: <patchbomb.1349446098@Solace>
	<ca2fa958879bbffa9bc6.1349446101@Solace>
	<506F0A1602000078000A00F4@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3493500228190797503=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <506F0A1602000078000A00F4@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Andre Przywara <andre.przywara@amd.com>, Ian Campbell <Ian.Campbell@citrix.com>, Marcus Granado <Marcus.Granado@eu.citrix.com>, George Dunlap <george.dunlap@eu.citrix.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>, Juergen Gross <juergen.gross@ts.fujitsu.com>, Anil Madhavapeddy <anil@recoil.org>, Ian Jackson <Ian.Jackson@eu.citrix.com>, xen-devel@lists.xen.org, Matt Wilson <msw@amazon.com>, Daniel De Graaf <dgdegra@tycho.nsa.gov>
List-Id: xen-devel@lists.xenproject.org

--===============3493500228190797503==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-Tqz0G30cTLhy8/z7osPg"

--=-Tqz0G30cTLhy8/z7osPg
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2012-10-05 at 15:25 +0100, Jan Beulich wrote:=20
> >>> On 05.10.12 at 16:08, Dario Faggioli <dario.faggioli@citrix.com> wrot=
e:
> > @@ -287,22 +344,26 @@ static inline void
> >          }
> >          else
> >          {
> > -            cpumask_t idle_mask;
> > +            cpumask_t idle_mask, balance_mask;
>=20
> Be _very_ careful about adding on-stack CPU mask variables
> (also further below): each one of them grows the stack frame
> by 512 bytes (when building for the current maximum of 4095
> CPUs), which is generally too much; you may want to consider
> pre-allocated scratch space instead.
>=20
I see your point, and I think you're right... I wasn't "thinking that
big". :-)

I'll look into all of these situations and see if I can move the masks
off the stack. Any preference between global variables and members of
one of the scheduler's data structures?

Thanks and Regards,
Dario

--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)



--=-Tqz0G30cTLhy8/z7osPg
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEABECAAYFAlBz/G0ACgkQk4XaBE3IOsRUbQCdG+9/3A4DQmUssU1RPuaOZuZA
aUgAnAx8uh7oRGVggL5/2eJzHzFpQAOJ
=9cMO
-----END PGP SIGNATURE-----

--=-Tqz0G30cTLhy8/z7osPg--


--===============3493500228190797503==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============3493500228190797503==--