xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xensource.com
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Subject: [PATCH 3/3] docs, build: Do not ignore install-docs errors
Date: Tue, 9 Oct 2012 17:27:39 +0100	[thread overview]
Message-ID: <1349800059-18689-4-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1349776105.21847.112.camel@zakaz.uk.xensource.com>

In the toplevel Makefile "install-docs" (depended on by "install" and
hence "dist"), but not "build", ignores errors.

This was inherited from before 24563:4271634e4c86, prior to which the
||true seems intended to handle failures of check_pkgs.  Nowadays we
handle docs tools individually in the docs makefiles so there is no
need for this ||true here.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index 373ca19..b54cfbf 100644
--- a/Makefile
+++ b/Makefile
@@ -103,7 +103,7 @@ tools/firmware/seabios-dir-force-update:
 
 .PHONY: install-docs
 install-docs:
-	$(MAKE) -C docs install || true
+	$(MAKE) -C docs install
 
 .PHONY: dev-docs
 dev-docs:
-- 
1.7.2.5

      parent reply	other threads:[~2012-10-09 16:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-08 19:55 [xen-unstable test] 13934: regressions - FAIL xen.org
2012-10-09  7:50 ` Ian Campbell
2012-10-09  9:26   ` Ian Jackson
2012-10-09  9:35     ` Ian Jackson
2012-10-09  9:48       ` Ian Campbell
2012-10-09 16:27         ` [PATCH v2 0/3] docs, build: Do not ignore install-docs errors Ian Jackson
2012-10-09 16:43           ` Ian Campbell
2012-10-09 16:27         ` [PATCH 1/3] docs, build: Tolerate missing fig2dev Ian Jackson
2012-10-09 16:27         ` [PATCH 2/3] docs, build: Tolerate missing pod2text Ian Jackson
2012-10-09 16:27         ` Ian Jackson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1349800059-18689-4-git-send-email-ian.jackson@eu.citrix.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).