From: linux@eikelenboom.it
To: xen-devel@lists.xen.org
Cc: Sander Eikelenboom <linux@eikelenboom.it>, Ian.Campbell@citrix.com
Subject: [PATCH 1/3] init/sysconfig scripts: Remove --halt/-H option for shutdown command.
Date: Thu, 11 Oct 2012 10:25:07 +0200 [thread overview]
Message-ID: <1349943909-2495-2-git-send-email-linux@eikelenboom.it> (raw)
In-Reply-To: <1349943909-2495-1-git-send-email-linux@eikelenboom.it>
From: Sander Eikelenboom <linux@eikelenboom.it>
The --halt/-H option for the shutdown command is now pointless,
since linux in a guest treats "halt" and "poweroff" identically.
The option is not implemented in xl / libxl and if supplied causes the command
to fail , so remove it from the init and sysconfig scripts.
Signed-off-by: Sander Eikelenboom <linux@eikelenboom.it>
---
tools/hotplug/Linux/init.d/sysconfig.xendomains | 12 ++++++------
tools/hotplug/Linux/init.d/xendomains | 4 ++--
tools/hotplug/NetBSD/rc.d/xendomains | 2 +-
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/tools/hotplug/Linux/init.d/sysconfig.xendomains b/tools/hotplug/Linux/init.d/sysconfig.xendomains
index e590d3f..4775277 100644
--- a/tools/hotplug/Linux/init.d/sysconfig.xendomains
+++ b/tools/hotplug/Linux/init.d/sysconfig.xendomains
@@ -56,29 +56,29 @@ XENDOMAINS_MIGRATE=""
XENDOMAINS_SAVE=/var/lib/xen/save
## Type: string
-## Default: "--halt --wait"
+## Default: "--wait"
#
# If neither MIGRATE nor SAVE were enabled or if they failed, you can
# try to shut down a domain by sending it a shutdown request. To do this,
-# set this to "--halt --wait". Omit the "--wait" flag to avoid waiting
+# set this to "--wait". Omit the "--wait" flag to avoid waiting
# for the domain to be really down. Leave empty to skip domain shutdown.
#
-XENDOMAINS_SHUTDOWN="--halt --wait"
+XENDOMAINS_SHUTDOWN="--wait"
## Type: string
-## Default: "--all --halt --wait"
+## Default: "--all --wait"
#
# After we have gone over all virtual machines (resp. all automatically
# started ones, see XENDOMAINS_AUTO_ONLY below) in a loop and sent SysRq,
# migrated, saved and/or shutdown according to the settings above, we
# might want to shutdown the virtual machines that are still running
# for some reason or another. To do this, set this variable to
-# "--all --halt --wait", it will be passed to xm shutdown.
+# "--all --wait", it will be passed to xm shutdown.
# Leave it empty not to do anything special here.
# (Note: This will hit all virtual machines, even if XENDOMAINS_AUTO_ONLY
# is set.)
#
-XENDOMAINS_SHUTDOWN_ALL="--all --halt --wait"
+XENDOMAINS_SHUTDOWN_ALL="--all --wait"
## Type: boolean
## Default: true
diff --git a/tools/hotplug/Linux/init.d/xendomains b/tools/hotplug/Linux/init.d/xendomains
index c033581..c363208 100644
--- a/tools/hotplug/Linux/init.d/xendomains
+++ b/tools/hotplug/Linux/init.d/xendomains
@@ -434,7 +434,7 @@ stop()
fi
fi
if test -n "$XENDOMAINS_SHUTDOWN"; then
- # XENDOMAINS_SHUTDOWN should be "--halt --wait"
+ # XENDOMAINS_SHUTDOWN should be "--wait"
echo -n "(shut)"
watchdog_xencmd shutdown &
WDOG_PID=$!
@@ -453,7 +453,7 @@ stop()
# This is because it's easier to do ;-) but arguably if this script is run
# on system shutdown then it's also the right thing to do.
if ! all_zombies && test -n "$XENDOMAINS_SHUTDOWN_ALL"; then
- # XENDOMAINS_SHUTDOWN_ALL should be "--all --halt --wait"
+ # XENDOMAINS_SHUTDOWN_ALL should be "--all --wait"
echo -n " SHUTDOWN_ALL "
watchdog_xencmd shutdown 1 false &
WDOG_PID=$!
diff --git a/tools/hotplug/NetBSD/rc.d/xendomains b/tools/hotplug/NetBSD/rc.d/xendomains
index c368c58..3e62038 100644
--- a/tools/hotplug/NetBSD/rc.d/xendomains
+++ b/tools/hotplug/NetBSD/rc.d/xendomains
@@ -94,7 +94,7 @@ xendomains_stop()
#
echo "Stopping xen domains."
for domain in $(xendomains_list); do
- ${ctl_command} shutdown --halt $domain
+ ${ctl_command} shutdown $domain
done
while [ $timeout -gt 0 ]; do
livedomains=$(xendomains_list)
--
1.7.2.5
next prev parent reply other threads:[~2012-10-11 8:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-11 8:25 Fix xl shutdown and init / sysconfig behaviour linux
2012-10-11 8:25 ` linux [this message]
2012-10-11 8:52 ` [PATCH 1/3] init/sysconfig scripts: Remove --halt/-H option for shutdown command Ian Campbell
2012-10-11 9:05 ` Christoph Egger
2012-10-11 10:52 ` Ian Campbell
2012-10-11 8:25 ` [PATCH 2/3] init scripts: xendomains correct order of options " linux
2012-10-11 9:21 ` Ian Campbell
2012-10-11 8:25 ` [PATCH 3/3] xl/libxl: make shutdown accept the long option --wait for -w linux
2012-10-11 8:58 ` Ian Campbell
2012-10-11 10:25 ` [PATCH v2 " linux
2012-10-11 10:52 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349943909-2495-2-git-send-email-linux@eikelenboom.it \
--to=linux@eikelenboom.it \
--cc=Ian.Campbell@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).