xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: linux@eikelenboom.it
To: xen-devel@lists.xen.org
Cc: Sander Eikelenboom <linux@eikelenboom.it>, Ian.Campbell@citrix.com
Subject: [PATCH 2/3] init scripts: xendomains correct order of options for shutdown command
Date: Thu, 11 Oct 2012 10:25:08 +0200	[thread overview]
Message-ID: <1349943909-2495-3-git-send-email-linux@eikelenboom.it> (raw)
In-Reply-To: <1349943909-2495-1-git-send-email-linux@eikelenboom.it>

From: Sander Eikelenboom <linux@eikelenboom.it>

Options for the shutdown command that are supplied behind the domain id are
ignored. In case of the default xendomains init script this means that it will
not wait for the domains to be actually shutdown.

Signed-off-by: Sander Eikelenboom <linux@eikelenboom.it>
---
 tools/hotplug/Linux/init.d/xendomains |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/hotplug/Linux/init.d/xendomains b/tools/hotplug/Linux/init.d/xendomains
index c363208..00e5944 100644
--- a/tools/hotplug/Linux/init.d/xendomains
+++ b/tools/hotplug/Linux/init.d/xendomains
@@ -438,7 +438,7 @@ stop()
 	    echo -n "(shut)"
 	    watchdog_xencmd shutdown &
 	    WDOG_PID=$!
-	    XMR=`$CMD shutdown $id $XENDOMAINS_SHUTDOWN 2>&1 1>/dev/null`
+	    XMR=`$CMD shutdown $XENDOMAINS_SHUTDOWN $id 2>&1 1>/dev/null`
 	    if test $? -ne 0; then
 		echo -e "\nAn error occurred while shutting down domain:\n$XMR\n"
 		rc_failed $?
-- 
1.7.2.5

  parent reply	other threads:[~2012-10-11  8:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-11  8:25 Fix xl shutdown and init / sysconfig behaviour linux
2012-10-11  8:25 ` [PATCH 1/3] init/sysconfig scripts: Remove --halt/-H option for shutdown command linux
2012-10-11  8:52   ` Ian Campbell
2012-10-11  9:05     ` Christoph Egger
2012-10-11 10:52       ` Ian Campbell
2012-10-11  8:25 ` linux [this message]
2012-10-11  9:21   ` [PATCH 2/3] init scripts: xendomains correct order of options " Ian Campbell
2012-10-11  8:25 ` [PATCH 3/3] xl/libxl: make shutdown accept the long option --wait for -w linux
2012-10-11  8:58   ` Ian Campbell
2012-10-11 10:25     ` [PATCH v2 " linux
2012-10-11 10:52       ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1349943909-2495-3-git-send-email-linux@eikelenboom.it \
    --to=linux@eikelenboom.it \
    --cc=Ian.Campbell@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).