Re: [PATCH] hotplug/Linux: close lockfd after lock attempt

[Ian Campbell <Ian.Campbell@citrix.com>]

On Sat, 2012-10-13 at 23:35 +0100, Olaf Hering wrote:
> On Sat, Oct 13, Olaf Hering wrote:
> 
> > hotplug/Linux: close lockfd after lock attempt
> > 
> > When a HVM guest is shutdown some of the 'remove' events can not claim
> > the lock for some reason. Instead they try to grab the lock in a busy
> > loop, until udev reaps the xen-hotplug-cleanup helper.
> > After analyzing the resulting logfile its not obvious what the cause is.
> > The only explanation is that bash (?) gets confused if the same lockfd
> > is opened again and again. Closing it in each iteration seem to fix the
> > issue.
> 
> Can be reproduced with this testcase on sles11sp2, not on openSuSE 11.4:

So this is a bash bug? Have you reported it against bash?

Ian.

> 
>  # cat test.sh
> set -x
> source locking.sh
> 
> l=lock
> claim_lock $l
> sleep 1
> release_lock $l
> 
> 
>  # bash test.sh & bash test.sh & bash test.sh & bash test.sh &
> 
> 
> Olaf
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel