From: Ian Campbell <ian.campbell@citrix.com>
To: xen-devel@lists.xen.org
Cc: Keir Fraser <keir@xen.org>,
Ian Campbell <ian.campbell@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Tim Deegan <tim@xen.org>,
Stefano Stabellini <stefano.stabellini@citrix.com>,
Jan Beulich <JBeulich@suse.com>
Subject: [PATCH 04/10] xen: xen_ulong_t substitution
Date: Mon, 15 Oct 2012 15:20:37 +0000 [thread overview]
Message-ID: <1350314444-17148-4-git-send-email-ian.campbell@citrix.com> (raw)
In-Reply-To: <1350314418.18058.72.camel@zakaz.uk.xensource.com>
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
There is still an unwanted unsigned long in the xen public interface:
replace it with xen_ulong_t.
Also typedef xen_ulong_t to uint64_t on ARM.
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Cc: keir@xen.org
Cc: JBeulich@suse.com
---
Changes in v2:
- do not replace the unsigned long in x86 specific calls;
- do not replace the unsigned long in multicall_entry;
- add missing include "xen.h" in version.h;
- use proper printf flag for xen_ulong_t.
---
tools/python/xen/lowlevel/xc/xc.c | 2 +-
xen/include/public/arch-arm.h | 3 ++-
xen/include/public/arch-x86/xen.h | 1 +
xen/include/public/version.h | 4 +++-
4 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/tools/python/xen/lowlevel/xc/xc.c b/tools/python/xen/lowlevel/xc/xc.c
index 7c89756..e220f68 100644
--- a/tools/python/xen/lowlevel/xc/xc.c
+++ b/tools/python/xen/lowlevel/xc/xc.c
@@ -1439,7 +1439,7 @@ static PyObject *pyxc_xeninfo(XcObject *self)
if ( xc_version(self->xc_handle, XENVER_commandline, &xen_commandline) != 0 )
return pyxc_error_to_exception(self->xc_handle);
- snprintf(str, sizeof(str), "virt_start=0x%lx", p_parms.virt_start);
+ snprintf(str, sizeof(str), "virt_start=0x%"PRI_xen_ulong, p_parms.virt_start);
xen_pagesize = xc_version(self->xc_handle, XENVER_pagesize, NULL);
if (xen_pagesize < 0 )
diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
index e3d4ad9..2ae6548 100644
--- a/xen/include/public/arch-arm.h
+++ b/xen/include/public/arch-arm.h
@@ -122,7 +122,8 @@ typedef uint64_t xen_pfn_t;
/* Only one. All other VCPUS must use VCPUOP_register_vcpu_info */
#define XEN_LEGACY_MAX_VCPUS 1
-typedef uint32_t xen_ulong_t;
+typedef uint64_t xen_ulong_t;
+#define PRI_xen_ulong PRIx64
struct vcpu_guest_context {
#define _VGCF_online 0
diff --git a/xen/include/public/arch-x86/xen.h b/xen/include/public/arch-x86/xen.h
index 1c186d7..fff8824 100644
--- a/xen/include/public/arch-x86/xen.h
+++ b/xen/include/public/arch-x86/xen.h
@@ -85,6 +85,7 @@ typedef unsigned long xen_pfn_t;
#ifndef __ASSEMBLY__
typedef unsigned long xen_ulong_t;
+#define PRI_xen_ulong "lx"
/*
* ` enum neg_errnoval
diff --git a/xen/include/public/version.h b/xen/include/public/version.h
index 8742c2b..c7e6f8c 100644
--- a/xen/include/public/version.h
+++ b/xen/include/public/version.h
@@ -28,6 +28,8 @@
#ifndef __XEN_PUBLIC_VERSION_H__
#define __XEN_PUBLIC_VERSION_H__
+#include "xen.h"
+
/* NB. All ops return zero on success, except XENVER_{version,pagesize} */
/* arg == NULL; returns major:minor (16:16). */
@@ -58,7 +60,7 @@ typedef char xen_changeset_info_t[64];
#define XENVER_platform_parameters 5
struct xen_platform_parameters {
- unsigned long virt_start;
+ xen_ulong_t virt_start;
};
typedef struct xen_platform_parameters xen_platform_parameters_t;
--
1.7.9.1
next prev parent reply other threads:[~2012-10-15 15:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-15 15:20 [PATCH v2 00/10] 64 bit ARM ABI, map foreign gmfn API, ARM grant tables Ian Campbell
2012-10-15 15:20 ` [PATCH 01/10] xen: arm: implement XENMEM_add_to_physmap_range Ian Campbell
2012-10-17 15:31 ` Stefano Stabellini
2012-10-17 15:38 ` Ian Campbell
2012-10-15 15:20 ` [PATCH 02/10] xen/arm: grant table Ian Campbell
2012-10-15 15:20 ` [PATCH 03/10] arm: tools: add arm to foreign structs checking Ian Campbell
2012-10-15 15:20 ` Ian Campbell [this message]
2012-10-15 15:20 ` [PATCH 05/10] xen: change the limit of nr_extents to UINT_MAX >> MEMOP_EXTENT_SHIFT Ian Campbell
2012-10-15 15:20 ` [PATCH 06/10] xen: introduce XEN_GUEST_HANDLE_PARAM Ian Campbell
2012-10-15 15:20 ` [PATCH 07/10] xen: replace XEN_GUEST_HANDLE with XEN_GUEST_HANDLE_PARAM when appropriate Ian Campbell
2012-10-15 15:20 ` [PATCH 08/10] xen: more XEN_GUEST_HANDLE_PARAM substitutions Ian Campbell
2012-10-15 15:20 ` [PATCH 09/10] xen: remove XEN_GUEST_HANDLE(ulong) Ian Campbell
2012-10-17 13:54 ` Stefano Stabellini
2012-10-18 6:50 ` Jan Beulich
2012-10-18 7:32 ` Ian Campbell
2012-10-18 7:50 ` Jan Beulich
2012-10-18 8:35 ` Ian Campbell
2012-10-15 15:20 ` [PATCH 10/10] arm: parameter guest handles are 32 bit on 32 bit hypervisor Ian Campbell
2012-10-17 13:50 ` Stefano Stabellini
2012-10-17 13:53 ` Ian Campbell
2012-10-17 15:25 ` Stefano Stabellini
2012-10-15 15:48 ` [PATCH v2 00/10] 64 bit ARM ABI, map foreign gmfn API, ARM grant tables Keir Fraser
2012-10-16 14:45 ` Ian Campbell
2012-10-17 15:44 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350314444-17148-4-git-send-email-ian.campbell@citrix.com \
--to=ian.campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).