From: Ian Campbell <Ian.Campbell@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: "linux@eikelenboom.it" <linux@eikelenboom.it>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH 2 of 5] xl: Introduce xl shutdown --all support for xm compatibility
Date: Thu, 18 Oct 2012 09:24:15 +0100 [thread overview]
Message-ID: <1350548655.28188.37.camel@dagon.hellion.org.uk> (raw)
In-Reply-To: <20606.54983.746418.437132@mariner.uk.xensource.com>
On Wed, 2012-10-17 at 17:03 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH 2 of 5] xl: Introduce xl shutdown --all support for xm compatibility"):
> > xl: Introduce xl shutdown --all support for xm compatibility
> ...>
> > Based on a patch by Sander Eikelenboom
> ...
> > int main_shutdown(int argc, char **argv)
> ...
> > + if (wait_for_it)
> > + deathws = calloc(nb_domain, sizeof(deathws));
>
> This should read sizeof(*deathws). It's a shame we don't have a macro
> to avoid this broken pattern in xl. In libxl we have GCNEW_ARRAY of
> course. (In fact in this particular case the two things are both
> pointers so the sizeof() is the same and the bug is theoretical.)
Oops, will fix upon commit, thanks.
> Apart from that,
>
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
>
> Ian.
next prev parent reply other threads:[~2012-10-18 8:24 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-15 10:09 [PATCH 0 of 5] xl shutdown compatibility with xm Ian Campbell
2012-10-15 10:09 ` [PATCH 1 of 5] libxl: propagate user supplied values into event for_user field Ian Campbell
2012-10-17 15:58 ` Ian Jackson
2012-10-15 10:09 ` [PATCH 2 of 5] xl: Introduce xl shutdown --all support for xm compatibility Ian Campbell
2012-10-17 16:03 ` Ian Jackson
2012-10-18 8:24 ` Ian Campbell [this message]
2012-10-15 10:09 ` [PATCH 3 of 5] xl: Add --wait and --all to xl reboot Ian Campbell
2012-10-17 16:04 ` Ian Jackson
2012-10-15 10:09 ` [PATCH 4 of 5] xl: allow def_getopt to handle long options Ian Campbell
2012-10-17 16:05 ` Ian Jackson
2012-10-15 10:09 ` [PATCH 5 of 5] xl: Introduce helper macro for option parsing Ian Campbell
2012-10-17 16:13 ` Ian Jackson
2012-10-18 7:42 ` Ian Campbell
2012-10-15 10:32 ` [PATCH 0 of 5] xl shutdown compatibility with xm Sander Eikelenboom
2012-10-15 10:37 ` Ian Campbell
2012-10-15 11:21 ` Sander Eikelenboom
2012-10-15 11:45 ` Ian Campbell
2012-10-16 8:59 ` Sander Eikelenboom
2012-10-16 9:43 ` Ian Campbell
2012-10-16 10:06 ` Sander Eikelenboom
2012-10-19 10:21 ` Ian Jackson
2012-10-25 15:18 ` Sander Eikelenboom
2012-10-25 15:23 ` Ian Jackson
2012-10-25 15:32 ` Sander Eikelenboom
2012-10-25 15:47 ` Ian Campbell
2012-10-25 15:55 ` Sander Eikelenboom
2012-10-25 15:56 ` Ian Jackson
2012-10-25 17:27 ` Sander Eikelenboom
2012-10-25 15:34 ` Ian Campbell
2012-10-25 15:41 ` Ian Jackson
2012-10-18 8:35 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350548655.28188.37.camel@dagon.hellion.org.uk \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=linux@eikelenboom.it \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).