From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 2 of 5] xl: Introduce xl shutdown --all support for xm compatibility Date: Thu, 18 Oct 2012 09:24:15 +0100 Message-ID: <1350548655.28188.37.camel@dagon.hellion.org.uk> References: <2329dca4ef449979b140.1350295791@cosworth.uk.xensource.com> <20606.54983.746418.437132@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20606.54983.746418.437132@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: "linux@eikelenboom.it" , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Wed, 2012-10-17 at 17:03 +0100, Ian Jackson wrote: > Ian Campbell writes ("[PATCH 2 of 5] xl: Introduce xl shutdown --all support for xm compatibility"): > > xl: Introduce xl shutdown --all support for xm compatibility > ...> > > Based on a patch by Sander Eikelenboom > ... > > int main_shutdown(int argc, char **argv) > ... > > + if (wait_for_it) > > + deathws = calloc(nb_domain, sizeof(deathws)); > > This should read sizeof(*deathws). It's a shame we don't have a macro > to avoid this broken pattern in xl. In libxl we have GCNEW_ARRAY of > course. (In fact in this particular case the two things are both > pointers so the sizeof() is the same and the bug is theoretical.) Oops, will fix upon commit, thanks. > Apart from that, > > Acked-by: Ian Jackson > > Ian.