xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* xl: Fix accidently waiting for domains to shutdown without --wait option
@ 2012-10-19 23:13 linux
  2012-10-19 23:13 ` [PATCH 1/1] " linux
  0 siblings, 1 reply; 4+ messages in thread
From: linux @ 2012-10-19 23:13 UTC (permalink / raw)
  To: xen-devel; +Cc: Ian.Jackson, ian.campbell

xl: Fix accidently waiting for domains to shutdown without --wait option

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/1] xl: Fix accidently waiting for domains to shutdown without --wait option
  2012-10-19 23:13 xl: Fix accidently waiting for domains to shutdown without --wait option linux
@ 2012-10-19 23:13 ` linux
  2012-10-25 13:47   ` Sander Eikelenboom
  2012-10-25 15:05   ` Ian Jackson
  0 siblings, 2 replies; 4+ messages in thread
From: linux @ 2012-10-19 23:13 UTC (permalink / raw)
  To: xen-devel; +Cc: Ian.Jackson, ian.campbell

From: Sander Eikelenboom <linux@eikelenboom>

Introduced by changeset 26091: "xl: Add --wait and --all to xl reboot."

Signed-off-by: Sander Eikelenboom <linux@eikelenboom>
---
 tools/libxl/xl_cmdimpl.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
index dc80595..0e65f2b 100644
--- a/tools/libxl/xl_cmdimpl.c
+++ b/tools/libxl/xl_cmdimpl.c
@@ -3774,7 +3774,9 @@ static int main_shutdown_or_reboot(int reboot, int argc, char **argv)
                fallback_trigger);
         }
 
-        wait_for_domain_deaths(deathws, nb_domain - 1 /* not dom 0 */);
+        if (wait_for_it)
+            wait_for_domain_deaths(deathws, nb_domain - 1 /* not dom 0 */);
+
         libxl_dominfo_list_free(dominfo, nb_domain);
     } else {
         libxl_evgen_domain_death *deathw = NULL;
-- 
1.7.2.5

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] xl: Fix accidently waiting for domains to shutdown without --wait option
  2012-10-19 23:13 ` [PATCH 1/1] " linux
@ 2012-10-25 13:47   ` Sander Eikelenboom
  2012-10-25 15:05   ` Ian Jackson
  1 sibling, 0 replies; 4+ messages in thread
From: Sander Eikelenboom @ 2012-10-25 13:47 UTC (permalink / raw)
  To: linux; +Cc: Ian.Jackson, ian.campbell, xen-devel

Ping ?

Saturday, October 20, 2012, 1:13:04 AM, you wrote:

> From: Sander Eikelenboom <linux@eikelenboom>

> Introduced by changeset 26091: "xl: Add --wait and --all to xl reboot."

> Signed-off-by: Sander Eikelenboom <linux@eikelenboom>
> ---
>  tools/libxl/xl_cmdimpl.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)

> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> index dc80595..0e65f2b 100644
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -3774,7 +3774,9 @@ static int main_shutdown_or_reboot(int reboot, int argc, char **argv)
>                 fallback_trigger);
>          }
>  
> -        wait_for_domain_deaths(deathws, nb_domain - 1 /* not dom 0 */);
> +        if (wait_for_it)
> +            wait_for_domain_deaths(deathws, nb_domain - 1 /* not dom 0 */);
> +
>          libxl_dominfo_list_free(dominfo, nb_domain);
>      } else {
>          libxl_evgen_domain_death *deathw = NULL;

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] xl: Fix accidently waiting for domains to shutdown without --wait option
  2012-10-19 23:13 ` [PATCH 1/1] " linux
  2012-10-25 13:47   ` Sander Eikelenboom
@ 2012-10-25 15:05   ` Ian Jackson
  1 sibling, 0 replies; 4+ messages in thread
From: Ian Jackson @ 2012-10-25 15:05 UTC (permalink / raw)
  To: linux; +Cc: Ian.Jackson, ian.campbell, xen-devel

linux@eikelenboom.it writes ("[Xen-devel] [PATCH 1/1] xl: Fix accidently waiting for domains to shutdown without --wait option"):
> From: Sander Eikelenboom <linux@eikelenboom>
> 
> Introduced by changeset 26091: "xl: Add --wait and --all to xl reboot."
> 
> Signed-off-by: Sander Eikelenboom <linux@eikelenboom>

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-10-25 15:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-19 23:13 xl: Fix accidently waiting for domains to shutdown without --wait option linux
2012-10-19 23:13 ` [PATCH 1/1] " linux
2012-10-25 13:47   ` Sander Eikelenboom
2012-10-25 15:05   ` Ian Jackson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).