From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: xen-devel@lists.xensource.com
Cc: tim@xen.org, Ian.Campbell@citrix.com,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: [PATCH 1/7] xen/arm: fix rank calculation in vgic_vcpu_inject_irq
Date: Wed, 24 Oct 2012 16:03:41 +0100 [thread overview]
Message-ID: <1351091027-20740-1-git-send-email-stefano.stabellini@eu.citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1210241455080.2689@kaball.uk.xensource.com>
Each rank holds 32 irqs, so we should divide by 32 rather than by 4.
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
---
xen/arch/arm/vgic.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c
index 3c3983f..5eae61c 100644
--- a/xen/arch/arm/vgic.c
+++ b/xen/arch/arm/vgic.c
@@ -577,7 +577,7 @@ struct pending_irq *irq_to_pending(struct vcpu *v, unsigned int irq)
void vgic_vcpu_inject_irq(struct vcpu *v, unsigned int irq, int virtual)
{
- int idx = irq >> 2, byte = irq & 0x3;
+ int idx = irq / 32, byte = irq & 0x3;
uint8_t priority;
struct vgic_irq_rank *rank = vgic_irq_rank(v, 8, idx);
struct pending_irq *iter, *n = irq_to_pending(v, irq);
--
1.7.2.5
next prev parent reply other threads:[~2012-10-24 15:03 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 15:03 [PATCH 0/7] xen/arm: run on real hardware Stefano Stabellini
2012-10-24 15:03 ` Stefano Stabellini [this message]
2012-10-25 9:27 ` [PATCH 1/7] xen/arm: fix rank calculation in vgic_vcpu_inject_irq Ian Campbell
2012-10-26 16:33 ` Stefano Stabellini
2012-10-26 16:40 ` Ian Campbell
2012-10-26 18:42 ` Stefano Stabellini
2012-10-26 20:47 ` Ian Campbell
2012-10-27 10:09 ` Tim Deegan
2012-10-27 10:44 ` Ian Campbell
2012-11-13 11:57 ` Stefano Stabellini
2012-11-13 12:00 ` Ian Campbell
2012-11-13 12:23 ` Stefano Stabellini
2012-10-24 15:03 ` [PATCH 2/7] xen/arm: setup the fixmap in head.S Stefano Stabellini
2012-10-24 15:27 ` Tim Deegan
2012-10-24 15:37 ` Stefano Stabellini
2012-10-25 9:33 ` Ian Campbell
2012-10-25 11:00 ` Stefano Stabellini
2012-10-24 15:03 ` [PATCH 3/7] pl011: set baud and clock_hz to the right defaults for Versatile Express Stefano Stabellini
2012-10-25 9:37 ` Ian Campbell
2012-10-25 10:57 ` Stefano Stabellini
2012-10-25 11:00 ` Ian Campbell
2012-10-24 15:03 ` [PATCH 4/7] xen/arm: set the SMP bit in the ACTLR register Stefano Stabellini
2012-10-25 9:52 ` Ian Campbell
2012-10-25 11:57 ` Stefano Stabellini
2012-10-25 12:04 ` Ian Campbell
2012-10-26 8:56 ` Tim Deegan
2012-10-26 8:59 ` Ian Campbell
2012-10-24 15:03 ` [PATCH 5/7] xen/arm: wake up secondary cpus Stefano Stabellini
2012-10-24 15:38 ` Tim Deegan
2012-10-24 15:59 ` Stefano Stabellini
2012-10-24 16:05 ` Tim Deegan
2012-10-25 9:59 ` Ian Campbell
2012-10-25 17:45 ` Stefano Stabellini
2012-10-26 7:30 ` Ian Campbell
2012-10-26 11:18 ` Stefano Stabellini
2012-10-26 12:16 ` Ian Campbell
2012-10-26 15:24 ` Stefano Stabellini
2012-10-26 15:32 ` Ian Campbell
2012-10-24 15:03 ` [PATCH 6/7] xen/arm: flush D-cache and I-cache when appropriate Stefano Stabellini
2012-10-24 15:59 ` Tim Deegan
2012-10-24 16:05 ` Ian Campbell
2012-10-24 16:17 ` Tim Deegan
2012-10-24 17:35 ` Stefano Stabellini
2012-10-26 9:01 ` Tim Deegan
2012-10-26 15:53 ` Stefano Stabellini
2012-10-26 15:55 ` Stefano Stabellini
2012-10-26 16:03 ` Stefano Stabellini
2012-10-26 16:55 ` Tim Deegan
2012-10-26 18:40 ` Stefano Stabellini
2012-10-27 10:44 ` Tim Deegan
2012-10-27 11:54 ` Tim Deegan
2012-10-29 9:53 ` Stefano Stabellini
2012-10-29 9:52 ` Stefano Stabellini
2012-11-13 12:01 ` Stefano Stabellini
2012-11-13 12:15 ` Tim Deegan
2012-10-26 16:45 ` Tim Deegan
2012-10-24 15:03 ` [PATCH 7/7] xen/arm: get the number of cpus from device tree Stefano Stabellini
2012-10-25 10:02 ` Ian Campbell
2012-10-24 16:02 ` [PATCH 0/7] xen/arm: run on real hardware Tim Deegan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351091027-20740-1-git-send-email-stefano.stabellini@eu.citrix.com \
--to=stefano.stabellini@eu.citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).