From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH 14 of 16 RFC] blktap3: Provide Makefile for
 compiling the blktap3 control library
Date: Tue, 30 Oct 2012 12:22:29 +0100
Message-ID: <1351596149.16017.6.camel@hastur.hellion.org.uk>
References: <patchbomb.1351098139@makatos-desktop>
	<9f5d1f1f979114cf41fc.1351098153@makatos-desktop>
	<1351251638.15162.56.camel@zakaz.uk.xensource.com>
	<4B45B535F7F6BE4CB1C044ED5115CDDE012D54AB8CED@LONPMAILBOX01.citrite.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <4B45B535F7F6BE4CB1C044ED5115CDDE012D54AB8CED@LONPMAILBOX01.citrite.net>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Thanos Makatos <thanos.makatos@citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On Tue, 2012-10-30 at 11:11 +0000, Thanos Makatos wrote:
> > > +
> > > +# TODO install in /usr/sbin?
> > > +install: $(LIB_STATIC) $(LIB_SHARED)
> > > +	$(INSTALL_DIR) -p $(DESTDIR)$(SBINDIR)
> > 
> > Was this intended to be LIBDIR? At least until the TODO is resolved.
> 
> I'm confused, Which one?

The use of SBINDIR here, was it supposed to be a LIBDIR? Because the
following lines all install to LIBDIR not SBINDIR.

> > > +	$(INSTALL_PROG) $(LIB_SHARED) $(DESTDIR)$(LIBDIR)
> > > +	ln -sf $(LIBSONAME) $(DESTDIR)$(LIBDIR)/$(LIBNAME).so
> > > +	ln -sf $(LIB_SHARED) $(DESTDIR)$(LIBDIR)/$(LIBSONAME)