From: Ian Campbell <ian.campbell@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [Xen-devel] [PATCH 1/2] xen/generic: Disable fallback build on ARM.
Date: Wed, 7 Nov 2012 08:19:54 +0100 [thread overview]
Message-ID: <1352272794.12977.17.camel@hastur.hellion.org.uk> (raw)
In-Reply-To: <1352239982-17389-2-git-send-email-konrad.wilk@oracle.com>
On Tue, 2012-11-06 at 22:13 +0000, Konrad Rzeszutek Wilk wrote:
> As there is no need for it (the fallback code is for older
> hypervisors and they won't run under ARM),
I think more specifically they won't run on anything other than x86.
[...]
> diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile
> index 46de6cd..273d2b9 100644
> --- a/drivers/xen/Makefile
> +++ b/drivers/xen/Makefile
> @@ -1,8 +1,8 @@
> ifneq ($(CONFIG_ARM),y)
> -obj-y += manage.o balloon.o
> +obj-y += manage.o balloon.o fallback.o
> obj-$(CONFIG_HOTPLUG_CPU) += cpu_hotplug.o
> endif
I think :
obj-$(CONFIG_X86) += fallback.o
would better reflect what is going on here.
next prev parent reply other threads:[~2012-11-07 7:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-06 22:13 [PATCH] Fix various compile errors/warnings on ARM with CONFIG_XEN_*=m Konrad Rzeszutek Wilk
2012-11-06 22:13 ` [PATCH 1/2] xen/generic: Disable fallback build on ARM Konrad Rzeszutek Wilk
2012-11-07 7:19 ` Ian Campbell [this message]
2012-11-07 8:38 ` [Xen-devel] " Jan Beulich
2012-11-07 15:47 ` Konrad Rzeszutek Wilk
2012-11-06 22:13 ` [PATCH 2/2] xen/arm: Fix compile errors when drivers are compiled as modules Konrad Rzeszutek Wilk
2012-11-07 7:21 ` [Xen-devel] " Ian Campbell
2012-11-07 10:25 ` Stefano Stabellini
2012-11-07 10:57 ` [Xen-devel] " Ian Campbell
2012-11-07 13:01 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352272794.12977.17.camel@hastur.hellion.org.uk \
--to=ian.campbell@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).