Re: [PATCH 2 of 3 v2] libxl, xl: user can ask for min and max nodes to use during placement

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 981 bytes --]

On Mon, 2012-11-12 at 16:26 +0000, Ian Campbell wrote:
> On Fri, 2012-10-19 at 15:34 +0100, Dario Faggioli wrote:
> > @@ -219,6 +219,11 @@ int libxl__domain_build_info_setdefault(
> >  
> >      libxl_defbool_setdefault(&b_info->numa_placement, true);
> >  
> > +    if (!b_info->min_nodes)
> > +        b_info->min_nodes = 0;
> > +    if (!b_info->max_nodes)
> > +        b_info->max_nodes = 0; 
> 
> Aren't both of these if statements tautologous?
> 
Looks like they are. I'll double check this before reposting.

I think what I wanted to do was making sure to zero those new fields, if
not otherwise initialized by someone else... and, of course, I got that
wrong! :-P


Thanks,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel