From: Ian Campbell <Ian.Campbell@citrix.com>
To: Matthew Fioravante <matthew.fioravante@jhuapl.edu>
Cc: "samuel.thibault@ens-lyon.org" <samuel.thibault@ens-lyon.org>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH VTPM 3/9] add tpmfront, tpm_tis, and tpmback drivers to mini-os
Date: Tue, 13 Nov 2012 10:48:32 +0000 [thread overview]
Message-ID: <1352803712.7491.45.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <1351802007-19178-3-git-send-email-matthew.fioravante@jhuapl.edu>
On Thu, 2012-11-01 at 20:33 +0000, Matthew Fioravante wrote:
> This patch adds 3 new drivers to mini-os.
>
> tpmfront - paravirtualized tpm frontend driver
> tpmback - paravirtualized tpm backend driver
> tpm_tis - hardware tpm driver
>
> Unfortunately these drivers were derived from GPL
> licensed linux kernel drivers so they must carry
> the GPL license. However, since mini-os now
> supports conditional compilation, hopefully these
> drivers can be included into the xen tree and
> conditionally removed from non-gpl projects.
> By default they are disabled in the makefile.
I think this is OK but please could you send a followup patch to
extras/mini-os/COPYING which clarifies the situation. Something like
"... Certain files in this directory are licensed under the GPLv2. By
default these are not built and linked into MiniOS however enabling them
will cause the whole work to become covered by the GPL.". Or something
like that (Ian Jackson -- perhaps you have an opinion on the wording?)
Anyway, for this patch:
Acked-by: Ian Campbell <ian.campbell@citrix.com>
And applied.
next prev parent reply other threads:[~2012-11-13 10:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 20:33 [PATCH VTPM 1/9] Disable -DGNT_DEBUG and -DGNTMAP_DEBUG Matthew Fioravante
2012-11-01 20:33 ` [PATCH VTPM 2/9] add xenbus_read_uuid to mini-os Matthew Fioravante
2012-11-01 21:32 ` Samuel Thibault
2012-11-13 10:47 ` Ian Campbell
2012-11-01 20:33 ` [PATCH VTPM 3/9] add tpmfront, tpm_tis, and tpmback drivers " Matthew Fioravante
2012-11-13 10:48 ` Ian Campbell [this message]
2012-11-01 20:33 ` [PATCH VTPM 4/9] fix bug in lseek for mini-os Matthew Fioravante
2012-11-01 21:34 ` Samuel Thibault
2012-11-02 13:22 ` Fioravante, Matthew E.
2012-11-01 21:29 ` [PATCH VTPM 1/9] Disable -DGNT_DEBUG and -DGNTMAP_DEBUG Samuel Thibault
2012-11-02 13:19 ` Fioravante, Matthew E.
2012-11-05 23:34 ` Samuel Thibault
2012-11-06 14:59 ` Matthew Fioravante
2012-11-06 15:13 ` Samuel Thibault
2012-11-06 15:13 ` Samuel Thibault
2012-11-13 10:47 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352803712.7491.45.camel@zakaz.uk.xensource.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=matthew.fioravante@jhuapl.edu \
--cc=samuel.thibault@ens-lyon.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).