From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH VTPM 3/9] add tpmfront, tpm_tis, and tpmback drivers to mini-os Date: Tue, 13 Nov 2012 10:48:32 +0000 Message-ID: <1352803712.7491.45.camel@zakaz.uk.xensource.com> References: <1351802007-19178-1-git-send-email-matthew.fioravante@jhuapl.edu> <1351802007-19178-3-git-send-email-matthew.fioravante@jhuapl.edu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1351802007-19178-3-git-send-email-matthew.fioravante@jhuapl.edu> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Matthew Fioravante Cc: "samuel.thibault@ens-lyon.org" , Ian Jackson , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Thu, 2012-11-01 at 20:33 +0000, Matthew Fioravante wrote: > This patch adds 3 new drivers to mini-os. > > tpmfront - paravirtualized tpm frontend driver > tpmback - paravirtualized tpm backend driver > tpm_tis - hardware tpm driver > > Unfortunately these drivers were derived from GPL > licensed linux kernel drivers so they must carry > the GPL license. However, since mini-os now > supports conditional compilation, hopefully these > drivers can be included into the xen tree and > conditionally removed from non-gpl projects. > By default they are disabled in the makefile. I think this is OK but please could you send a followup patch to extras/mini-os/COPYING which clarifies the situation. Something like "... Certain files in this directory are licensed under the GPLv2. By default these are not built and linked into MiniOS however enabling them will cause the whole work to become covered by the GPL.". Or something like that (Ian Jackson -- perhaps you have an opinion on the wording?) Anyway, for this patch: Acked-by: Ian Campbell And applied.