From: Ian Campbell <Ian.Campbell@citrix.com>
To: Ronny Hegewald <ronny.hegewald@online.de>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH V2] fix vfb related assertion problem when starting pv-domU
Date: Tue, 13 Nov 2012 11:19:22 +0000 [thread overview]
Message-ID: <1352805562.7491.59.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <201211030255.37630.ronny.hegewald@online.de>
On Sat, 2012-11-03 at 02:55 +0000, Ronny Hegewald wrote:
> >
> > Signed-off-by: Ronny Hegewald@online.de
> >
>
> Somehow the sign off gone wrong. it was supposed to be
>
> Signed-off-by: Ronny Hegewald <Ronny.Hegewald@online.de>
Acked-by: Ian Campbell <ian.campbell@citrix.com> and applied, thanks.
For future reference can you generate patches so they apply with "patch
-p1", the tooling copes much better with those sorts of patches.
e.g.:
--- tools/libxl/libxl.c.org
+++ tools/libxl/libxl.c
should look like:
--- a/tools/libxl/libxl.c
+++ b/tools/libxl/libxl.c
or:
--- xen.orig/tools/libxl/libxl.c
+++ xen/tools/libxl/libxl.c
or:
--- xen/tools/libxl/libxl.c.orig
+++ xen/tools/libxl/libxl.c
etc.
Tools like git format-patch + send-email or hg export / hg email (the
last described in http://wiki.xen.org/wiki/Submitting_Xen_Patches) do
this automatically I think.
Thanks,
Ian.
next prev parent reply other threads:[~2012-11-13 11:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 2:18 [PATCH] fix vfb related assertion problem when starting pv-domU Ronny Hegewald
2012-11-01 8:02 ` Ian Campbell
2012-11-02 21:01 ` [PATCH V2] " Ronny Hegewald
2012-11-03 2:55 ` Ronny Hegewald
2012-11-13 11:19 ` Ian Campbell [this message]
2012-11-21 23:50 ` Ronny Hegewald
2012-11-22 7:54 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352805562.7491.59.camel@zakaz.uk.xensource.com \
--to=ian.campbell@citrix.com \
--cc=ronny.hegewald@online.de \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).