From: Ian Campbell <Ian.Campbell@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [xen-unstable test] 14421: regressions - FAIL
Date: Mon, 19 Nov 2012 19:57:24 +0000 [thread overview]
Message-ID: <1353355044.26243.29.camel@dagon.hellion.org.uk> (raw)
In-Reply-To: <50AA88E7.4030402@citrix.com>
On Mon, 2012-11-19 at 19:30 +0000, Andrew Cooper wrote:
> On 19/11/12 19:24, xen.org wrote:
> > flight 14421 xen-unstable real [real]
> > http://www.chiark.greenend.org.uk/~xensrcts/logs/14421/
> >
> > Regressions :-(
>
> Build failure caused by the first hunk of
> http://xenbits.xen.org/hg/staging/xen-unstable.hg/rev/26facad2f1a1 which
> introduced one open-comment and two close-comments.
So it does, I have pushed the fix below.
I must have somehow overlooked that my usual pre-commit test (which
includes a clean build) didn't actually run to completion. Sorry about
this.
Ian.
>From 602b24f9d77cd269a4f419a49d6e2f88d9f3d68e Mon Sep 17 00:00:00 2001
From: Ian Campbell <ian.campbell@citrix.com>
Date: Mon, 19 Nov 2012 19:53:22 +0000
Subject: [PATCH] xen: fix build failure due to extra closing comment
Added by 26173:26facad2f1a1
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
xen/include/public/xen.h | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/xen/include/public/xen.h b/xen/include/public/xen.h
index bff9542..5593066 100644
--- a/xen/include/public/xen.h
+++ b/xen/include/public/xen.h
@@ -445,7 +445,6 @@ DEFINE_XEN_GUEST_HANDLE(mmuext_op_t);
* ` @val: The new page table entry, must contain a machine address
* ` @flags: Control TLB flushes
*/
-*/
/* These are passed as 'flags' to update_va_mapping. They can be ORed. */
/* When specifying UVMF_MULTI, also OR in a pointer to a CPU bitmap. */
/* UVMF_LOCAL is merely UVMF_MULTI with a NULL bitmap pointer. */
--
1.7.2.5
>
>
> >
> > Tests which did not succeed and are blocking,
> > including tests which could not be run:
> > build-i386 4 xen-build fail REGR. vs. 14416
> > build-i386-oldkern 4 xen-build fail REGR. vs. 14416
> > build-amd64 4 xen-build fail REGR. vs. 14416
> > build-amd64-oldkern 4 xen-build fail REGR. vs. 14416
> >
> > Tests which did not succeed, but are not blocking:
> > test-amd64-amd64-xl-sedf-pin 1 xen-build-check(1) blocked n/a
> > test-amd64-amd64-xl-pcipt-intel 1 xen-build-check(1) blocked n/a
> > test-amd64-amd64-xl-sedf 1 xen-build-check(1) blocked n/a
> > test-amd64-amd64-pv 1 xen-build-check(1) blocked n/a
> > test-amd64-i386-xl-credit2 1 xen-build-check(1) blocked n/a
> > test-amd64-i386-xl 1 xen-build-check(1) blocked n/a
> > test-amd64-i386-qemuu-rhel6hvm-intel 1 xen-build-check(1) blocked n/a
> > test-amd64-amd64-xl 1 xen-build-check(1) blocked n/a
> > test-amd64-i386-xl-multivcpu 1 xen-build-check(1) blocked n/a
> > test-amd64-i386-rhel6hvm-amd 1 xen-build-check(1) blocked n/a
> > test-amd64-amd64-xl-qemuu-winxpsp3 1 xen-build-check(1) blocked n/a
> > test-amd64-i386-qemuu-rhel6hvm-amd 1 xen-build-check(1) blocked n/a
> > test-amd64-i386-xend-winxpsp3 1 xen-build-check(1) blocked n/a
> > test-amd64-i386-win 1 xen-build-check(1) blocked n/a
> > test-amd64-i386-xl-win-vcpus1 1 xen-build-check(1) blocked n/a
> > test-amd64-i386-pv 1 xen-build-check(1) blocked n/a
> > test-amd64-amd64-xl-win7-amd64 1 xen-build-check(1) blocked n/a
> > test-amd64-i386-win-vcpus1 1 xen-build-check(1) blocked n/a
> > test-amd64-i386-rhel6hvm-intel 1 xen-build-check(1) blocked n/a
> > test-amd64-i386-xl-win7-amd64 1 xen-build-check(1) blocked n/a
> > test-amd64-amd64-xl-winxpsp3 1 xen-build-check(1) blocked n/a
> > test-amd64-i386-pair 1 xen-build-check(1) blocked n/a
> > test-amd64-i386-xl-winxpsp3-vcpus1 1 xen-build-check(1) blocked n/a
> > test-amd64-amd64-pair 1 xen-build-check(1) blocked n/a
> > test-amd64-amd64-xl-win 1 xen-build-check(1) blocked n/a
> > test-amd64-amd64-xl-qemuu-win7-amd64 1 xen-build-check(1) blocked n/a
> > test-amd64-amd64-win 1 xen-build-check(1) blocked n/a
> >
> > version targeted for testing:
> > xen fe8034159ac2
> > baseline version:
> > xen 321f8487379b
> >
> > ------------------------------------------------------------
> > People who touched revisions under test:
> > Ian Campbell <ian.campbell@citrix.com>
> > Ian Jackson <ian.jackson@eu.citrix.com>
> > Jan Beulich <jbeulich@suse.com>
> > Keir Fraser <keir@xen.org>
> > Matthew Fioravante <matthew.fioravante@jhuapl.edu>
> > Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> > Wei Wang <wei.wang2@amd.com>
> > ------------------------------------------------------------
> >
> > jobs:
> > build-amd64 fail
> > build-i386 fail
> > build-amd64-oldkern fail
> > build-i386-oldkern fail
> > build-amd64-pvops pass
> > build-i386-pvops pass
> > test-amd64-amd64-xl blocked
> > test-amd64-i386-xl blocked
> > test-amd64-i386-rhel6hvm-amd blocked
> > test-amd64-i386-qemuu-rhel6hvm-amd blocked
> > test-amd64-amd64-xl-qemuu-win7-amd64 blocked
> > test-amd64-amd64-xl-win7-amd64 blocked
> > test-amd64-i386-xl-win7-amd64 blocked
> > test-amd64-i386-xl-credit2 blocked
> > test-amd64-amd64-xl-pcipt-intel blocked
> > test-amd64-i386-rhel6hvm-intel blocked
> > test-amd64-i386-qemuu-rhel6hvm-intel blocked
> > test-amd64-i386-xl-multivcpu blocked
> > test-amd64-amd64-pair blocked
> > test-amd64-i386-pair blocked
> > test-amd64-amd64-xl-sedf-pin blocked
> > test-amd64-amd64-pv blocked
> > test-amd64-i386-pv blocked
> > test-amd64-amd64-xl-sedf blocked
> > test-amd64-i386-win-vcpus1 blocked
> > test-amd64-i386-xl-win-vcpus1 blocked
> > test-amd64-i386-xl-winxpsp3-vcpus1 blocked
> > test-amd64-amd64-win blocked
> > test-amd64-i386-win blocked
> > test-amd64-amd64-xl-win blocked
> > test-amd64-amd64-xl-qemuu-winxpsp3 blocked
> > test-amd64-i386-xend-winxpsp3 blocked
> > test-amd64-amd64-xl-winxpsp3 blocked
> >
> >
> > ------------------------------------------------------------
> > sg-report-flight on woking.cam.xci-test.com
> > logs: /home/xc_osstest/logs
> > images: /home/xc_osstest/images
> >
> > Logs, config files, etc. are available at
> > http://www.chiark.greenend.org.uk/~xensrcts/logs
> >
> > Test harness code can be found at
> > http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary
> >
> >
> > Not pushing.
> >
> > ------------------------------------------------------------
> > changeset: 26177:fe8034159ac2
> > tag: tip
> > user: Ian Campbell <ian.campbell@citrix.com>
> > date: Mon Nov 19 14:25:35 2012 +0000
> >
> > docs: Include prototype for HYPERVISOR_multicall
> >
> > Mark-up for inclusion of generated docs.
> >
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> > Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
> > Committed-by: Ian Campbell <ian.campbell@citrix.com>
> >
> >
> > changeset: 26176:edad24bfa561
> > user: Ian Campbell <ian.campbell@citrix.com>
> > date: Mon Nov 19 14:25:34 2012 +0000
> >
> > docs: Document HYPERVISOR_update_descriptor
> >
> > Mark-up for inclusion of generated docs.
> >
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> > Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
> > Committed-by: Ian Campbell <ian.campbell@citrix.com>
> >
> >
> > changeset: 26175:b1d36147ac96
> > user: Ian Campbell <ian.campbell@citrix.com>
> > date: Mon Nov 19 14:25:33 2012 +0000
> >
> > docs: Add ToC entry for start of day memory layout.
> >
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> > Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
> > Committed-by: Ian Campbell <ian.campbell@citrix.com>
> >
> >
> > changeset: 26174:dbb8d24bb5ad
> > user: Ian Campbell <ian.campbell@citrix.com>
> > date: Mon Nov 19 14:25:33 2012 +0000
> >
> > docs: Document HYPERVISOR_mmuext_op
> >
> > Mark-up for inclusion of generated docs.
> >
> > Remove some trailing whitespace.
> >
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> > Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
> > Committed-by: Ian Campbell <ian.campbell@citrix.com>
> >
> >
> > changeset: 26173:26facad2f1a1
> > user: Ian Campbell <ian.campbell@citrix.com>
> > date: Mon Nov 19 14:25:32 2012 +0000
> >
> > docs: document HYPERVISOR_update_va_mapping(_other_domain)
> >
> > Mark-up for inclusion of generated docs.
> >
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> > Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
> > Committed-by: Ian Campbell <ian.campbell@citrix.com>
> >
> >
> > changeset: 26172:cfd2772cc717
> > user: Ian Campbell <ian.campbell@citrix.com>
> > date: Mon Nov 19 14:25:31 2012 +0000
> >
> > docs: document/mark-up SCHEDOP_*
> >
> > The biggest subtlety here is there additional argument when op ==
> > SCHEDOP_shutdown and reason == SHUTDOWN_suspend and its interpretation by
> > xc_domain_{save,restore}. Add some clarifying comments to libxc as well.
> >
> > This patch moves some structs around but there is no functional change
> > other than improved documentation.
> >
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> > Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
> > Committed-by: Ian Campbell <ian.campbell@citrix.com>
> >
> >
> > changeset: 26171:31668da0c4d3
> > user: Jan Beulich <jbeulich@suse.com>
> > date: Mon Nov 19 15:15:12 2012 +0100
> >
> > AMD IOMMU: fix type of "bdf" parameter of update_intremap_entry_from_msi_msg()
> >
> > Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
> >
> >
> > changeset: 26170:380ad94f2adc
> > user: Matthew Fioravante <matthew.fioravante@jhuapl.edu>
> > date: Mon Nov 19 12:59:51 2012 +0000
> >
> > Remove tools/vtpm* from MAINTAINERS file
> >
> > Signed-off-by: Matthew Fioravante <matthew.fioravante@jhuapl.edu>
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> > Committed-by: Ian Campbell <ian.campbell@citrix.com>
> >
> >
> > changeset: 26169:5a6225e40388
> > user: Matthew Fioravante <matthew.fioravante@jhuapl.edu>
> > date: Mon Nov 19 12:59:50 2012 +0000
> >
> > tools: Remove old vtpm stuff from tools/libxen
> >
> > Signed-off-by: Matthew Fioravante <matthew.fioravante@jhuapl.edu>
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> > Committed-by: Ian Campbell <ian.campbell@citrix.com>
> >
> >
> > changeset: 26168:3dc18d679d04
> > user: Matthew Fioravante <matthew.fioravante@jhuapl.edu>
> > date: Mon Nov 19 12:59:49 2012 +0000
> >
> > Remove VTPM_TOOLS from config/Tools.mk.in
> >
> > Signed-off-by: Matthew Fioravante <matthew.fioravante@jhuapl.edu>
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> > Committed-by: Ian Campbell <ian.campbell@citrix.com>
> >
> >
> > changeset: 26167:31dcc0e08754
> > user: Matthew Fioravante <matthew.fioravante@jhuapl.edu>
> > date: Mon Nov 19 12:59:48 2012 +0000
> >
> > xend: Remove old vtpm support from xm
> >
> > Signed-off-by: Matthew Fioravante <matthew.fioravante@jhuapl.edu>
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> > Committed-by: Ian Campbell <ian.campbell@citrix.com>
> >
> >
> > changeset: 26166:d026f8abca51
> > user: Matthew Fioravante <matthew.fioravante@jhuapl.edu>
> > date: Mon Nov 19 12:59:48 2012 +0000
> >
> > minios: Update mini-os license to support GPL features
> >
> > This patch updates extras/mini-os/COPYING to explain
> > which optional features are GPL and what the implications
> > of enabling them are.
> >
> > Signed-off-by: Matthew Fioravante <matthew.fioravante@jhuapl.edu>
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> > Committed-by: Ian Campbell <ian.campbell@citrix.com>
> >
> >
> > changeset: 26165:42a7c393c390
> > user: Matthew Fioravante <matthew.fioravante@jhuapl.edu>
> > date: Mon Nov 19 12:59:47 2012 +0000
> >
> > minios: fix bug in lseek for mini-os
> >
> > lseek always used files[fd].file.offset. It should
> > use the offset of whatever union member is actually
> > being used.
> >
> > Signed-off-by: Matthew Fioravante <matthew.fioravante@jhuapl.edu>
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> > Committed-by: Ian Campbell <ian.campbell@citrix.com>
> >
> >
> > changeset: 26164:17539cec2b9d
> > user: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> > date: Mon Nov 19 12:59:46 2012 +0000
> >
> > xen/arm: get the number of cpus from device tree
> >
> > The system might have fewer cpus than the GIC supports.
> >
> > Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> > Committed-by: Ian Campbell <ian.campbell@citrix.com>
> >
> >
> > changeset: 26163:ddb109120dbd
> > user: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> > date: Mon Nov 19 12:59:46 2012 +0000
> >
> > xen/arm: flush D-cache and I-cache when appropriate
> >
> > - invalidate tlb after setting WXN
> > - flush D-cache and I-cache after relocation;
> > - invalidate D-cache after writing to smp_up_cpu;
> > - flush I-cache after changing HTTBR;
> > - flush I-cache and branch predictor after writing Xen text ptes.
> >
> > Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> > Committed-by: Ian Campbell <ian.campbell@citrix.com>
> >
> >
> > changeset: 26162:9da9781cc3fb
> > user: Jan Beulich <jbeulich@suse.com>
> > date: Mon Nov 19 09:48:22 2012 +0100
> >
> > vscsiif: minor cleanup
> >
> > Remove a definition not belonging into the interface, and correct a
> > few typos in comments.
> >
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
> > Acked-by: Keir Fraser <keir@xen.org>
> >
> >
> > changeset: 26161:9025a10c0561
> > user: Wei Wang <wei.wang2@amd.com>
> > date: Mon Nov 19 09:46:46 2012 +0100
> >
> > AMD IOMMU: Enable HPET broadcast msi remapping
> >
> > This patch enables hpet msi remapping for amd iommu.
> >
> > Signed-off-by: Wei Wang <wei.wang2@amd.com>
> >
> > - use the existing ACPI_IVHD_* #define-s
> > - warn on finding more than one IVHD HPET entry
> > - consolidate parameters of update_intremap_entry_from_msi_msg()
> >
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
> > Committed-by: Jan Beulich <jbeulich@suse.com>
> >
> >
> > changeset: 26160:321f8487379b
> > user: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> > date: Thu Nov 15 10:25:29 2012 +0000
> >
> > xen/arm: wake up secondary cpus
> >
> > Secondary cpus are held by the firmware until we send an IPI to them.
> >
> > Reordered non-boot cpu wait loop to perform the check before waiting
> > for an event, to handled the case where the event has already
> > happened when we reach the loop.
> >
> > Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> > Committed-by: Ian Campbell <ian.campbell@citrix.com>
> >
> >
> > (qemu changes not included)
> >
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xen.org
> > http://lists.xen.org/xen-devel
>
> --
> Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
> T: +44 (0)1223 225 900, http://www.citrix.com
>
prev parent reply other threads:[~2012-11-19 19:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 19:24 [xen-unstable test] 14421: regressions - FAIL xen.org
2012-11-19 19:30 ` Andrew Cooper
2012-11-19 19:57 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353355044.26243.29.camel@dagon.hellion.org.uk \
--to=ian.campbell@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).