From: Ian Campbell <ian.campbell@citrix.com>
To: xen-devel@lists.xen.org
Cc: Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH 4/8] device-tree: get_val cannot cope with cells > 2, add early_panic
Date: Mon, 3 Dec 2012 17:10:27 +0000 [thread overview]
Message-ID: <1354554631-17861-4-git-send-email-ian.campbell@citrix.com> (raw)
In-Reply-To: <1354554611.2693.30.camel@zakaz.uk.xensource.com>
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
v3: early_panic instead of BUG_ON
v2: drop unrelated white space fixup
---
xen/common/device_tree.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
index 9eb316f..5a0a1a6 100644
--- a/xen/common/device_tree.c
+++ b/xen/common/device_tree.c
@@ -58,6 +58,9 @@ static void __init get_val(const u32 **cell, u32 cells, u64 *val)
{
*val = 0;
+ if ( cells > 2 )
+ early_panic("dtb value contains > 2 cells\n");
+
while ( cells-- )
{
*val <<= 32;
--
1.7.9.1
next prev parent reply other threads:[~2012-12-03 17:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 17:10 [PATCH 00/08 V2] arm: support for initial modules (e.g. dom0) and DTB supplied in RAM Ian Campbell
2012-12-03 17:10 ` [PATCH 1/8] arm: parse modules from DT during early boot Ian Campbell
2012-12-03 17:10 ` [PATCH 2/8] arm: avoid placing Xen over any modules Ian Campbell
2012-12-03 17:10 ` [PATCH 3/8] arm: avoid allocating the heaps over modules or xen itself Ian Campbell
2012-12-03 17:10 ` Ian Campbell [this message]
2012-12-06 11:56 ` [PATCH 4/8] device-tree: get_val cannot cope with cells > 2, add early_panic Tim Deegan
2012-12-06 12:13 ` David Vrabel
2012-12-06 13:00 ` Ian Campbell
2012-12-03 17:10 ` [PATCH 5/8] arm: load dom0 kernel from first boot module Ian Campbell
2012-12-06 12:03 ` Tim Deegan
2012-12-03 17:10 ` [PATCH 6/8] arm: discard boot modules after building domain 0 Ian Campbell
2012-12-03 17:10 ` [PATCH 7/8] arm: use /chosen/module@1/bootargs for domain 0 command line Ian Campbell
2012-12-03 17:10 ` [PATCH 8/8] xen: strip /chosen/module@<N>/* from dom0 device tree Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354554631-17861-4-git-send-email-ian.campbell@citrix.com \
--to=ian.campbell@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).