From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <raistlin@linux.it>
Subject: Re: [PATCH 2 of 3] xen: tracing: introduce
 per-scheduler trace event IDs
Date: Wed, 05 Dec 2012 12:57:13 +0100
Message-ID: <1354708633.21632.24.camel@Abyss>
References: <patchbomb.1354552497@Solace>
	<7265520b0188740d3dfa.1354552499@Solace>
	<CAFLBxZaor6aBA6AzAGrGhVBCG+UMS+6G_Q0SKQCgw-hmWuDLxA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8352038728249691919=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CAFLBxZaor6aBA6AzAGrGhVBCG+UMS+6G_Q0SKQCgw-hmWuDLxA@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: George Dunlap <George.Dunlap@eu.citrix.com>
Cc: xen-devel <xen-devel@lists.xensource.com>, Keir Fraser <keir@xen.org>, George Dunlap <george.dunlap@citrix.com>
List-Id: xen-devel@lists.xenproject.org


--===============8352038728249691919==
Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature";
	boundary="=-+mjKfYoTFEcOr3UP2GjC"


--=-+mjKfYoTFEcOr3UP2GjC
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 2012-12-04 at 18:53 +0000, George Dunlap wrote:=20
>        =20
>         +/*
>         + * Credit2 tracing events ("only" 512 available!). Check
>         + * include/public/trace.h for more details.
>         + */
>         +#define TRC_CSCHED2_EVENT(_e)        ((TRC_SCHED_CLASS|
>         TRC_MASK_CSCHED2) + _e)=20
>=20
> I think I would make this generic, and put it in trace.h=20
>
Sounds good. Will do.

> -- maybe something like this?  (Haven't run this through a compiler)
>=20
> #define TRC_SCHED_CLASS_EVT(_c, _e) \
>=20
> ((TRC_SCHED_CLASS|(TRC_SCHED_##_c<<TRC_SCHED_MASK_SHIFT))+(_e&TRC_SCHED_C=
LASS_MASK))
>=20
I'll try it and resend.=20
>         +#define TRC_SCHED_ID_BITS    3
>         +#define TRC_SCHED_MASK_SHIFT (TRC_SUBCLS_SHIFT -
>         TRC_SCHED_ID_BITS)
>         +
>         +#define TRC_MASK_CSCHED      (0 << TRC_SCHED_MASK_SHIFT)
>         +#define TRC_MASK_CSCHED2     (1 << TRC_SCHED_MASK_SHIFT)
>         +#define TRC_MASK_SEDF        (2 << TRC_SCHED_MASK_SHIFT)
>         +#define TRC_MASK_ARINC653    (3 << TRC_SCHED_MASK_SHIFT)=20
>=20
> I don't think "mask" is right here -- these aren't masks, they're
> numerical values. :-)  If we use something like the #define above,
> then we can do:
>=20
> #define TRC_SCHED_CSCHED 0
> #define TRC_SCHED_CSCHED2
> /*...*/
>=20
I agree, bad name. (re "mask"). :-)

Thanks and Regards,
Dario=20
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)



--=-+mjKfYoTFEcOr3UP2GjC
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEABECAAYFAlC/NpkACgkQk4XaBE3IOsTxzwCdFIHhcVEV5aXJKySTOHr2HI2W
YjgAmwSAoUxjsmFKN2pFNUKtuLDajCnm
=LoNY
-----END PGP SIGNATURE-----

--=-+mjKfYoTFEcOr3UP2GjC--



--===============8352038728249691919==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============8352038728249691919==--