xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Alex Bligh <alex@alex.org.uk>
To: xen-devel <xen-devel@lists.xen.org>
Cc: Ian Campbell <Ian.Campbell@citrix.com>,
	Alex Bligh <alex@alex.org.uk>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: [PATCH 05/10] libxl_qmp: Introduces helpers to create an argument list.
Date: Thu, 13 Dec 2012 10:57:03 +0000	[thread overview]
Message-ID: <1355396228-3183-6-git-send-email-alex@alex.org.uk> (raw)
In-Reply-To: <1355396228-3183-1-git-send-email-alex@alex.org.uk>

Those functions will be used to create a "list" of parameters that
contain more than just strings. This list is converted by qmp_send to
a string to be sent to QEMU.

Those functions will be used in the next two patches, so right now
there are not compiled.

Backported from xen-unstable patch:
: HG changeset patch
: User Anthony PERARD <anthony.perard@citrix.com>
: Date 1349693132 -3600
: Node ID 6f7847729f0f42614de516d15257ede7243f995f
: Parent  74dee58cfc0d2d6594f388db3b4d2ce91d1bb204
---
 tools/libxl/libxl_qmp.c |   51 +++++++++++++++++++++++++++++++++++++++++++++++
 1 files changed, 51 insertions(+), 0 deletions(-)

diff --git a/tools/libxl/libxl_qmp.c b/tools/libxl/libxl_qmp.c
index 9e86c35..827f1b7 100644
--- a/tools/libxl/libxl_qmp.c
+++ b/tools/libxl/libxl_qmp.c
@@ -624,6 +624,57 @@ static void qmp_free_handler(libxl__qmp_handler *qmp)
     free(qmp);
 }
 
+#if 0
+/*
+ * QMP Parameters Helpers
+ */
+static void qmp_parameters_common_add(libxl__gc *gc,
+                                      libxl__json_object **param,
+                                      const char *name,
+                                      libxl__json_object *obj)
+{
+    libxl__json_map_node *arg = NULL;
+
+    if (!*param) {
+        *param = libxl__json_object_alloc(gc, JSON_MAP);
+    }
+
+    arg = libxl__zalloc(gc, sizeof(*arg));
+
+    arg->map_key = libxl__strdup(gc, name);
+    arg->obj = obj;
+
+    flexarray_append((*param)->u.map, arg);
+}
+
+static void qmp_parameters_add_string(libxl__gc *gc,
+                                      libxl__json_object **param,
+                                      const char *name, const char *argument)
+{
+    libxl__json_object *obj;
+
+    obj = libxl__json_object_alloc(gc, JSON_STRING);
+    obj->u.string = libxl__strdup(gc, argument);
+
+    qmp_parameters_common_add(gc, param, name, obj);
+}
+
+static void qmp_parameters_add_bool(libxl__gc *gc,
+                                    libxl__json_object **param,
+                                    const char *name, bool b)
+{
+    libxl__json_object *obj;
+
+    obj = libxl__json_object_alloc(gc, JSON_BOOL);
+    obj->u.b = b;
+    qmp_parameters_common_add(gc, param, name, obj);
+}
+
+#define QMP_PARAMETERS_SPRINTF(args, name, format, ...) \
+    qmp_parameters_add_string(gc, args, name, \
+                              libxl__sprintf(gc, format, __VA_ARGS__))
+#endif
+
 /*
  * API
  */
-- 
1.7.4.1

  parent reply	other threads:[~2012-12-13 10:57 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-11 11:45 Xen 4.2.1 live migration with qemu device model Alex Bligh
2012-12-11 12:05 ` Alex Bligh
2012-12-11 14:12   ` Ian Campbell
2012-12-12 16:45     ` Ian Jackson
2012-12-13 11:46       ` Ian Campbell
2012-12-11 14:09 ` Ian Campbell
2012-12-11 15:07   ` Alex Bligh
2012-12-11 15:11     ` Ian Campbell
2012-12-11 15:26       ` Stefano Stabellini
2012-12-11 19:14         ` Alex Bligh
2012-12-11 19:24           ` Stefano Stabellini
2012-12-11 19:51             ` Alex Bligh
2012-12-12 13:04               ` QEMU qcow2 snapshotting (was Xen 4.2.1 live migration with qemu device model) Stefano Stabellini
2012-12-12 15:22                 ` Alex Bligh
2012-12-13 10:56       ` [RFC] Enabling live-migrate on HVM on qemu-xen device model Alex Bligh
2012-12-13 10:56         ` [PATCH 01/10] libxl_json: Export json_object related function Alex Bligh
2012-12-13 10:57         ` [PATCH 02/10] libxl_json: Remove JSON_ERROR from enum Alex Bligh
2012-12-13 10:57         ` [PATCH 03/10] libxl_json: Replace JSON_TRUE/FALSE by JSON_BOOL Alex Bligh
2012-12-13 10:57         ` [PATCH 04/10] libxl_json: Introduce libxl__json_object_to_yajl_gen Alex Bligh
2012-12-13 10:57         ` Alex Bligh [this message]
2012-12-13 10:57         ` [PATCH 06/10] libxl_qmp: Use qmp_parameters_* functions for param list of a QMP command Alex Bligh
2012-12-13 10:57         ` [PATCH 07/10] libxl_qmp: Simplify run of single QMP commands Alex Bligh
2012-12-13 10:57         ` [PATCH 08/10] libxl_qmp: Introduce libxl__qmp_set_global_dirty_log Alex Bligh
2012-12-13 10:57         ` [PATCH 09/10] libxl_dom: Call the right switch logdirty for the right DM Alex Bligh
2012-12-13 10:57         ` [PATCH 10/10] libxl: Allow migration with qemu-xen Alex Bligh
2012-12-13 11:03         ` [RFC] Enabling live-migrate on HVM on qemu-xen device model Alex Bligh
2012-12-13 11:38         ` Ian Campbell
2012-12-13 15:06           ` Alex Bligh
2012-12-13 15:09             ` Ian Jackson
2012-12-17 12:01             ` Ian Campbell
2012-12-17 17:02               ` Alex Bligh
2012-12-18 10:04                 ` Ian Campbell
2012-12-18 11:04                   ` George Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1355396228-3183-6-git-send-email-alex@alex.org.uk \
    --to=alex@alex.org.uk \
    --cc=Ian.Campbell@citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).