From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH 1 of 6 v2] xen: sched_credit: improve
 picking up the idlal CPU for a VCPU
Date: Mon, 17 Dec 2012 15:36:45 +0100
Message-ID: <1355755005.5931.9.camel@Abyss>
References: <patchbomb.1355280770@Solace>
	<bced65aa4410b0272064.1355280771@Solace>
	<50C864D402000078000AFDB0@nat28.tlf.novell.com>
	<50CB8318.6050807@eu.citrix.com>
	<50CEE75302000078000B0A99@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0308455572695979880=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <50CEE75302000078000B0A99@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>, "Keir(Xen.org)" <keir@xen.org>, Ian Campbell <Ian.Campbell@citrix.com>, xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

--===============0308455572695979880==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-XrI9AYGWM0H0rwTrW3Id"

--=-XrI9AYGWM0H0rwTrW3Id
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 2012-12-17 at 08:35 +0000, Jan Beulich wrote:=20
> >>> On 14.12.12 at 20:50, George Dunlap <george.dunlap@eu.citrix.com> wro=
te:
> > On 12/12/12 10:04, Jan Beulich wrote:
> >> This, imo, really belings into sched-if.h.
> >=20
> > Hmm, it looks like there are a number of things that could live in=20
> > either sched-if.h or sched.h; but I think this one probably most closel=
y=20
> > links with thins like vcpu_is_runnable() and cpu_is_haltable(), both of=
=20
> > which are in sched.h; so sched.h is where I'd put it.
>=20
> Any use of schedule_data, the type of which is declared in
> sched-if.h, should be in sched-if.h - someone only including
> sched.h can't make use of it anyway (and it's intended to be
> used by scheduler code, i.e. shouldn't be visible to other
> code).
>=20
Ok, this argument, I find quite convincing, I think I'm putting the
macro in sched-if.h

Thanks and Regards,
Dario

--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)



--=-XrI9AYGWM0H0rwTrW3Id
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEABECAAYFAlDPLf0ACgkQk4XaBE3IOsRQLACgopSWEMV9kH2pvkQCvvYodsbM
h9gAnA2OVkujsfCE6oK+kiUly0BQGNZ4
=WbI4
-----END PGP SIGNATURE-----

--=-XrI9AYGWM0H0rwTrW3Id--


--===============0308455572695979880==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============0308455572695979880==--