From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 3 of 6 v2] xen: sched_credit: use current_on_cpu() when appropriate Date: Mon, 17 Dec 2012 15:41:53 +0100 Message-ID: <1355755313.5931.14.camel@Abyss> References: <21b142498d4699921251.1355280773@Solace> <50CB8068.7080404@eu.citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1236313346011643017==" Return-path: In-Reply-To: <50CB8068.7080404@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: George Dunlap Cc: "xen-devel@lists.xensource.com" , "Keir (Xen.org)" , Ian Campbell List-Id: xen-devel@lists.xenproject.org --===============1236313346011643017== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-8xpWPeeNuFXolBvxj/MB" --=-8xpWPeeNuFXolBvxj/MB Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2012-12-14 at 19:39 +0000, George Dunlap wrote:=20 > Hmm, I hadn't read this patch when I commented about removing the macro= =20 > from the first patch. :-) >=20 :-) > I personally think that using vc->processor is better in that patch=20 > anyway; but using this macro elsewhere is probably fine. >=20 Ok. > I think from a taste point of view, I would have put this patch, with=20 > the new definition, as the first patch in the series, and the had the=20 > second patch just use it. >=20 Ok then, when respinning I'll have the first patch defining and using the macro. Then I'll have the 'fix picking' patch using vc->processor _instead_ the macro. Yes, that kills the need for the macro, but since I already have the code for it, and I think things with it does look a bit better, I won't actually kill it. Let me know (here or replying to the corresponding e-mail in the reposting) if you don't want it. Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-8xpWPeeNuFXolBvxj/MB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEABECAAYFAlDPLzEACgkQk4XaBE3IOsSnLQCgn/GEzEAPTAm5PuGVyocnQks6 TYgAnjGZw3u2fYueAykIW5XpH5a1WGR5 =gjfd -----END PGP SIGNATURE----- --=-8xpWPeeNuFXolBvxj/MB-- --===============1236313346011643017== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============1236313346011643017==--