From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 03 of 10 v2] xen: sched_credit: let the scheduler know about node-affinity Date: Fri, 21 Dec 2012 17:13:31 +0100 Message-ID: <1356106411.15403.64.camel@Abyss> References: <06d2f322a6319d8ba212.1355944039@Solace> <50D37359.9080001@eu.citrix.com> <1356049122.15403.34.camel@Abyss> <50D47898.2060909@eu.citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2106059499683019071==" Return-path: In-Reply-To: <50D47898.2060909@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: George Dunlap Cc: Marcus Granado , Dan Magenheimer , Ian Campbell , Anil Madhavapeddy , Andrew Cooper , Juergen Gross , Ian Jackson , "xen-devel@lists.xen.org" , Jan Beulich , Daniel De Graaf , Matt Wilson List-Id: xen-devel@lists.xenproject.org --===============2106059499683019071== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-AFFfeewK2he1RbaLryrE" --=-AFFfeewK2he1RbaLryrE Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2012-12-21 at 14:56 +0000, George Dunlap wrote:=20 > > I hope I've explained it correctly, and sorry if it is a little bit > > tricky, especially to explain like this (although, believe me, it was > > tricky to hunt it out too! :-P). I've seen that happening and I'm almos= t > > sure I kept a trace somewhere, so let me know if you want to see the > > "smoking gun". :-) >=20 > No, the change looks quite plausible. I guess it's not obvious that the= =20 > balancing code will never migrate from one thread to another thread. =20 > It was far from obvious to figure out this was happening, yes. :-) > (That whole algorithm could do with some commenting -- I may submit a=20 > patch once this series is in.) >=20 Nice. > I'm really glad you've had the opportunity to take a close look at these= =20 > kinds of things. > Yeah, well, I'm happy to, scheduling never stops entertaining me, even (or especially) when it requires my brain-cells to workout so hard! :-D > What I was doing,=20 > in a sort of "thinking out loud" fashion, seeing under what conditions= =20 > that break might actually happen. Like the analysis with=20 > vcpu_should_migrate(), it might have turned out to be redundant, or to= =20 > have missed some cases. > Yep, I agree, it's another aspects of the patch-review model which is really helpful. Thanks, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-AFFfeewK2he1RbaLryrE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEABECAAYFAlDUiqwACgkQk4XaBE3IOsQjlwCeIlqrt9qakzoHn7pphKtH9yhC OsgAnjPYmsO3flwOHN9oRvVSaGf/Y4cw =eT9A -----END PGP SIGNATURE----- --=-AFFfeewK2he1RbaLryrE-- --===============2106059499683019071== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============2106059499683019071==--