From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 04 of 10 v2] xen: allow for explicitly specifying node-affinity Date: Fri, 21 Dec 2012 17:17:35 +0100 Message-ID: <1356106655.15403.68.camel@Abyss> References: <7e8c5e21c3ae1c267c23.1355944040@Solace> <50D47D99.9090209@eu.citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3119554692575500966==" Return-path: In-Reply-To: <50D47D99.9090209@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: George Dunlap Cc: Marcus Granado , Dan Magenheimer , Ian Campbell , Anil Madhavapeddy , Andrew Cooper , Juergen Gross , Ian Jackson , "xen-devel@lists.xen.org" , Jan Beulich , Daniel De Graaf , Matt Wilson List-Id: xen-devel@lists.xenproject.org --===============3119554692575500966== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-DoBd5iIsos/1Q95y7xUx" --=-DoBd5iIsos/1Q95y7xUx Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2012-12-21 at 15:17 +0000, George Dunlap wrote:=20 > On 19/12/12 19:07, Dario Faggioli wrote: > > Make it possible to pass the node-affinity of a domain to the hyperviso= r > > from the upper layers, instead of always being computed automatically. > > > > Note that this also required generalizing the Flask hooks for setting > > and getting the affinity, so that they now deal with both vcpu and > > node affinity. > > > > Signed-off-by: Dario Faggioli >=20 > I can't comment on the XSM stuff=20 > Right, it's the part I'm most week on too... Daniel had a go with this parch during v1's review, and he raised a couple of points that I think I addressed, let's see if he thinks there's anything else. > -- is any part of the "getvcpuaffinity"=20 > stuff for XSM a public interface that needs to be backwards-compatible? = =20 > I.e., is s/vcpu//; OK from an interface point of view? >=20 Mmm... Good point, I haven't thought about that. This was here in v1 and Daniel explicitly said he was fine with the renaming instead of adding a new hook, but mostly for the "semantic" point of view, not sure whether bkwrd compatibility is an issue... Daniel, what do you think? > WRT everything else: > Acked-by: George Dunlap >=20 Ok. Thanks, Dario <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-DoBd5iIsos/1Q95y7xUx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEABECAAYFAlDUi58ACgkQk4XaBE3IOsQUZwCeMb++YyvQ/LeOgqK3nrvBrxdx YawAniiBWO+dCfZYI7VS+0SVf9vOfMi/ =g3j5 -----END PGP SIGNATURE----- --=-DoBd5iIsos/1Q95y7xUx-- --===============3119554692575500966== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============3119554692575500966==--