Re: [PATCH 09 of 10 v2] xl: add node-affinity to the output of `xl list`

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 3373 bytes --]

On Fri, 2012-12-21 at 16:34 +0000, George Dunlap wrote: 
> Just checking -- is the print_bitmap() thing pure code motion? If so, 
> would you mind saying that explicitly in the commit message, just to 
> save people time when reading this patch?
> 
It's _mostly_ code motion, but I had to hack it a tiny little bit to
make it possible to use the same function for printing cpu and node
bitmaps (basically, in case all bits are sets, the function was printing
"any cpu" itself, which wasn't fitting well with node maps).

But yeah, I should have mentioned what I just put here in the changelog.
Will do in v3.

> Other than that, looks OK to me -- I haven't done a detailed review of 
> the output layout however.
> 
That's the most tricky part of this patch! :-)

For your and others convenience, here's how it looks like on my testbox
(sorry for the extra long lines, but that's not my fault!):

root@Zhaman:~# xl list
Name                                        ID   Mem VCPUs	State	Time(s)
Domain-0                                     0   375    16     r-----     225.1
vm1                                          1   960     2     -b----      34.0
root@Zhaman:~# xl list -Z
Name                                        ID   Mem VCPUs	State	Time(s)   Security Label
Domain-0                                     0   375    16     r-----     225.4                -
vm1                                          1   960     2     -b----      34.0                -
root@Zhaman:~# xl list -v
Name                                        ID   Mem VCPUs	State	Time(s)   UUID                            Reason-Code	Security Label
Domain-0                                     0   375    16     r-----     226.6 00000000-0000-0000-0000-000000000000        -                -
vm1                                          1   960     2     -b----      34.2 e36429cc-d2a2-4da7-b21d-b053f725e7a7        -                -

root@Zhaman:~# xl list -n
Name                                        ID   Mem VCPUs	State	Time(s) NODE Affinity
Domain-0                                     0   375    16     r-----     226.8 any node
vm1                                          1   960     2     -b----      34.2 0
root@Zhaman:~# xl list -nZ
Name                                        ID   Mem VCPUs	State	Time(s)   Security Label NODE Affinity
Domain-0                                     0   375    16     r-----     226.9                - any node
vm1                                          1   960     2     -b----      34.2                - 0
root@Zhaman:~# xl list -nv
Name                                        ID   Mem VCPUs	State	Time(s)   UUID                            Reason-Code	Security Label NODE Affinity
Domain-0                                     0   375    16     r-----     227.0 00000000-0000-0000-0000-000000000000        -                - any node
vm1                                          1   960     2     -b----      34.2 e36429cc-d2a2-4da7-b21d-b053f725e7a7        -                - 0

Reasonable enough?

Thanks and Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)



[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel