From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Liu <Wei.Liu2@citrix.com>
Subject: Re: [RFC PATCH 3/3] Implement 3-level event channel
 routines.
Date: Tue, 8 Jan 2013 17:33:13 +0000
Message-ID: <1357666393.2743.1.camel@iceland>
References: <1356978155-18293-1-git-send-email-wei.liu2@citrix.com>
	<1356978155-18293-4-git-send-email-wei.liu2@citrix.com>
	<50E57B1402000078000B2AED@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <50E57B1402000078000B2AED@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Wei Liu <liuw@liuw.name>, wei.liu2@citrix.com, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Thu, 2013-01-03 at 11:35 +0000, Jan Beulich wrote:
> >>> On 31.12.12 at 19:22, Wei Liu <wei.liu2@citrix.com> wrote:
> >
> > +static void __unmap_l2_sel(struct vcpu *v)
> > +{
> > +    unsigned long mfn;
> > +
> > +    if ( v->evtchn_pending_sel_l2 != 0 )
> > +    {
> > +        unmap_domain_page_global(v->evtchn_pending_sel_l2);
> > +        mfn = virt_to_mfn(v->evtchn_pending_sel_l2);
> 
> virt_to_mfn() is not valid on the output of
> map_domain_page{,_global}() (same further down). Yes, there is
> at least one example of this in the existing code, but that's wrong
> too, and is getting eliminated by the 16Tb patch series I'm in the
> process of putting together.
> 

So what's the correct way to do this? Do I need to wait for your patch
series?


Wei.