* [PATCH] libxl: don't continue to create the domain if the device model is not spawned
@ 2013-01-10 12:21 Julien Grall
2013-01-17 13:53 ` Ian Campbell
0 siblings, 1 reply; 2+ messages in thread
From: Julien Grall @ 2013-01-10 12:21 UTC (permalink / raw)
To: xen-devel; +Cc: Julien Grall, ian.jackson
When the device model can't be spawned, rc variable is cleared in
device_model_spawn_outcome (libxl_dm.c).
In this case libxl will continue to create the domain and let it between life
and death.
Signed-off-by: Julien Grall <julien.grall@citrix.com>
---
tools/libxl/libxl_dm.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
index c036dc1..51f9914 100644
--- a/tools/libxl/libxl_dm.c
+++ b/tools/libxl/libxl_dm.c
@@ -1215,8 +1215,6 @@ static void device_model_spawn_outcome(libxl__egc *egc,
}
}
- rc = 0;
-
out:
dmss->callback(egc, dmss, rc);
}
--
Julien Grall
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] libxl: don't continue to create the domain if the device model is not spawned
2013-01-10 12:21 [PATCH] libxl: don't continue to create the domain if the device model is not spawned Julien Grall
@ 2013-01-17 13:53 ` Ian Campbell
0 siblings, 0 replies; 2+ messages in thread
From: Ian Campbell @ 2013-01-17 13:53 UTC (permalink / raw)
To: Julien Grall; +Cc: xen-devel@lists.xensource.com, Ian Jackson
On Thu, 2013-01-10 at 12:21 +0000, Julien Grall wrote:
> When the device model can't be spawned, rc variable is cleared in
> device_model_spawn_outcome (libxl_dm.c).
> In this case libxl will continue to create the domain and let it between life
> and death.
>
> Signed-off-by: Julien Grall <julien.grall@citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
+ applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-17 13:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-10 12:21 [PATCH] libxl: don't continue to create the domain if the device model is not spawned Julien Grall
2013-01-17 13:53 ` Ian Campbell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).