xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Mats Petersson <mats.petersson@citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH V6] Switch from select() to poll() in xenconsoled's IO loop
Date: Sun, 13 Jan 2013 10:24:08 +0000	[thread overview]
Message-ID: <1358072648.12854.10.camel@dagon.hellion.org.uk> (raw)
In-Reply-To: <1357907125.20328.62.camel@zakaz.uk.xensource.com>

On Fri, 2013-01-11 at 12:25 +0000, Ian Campbell wrote:
> On Wed, 2013-01-09 at 11:02 +0000, Ian Campbell wrote:
> > On Wed, 2013-01-09 at 09:50 +0000, Wei Liu wrote:
> > > In Linux select() typically supports up to 1024 file descriptors. This can be
> > > a problem when user tries to boot up many guests. Switching to poll() has
> > > minimum impact on existing code and has better scalibility.
> > > 
> > > pollfd array is dynamically allocated / reallocated. If the array fails to
> > > expand, we just ignore the incoming fd.
> 
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> 
> And now applied.

I'm afraid I've now reverted this, the bisector
<E1Tu7of-0004FF-Mf@woking.cam.xci-test.com> fingered it as responsible
for the failures in test flight 14869 onwards.

Ian.

      reply	other threads:[~2013-01-13 10:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-09  9:50 [PATCH V6] Switch from select() to poll() in xenconsoled's IO loop Wei Liu
2013-01-09 11:02 ` Ian Campbell
2013-01-11 12:25   ` Ian Campbell
2013-01-13 10:24     ` Ian Campbell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1358072648.12854.10.camel@dagon.hellion.org.uk \
    --to=ian.campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=mats.petersson@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).