From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH V6] Switch from select() to poll() in xenconsoled's IO loop Date: Sun, 13 Jan 2013 10:24:08 +0000 Message-ID: <1358072648.12854.10.camel@dagon.hellion.org.uk> References: <1357725038-3949-1-git-send-email-wei.liu2@citrix.com> <1357729342.7989.226.camel@zakaz.uk.xensource.com> <1357907125.20328.62.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1357907125.20328.62.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: Mats Petersson , Ian Jackson , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Fri, 2013-01-11 at 12:25 +0000, Ian Campbell wrote: > On Wed, 2013-01-09 at 11:02 +0000, Ian Campbell wrote: > > On Wed, 2013-01-09 at 09:50 +0000, Wei Liu wrote: > > > In Linux select() typically supports up to 1024 file descriptors. This can be > > > a problem when user tries to boot up many guests. Switching to poll() has > > > minimum impact on existing code and has better scalibility. > > > > > > pollfd array is dynamically allocated / reallocated. If the array fails to > > > expand, we just ignore the incoming fd. > > > Acked-by: Ian Campbell > > And now applied. I'm afraid I've now reverted this, the bisector fingered it as responsible for the failures in test flight 14869 onwards. Ian.