* [xen-unstable bisection] complete test-amd64-amd64-xl
@ 2013-01-12 20:36 xen.org
2013-01-14 14:08 ` Wei Liu
0 siblings, 1 reply; 8+ messages in thread
From: xen.org @ 2013-01-12 20:36 UTC (permalink / raw)
To: xen-devel; +Cc: ian.jackson, keir, stefano.stabellini
branch xen-unstable
xen branch xen-unstable
job test-amd64-amd64-xl
test guest-localmigrate/x10
Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: qemu git://xenbits.xen.org/staging/qemu-xen-unstable.git
Tree: qemuu git://xenbits.xen.org/staging/qemu-upstream-unstable.git
Tree: xen http://xenbits.xen.org/hg/staging/xen-unstable.hg
*** Found and reproduced problem changeset ***
Bug is in tree: xen http://xenbits.xen.org/hg/staging/xen-unstable.hg
Bug introduced: 0b9dfd067b42
Bug not present: c3c683a439ae
changeset: 26375:0b9dfd067b42
user: Wei Liu <wei.liu2@citrix.com>
date: Fri Jan 11 12:22:30 2013 +0000
Switch from select() to poll() in xenconsoled's IO loop
In Linux select() typically supports up to 1024 file descriptors. This can be
a problem when user tries to boot up many guests. Switching to poll() has
minimum impact on existing code and has better scalibility.
pollfd array is dynamically allocated / reallocated. If the array fails to
expand, we just ignore the incoming fd.
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Committed-by: Ian Campbell <ian.campbell@citrix.com>
For bisection revision-tuple graph see:
http://www.chiark.greenend.org.uk/~xensrcts/results/bisect.xen-unstable.test-amd64-amd64-xl.guest-localmigrate--x10.html
Revision IDs in each graph node refer, respectively, to the Trees above.
----------------------------------------
Searching for failure / basis pass:
14891 fail [host=earwig] / 14856 [host=lace-bug] 14855 [host=potato-beetle] 14852 [host=leaf-beetle] 14848 [host=woodlouse] 14842 [host=field-cricket] 14840 [host=lake-frog] 14837 [host=fire-frog] 14836 [host=bush-cricket] 14832 [host=field-cricket] 14830 [host=gall-mite] 14828 [host=lake-frog] 14827 [host=itch-mite] 14826 [host=gall-mite] 14822 [host=potato-beetle] 14820 [host=field-cricket] 14819 [host=bush-cricket] 14817 [host=moss-bug] 14816 [host=lace-bug] 14815 [host=itch-mite] 14814 [host=lake-frog] 14813 [host=bush-cricket] 14812 [host=field-cricket] 14811 [host=potato-beetle] 14810 [host=woodlouse] 14807 ok.
Failure / basis pass flights: 14891 / 14807
Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: qemu git://xenbits.xen.org/staging/qemu-xen-unstable.git
Tree: qemuu git://xenbits.xen.org/staging/qemu-upstream-unstable.git
Tree: xen http://xenbits.xen.org/hg/staging/xen-unstable.hg
Latest a938a246d34912423c560f475ccf1ce0c71d9d00 6a0cf3786f1964fdf5a17f88f26cb499f4e89c81 3752993df8af5cffa1b8219fe175d235597b4474 1e2195cb4410
Basis pass a938a246d34912423c560f475ccf1ce0c71d9d00 6a0cf3786f1964fdf5a17f88f26cb499f4e89c81 3752993df8af5cffa1b8219fe175d235597b4474 c4114a042410
Generating revisions with ./adhoc-revtuple-generator git://xenbits.xen.org/linux-pvops.git#a938a246d34912423c560f475ccf1ce0c71d9d00-a938a246d34912423c560f475ccf1ce0c71d9d00 git://xenbits.xen.org/staging/qemu-xen-unstable.git#6a0cf3786f1964fdf5a17f88f26cb499f4e89c81-6a0cf3786f1964fdf5a17f88f26cb499f4e89c81 git://xenbits.xen.org/staging/qemu-upstream-unstable.git#3752993df8af5cffa1b8219fe175d235597b4474-3752993df8af5cffa1b8219fe175d235597b4474 http://xenbits.xen.org/hg/staging/xen-unstable.hg#c4114a042410-1e2195cb4410
pulling from ssh://xen@xenbits.xen.org/HG/staging/xen-unstable.hg
searching for changes
no changes found
pulling from ssh://xen@xenbits.xen.org/HG/staging/xen-unstable.hg
searching for changes
no changes found
Loaded 114 nodes in revision graph
Searching for test results:
14807 pass a938a246d34912423c560f475ccf1ce0c71d9d00 6a0cf3786f1964fdf5a17f88f26cb499f4e89c81 3752993df8af5cffa1b8219fe175d235597b4474 c4114a042410
14806 [host=leaf-beetle]
14811 [host=potato-beetle]
14810 [host=woodlouse]
14812 [host=field-cricket]
14813 [host=bush-cricket]
14814 [host=lake-frog]
14815 [host=itch-mite]
14816 [host=lace-bug]
14817 [host=moss-bug]
14819 [host=bush-cricket]
14820 [host=field-cricket]
14822 [host=potato-beetle]
14826 [host=gall-mite]
14827 [host=itch-mite]
14828 [host=lake-frog]
14852 [host=leaf-beetle]
14897 fail a938a246d34912423c560f475ccf1ce0c71d9d00 6a0cf3786f1964fdf5a17f88f26cb499f4e89c81 3752993df8af5cffa1b8219fe175d235597b4474 0b9dfd067b42
14855 [host=potato-beetle]
14830 [host=gall-mite]
14856 [host=lace-bug]
14832 [host=field-cricket]
14836 [host=bush-cricket]
14899 pass a938a246d34912423c560f475ccf1ce0c71d9d00 6a0cf3786f1964fdf5a17f88f26cb499f4e89c81 3752993df8af5cffa1b8219fe175d235597b4474 56daf05bcf69
14857 []
14837 [host=fire-frog]
14869 fail a938a246d34912423c560f475ccf1ce0c71d9d00 6a0cf3786f1964fdf5a17f88f26cb499f4e89c81 3752993df8af5cffa1b8219fe175d235597b4474 32758c974bf8
14840 [host=lake-frog]
14889 pass a938a246d34912423c560f475ccf1ce0c71d9d00 6a0cf3786f1964fdf5a17f88f26cb499f4e89c81 3752993df8af5cffa1b8219fe175d235597b4474 c4114a042410
14842 [host=field-cricket]
14884 fail a938a246d34912423c560f475ccf1ce0c71d9d00 6a0cf3786f1964fdf5a17f88f26cb499f4e89c81 3752993df8af5cffa1b8219fe175d235597b4474 1e2195cb4410
14848 [host=woodlouse]
14900 pass a938a246d34912423c560f475ccf1ce0c71d9d00 6a0cf3786f1964fdf5a17f88f26cb499f4e89c81 3752993df8af5cffa1b8219fe175d235597b4474 c3c683a439ae
14890 fail a938a246d34912423c560f475ccf1ce0c71d9d00 6a0cf3786f1964fdf5a17f88f26cb499f4e89c81 3752993df8af5cffa1b8219fe175d235597b4474 1e2195cb4410
14892 pass a938a246d34912423c560f475ccf1ce0c71d9d00 6a0cf3786f1964fdf5a17f88f26cb499f4e89c81 3752993df8af5cffa1b8219fe175d235597b4474 0bc879ecb8b3
14877 fail a938a246d34912423c560f475ccf1ce0c71d9d00 6a0cf3786f1964fdf5a17f88f26cb499f4e89c81 3752993df8af5cffa1b8219fe175d235597b4474 1e2195cb4410
14901 fail a938a246d34912423c560f475ccf1ce0c71d9d00 6a0cf3786f1964fdf5a17f88f26cb499f4e89c81 3752993df8af5cffa1b8219fe175d235597b4474 0b9dfd067b42
14893 pass a938a246d34912423c560f475ccf1ce0c71d9d00 6a0cf3786f1964fdf5a17f88f26cb499f4e89c81 3752993df8af5cffa1b8219fe175d235597b4474 cabf395a6c84
14894 pass a938a246d34912423c560f475ccf1ce0c71d9d00 6a0cf3786f1964fdf5a17f88f26cb499f4e89c81 3752993df8af5cffa1b8219fe175d235597b4474 9a1610c1e564
14902 pass a938a246d34912423c560f475ccf1ce0c71d9d00 6a0cf3786f1964fdf5a17f88f26cb499f4e89c81 3752993df8af5cffa1b8219fe175d235597b4474 c3c683a439ae
14895 blocked a938a246d34912423c560f475ccf1ce0c71d9d00 6a0cf3786f1964fdf5a17f88f26cb499f4e89c81 3752993df8af5cffa1b8219fe175d235597b4474 b35e06c84bd0
14891 fail a938a246d34912423c560f475ccf1ce0c71d9d00 6a0cf3786f1964fdf5a17f88f26cb499f4e89c81 3752993df8af5cffa1b8219fe175d235597b4474 1e2195cb4410
14903 fail a938a246d34912423c560f475ccf1ce0c71d9d00 6a0cf3786f1964fdf5a17f88f26cb499f4e89c81 3752993df8af5cffa1b8219fe175d235597b4474 0b9dfd067b42
14904 pass a938a246d34912423c560f475ccf1ce0c71d9d00 6a0cf3786f1964fdf5a17f88f26cb499f4e89c81 3752993df8af5cffa1b8219fe175d235597b4474 c3c683a439ae
14905 fail a938a246d34912423c560f475ccf1ce0c71d9d00 6a0cf3786f1964fdf5a17f88f26cb499f4e89c81 3752993df8af5cffa1b8219fe175d235597b4474 0b9dfd067b42
Searching for interesting versions
Result found: flight 14807 (pass), for basis pass
Result found: flight 14877 (fail), for basis failure
Repro found: flight 14889 (pass), for basis pass
Repro found: flight 14890 (fail), for basis failure
0 revisions at a938a246d34912423c560f475ccf1ce0c71d9d00 6a0cf3786f1964fdf5a17f88f26cb499f4e89c81 3752993df8af5cffa1b8219fe175d235597b4474 c3c683a439ae
No revisions left to test, checking graph state.
Result found: flight 14900 (pass), for last pass
Result found: flight 14901 (fail), for first failure
Repro found: flight 14902 (pass), for last pass
Repro found: flight 14903 (fail), for first failure
Repro found: flight 14904 (pass), for last pass
Repro found: flight 14905 (fail), for first failure
*** Found and reproduced problem changeset ***
Bug is in tree: xen http://xenbits.xen.org/hg/staging/xen-unstable.hg
Bug introduced: 0b9dfd067b42
Bug not present: c3c683a439ae
pulling from ssh://xen@xenbits.xen.org/HG/staging/xen-unstable.hg
searching for changes
no changes found
changeset: 26375:0b9dfd067b42
user: Wei Liu <wei.liu2@citrix.com>
date: Fri Jan 11 12:22:30 2013 +0000
Switch from select() to poll() in xenconsoled's IO loop
In Linux select() typically supports up to 1024 file descriptors. This can be
a problem when user tries to boot up many guests. Switching to poll() has
minimum impact on existing code and has better scalibility.
pollfd array is dynamically allocated / reallocated. If the array fails to
expand, we just ignore the incoming fd.
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Committed-by: Ian Campbell <ian.campbell@citrix.com>
Revision graph left in /home/xc_osstest/results/bisect.xen-unstable.test-amd64-amd64-xl.guest-localmigrate--x10.{dot,ps,png,html}.
----------------------------------------
14905: tolerable ALL FAIL
flight 14905 xen-unstable real-bisect [real]
http://www.chiark.greenend.org.uk/~xensrcts/logs/14905/
Failures :-/ but no regressions.
Tests which did not succeed,
including tests which could not be run:
test-amd64-amd64-xl 14 guest-localmigrate/x10 fail baseline untested
jobs:
test-amd64-amd64-xl fail
------------------------------------------------------------
sg-report-flight on woking.cam.xci-test.com
logs: /home/xc_osstest/logs
images: /home/xc_osstest/images
Logs, config files, etc. are available at
http://www.chiark.greenend.org.uk/~xensrcts/logs
Test harness code can be found at
http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [xen-unstable bisection] complete test-amd64-amd64-xl
2013-01-12 20:36 [xen-unstable bisection] complete test-amd64-amd64-xl xen.org
@ 2013-01-14 14:08 ` Wei Liu
2013-01-17 13:53 ` Ian Campbell
0 siblings, 1 reply; 8+ messages in thread
From: Wei Liu @ 2013-01-14 14:08 UTC (permalink / raw)
To: xen.org
Cc: Keir (Xen.org), xen-devel@lists.xensource.com, wei.liu2,
Stefano Stabellini
On Sat, 2013-01-12 at 20:36 +0000, xen.org wrote:
> http://www.chiark.greenend.org.uk/~xensrcts/logs/14905/
>
> Failures :-/ but no regressions.
>
> Tests which did not succeed,
> including tests which could not be run:
> test-amd64-amd64-xl 14 guest-localmigrate/x10 fail baseline untested
>
>
> jobs:
> test-amd64-amd64-xl fail
>
>
> ------------------------------------------------------------
> sg-report-flight on woking.cam.xci-test.com
> logs: /home/xc_osstest/logs
> images: /home/xc_osstest/images
>
> Logs, config files, etc. are available at
> http://www.chiark.greenend.org.uk/~xensrcts/logs
>
> Test harness code can be found at
> http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary
>
I reproduced the bug. Some pointers were not reset correctly in the
original patch, so xenconsoled would segfault. After xenconsoled
crashed, the guest was in r(unning) state. It was spin waiting to setup
the console, but as xenconsoled was not there any more, so this
operation hanged forever, thus causing the guest not responsive to ssh
connection (or anything else).
The new patch fixes this problem, also removes unused slave_pollfd from
struct domain.
Wei.
--------------8<--------------------
>From e3ca8ecc38612668474121e5334a2d8ea5c01c39 Mon Sep 17 00:00:00 2001
From: Wei Liu <wei.liu2@citrix.com>
Date: Thu, 3 Jan 2013 16:54:31 +0000
Subject: [PATCH] Switch from select() to poll() in xenconsoled's IO loop
In Linux select() typically supports up to 1024 file descriptors. This can be
a problem when user tries to boot up many guests. Switching to poll() has
minimum impact on existing code and has better scalibility.
pollfd array is dynamically allocated / reallocated. If the array fails to
expand, we just ignore the incoming fd.
Updated: reset *_pollfd after use.
This fixes regression 14869.
Also remove unused slave_pollfd in strcut domain.
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
tools/console/daemon/io.c | 212 ++++++++++++++++++++++++++++++---------------
1 file changed, 140 insertions(+), 72 deletions(-)
diff --git a/tools/console/daemon/io.c b/tools/console/daemon/io.c
index 48fe151..6b659d4 100644
--- a/tools/console/daemon/io.c
+++ b/tools/console/daemon/io.c
@@ -28,7 +28,7 @@
#include <stdlib.h>
#include <errno.h>
#include <string.h>
-#include <sys/select.h>
+#include <poll.h>
#include <fcntl.h>
#include <unistd.h>
#include <termios.h>
@@ -66,9 +66,12 @@ extern int discard_overflowed_data;
static int log_time_hv_needts = 1;
static int log_time_guest_needts = 1;
static int log_hv_fd = -1;
-static evtchn_port_or_error_t log_hv_evtchn = -1;
-static xc_interface *xch; /* why does xenconsoled have two xc handles ? */
-static xc_evtchn *xce_handle = NULL;
+
+static struct pollfd *fds;
+static unsigned int current_array_size;
+static unsigned int nr_fds;
+
+#define ROUNDUP(_x,_w) (((unsigned long)(_x)+(1UL<<(_w))-1) & ~((1UL<<(_w))-1))
struct buffer {
char *data;
@@ -81,6 +84,7 @@ struct buffer {
struct domain {
int domid;
int master_fd;
+ struct pollfd *master_pollfd;
int slave_fd;
int log_fd;
bool is_dead;
@@ -92,6 +96,7 @@ struct domain {
evtchn_port_or_error_t local_port;
evtchn_port_or_error_t remote_port;
xc_evtchn *xce_handle;
+ struct pollfd *xce_pollfd;
struct xencons_interface *interface;
int event_count;
long long next_period;
@@ -769,6 +774,17 @@ static int ring_free_bytes(struct domain *dom)
return (sizeof(intf->in) - space);
}
+static void domain_handle_broken_tty(struct domain *dom, int recreate)
+{
+ domain_close_tty(dom);
+
+ if (recreate) {
+ domain_create_tty(dom);
+ } else {
+ shutdown_domain(dom);
+ }
+}
+
static void handle_tty_read(struct domain *dom)
{
ssize_t len = 0;
@@ -794,13 +810,7 @@ static void handle_tty_read(struct domain *dom)
* keep the slave open for the duration.
*/
if (len < 0) {
- domain_close_tty(dom);
-
- if (domain_is_valid(dom->domid)) {
- domain_create_tty(dom);
- } else {
- shutdown_domain(dom);
- }
+ domain_handle_broken_tty(dom, domain_is_valid(dom->domid));
} else if (domain_is_valid(dom->domid)) {
prod = intf->in_prod;
for (i = 0; i < len; i++) {
@@ -828,14 +838,7 @@ static void handle_tty_write(struct domain *dom)
if (len < 1) {
dolog(LOG_DEBUG, "Write failed on domain %d: %zd, %d\n",
dom->domid, len, errno);
-
- domain_close_tty(dom);
-
- if (domain_is_valid(dom->domid)) {
- domain_create_tty(dom);
- } else {
- shutdown_domain(dom);
- }
+ domain_handle_broken_tty(dom, domain_is_valid(dom->domid));
} else {
buffer_advance(&dom->buffer, len);
}
@@ -883,7 +886,7 @@ static void handle_xs(void)
free(vec);
}
-static void handle_hv_logs(void)
+static void handle_hv_logs(xc_evtchn *xce_handle)
{
char buffer[1024*16];
char *bufptr = buffer;
@@ -894,7 +897,7 @@ static void handle_hv_logs(void)
if ((port = xc_evtchn_pending(xce_handle)) == -1)
return;
- if (xc_readconsolering(xch, bufptr, &size, 0, 1, &index) == 0 && size > 0) {
+ if (xc_readconsolering(xc, bufptr, &size, 0, 1, &index) == 0 && size > 0) {
int logret;
if (log_time_hv)
logret = write_with_timestamp(log_hv_fd, buffer, size,
@@ -928,18 +931,54 @@ static void handle_log_reload(void)
}
}
+static struct pollfd *set_fds(int fd, short events)
+{
+ struct pollfd *ret;
+ if (current_array_size < nr_fds + 1) {
+ struct pollfd *new_fds = NULL;
+ unsigned long newsize;
+
+ /* Round up to 2^8 boundary, in practice this just
+ * make newsize larger than current_array_size.
+ */
+ newsize = ROUNDUP(nr_fds + 1, 8);
+
+ new_fds = realloc(fds, sizeof(struct pollfd)*newsize);
+ if (!new_fds)
+ goto fail;
+ fds = new_fds;
+
+ memset(&fds[0] + current_array_size, 0,
+ sizeof(struct pollfd) * (newsize-current_array_size));
+ current_array_size = newsize;
+ }
+
+ fds[nr_fds].fd = fd;
+ fds[nr_fds].events = events;
+ ret = &fds[nr_fds];
+ nr_fds++;
+
+ return ret;
+fail:
+ dolog(LOG_ERR, "realloc failed, ignoring fd %d\n", fd);
+ return NULL;
+}
+
+static void reset_fds(void)
+{
+ nr_fds = 0;
+ memset(fds, 0, sizeof(struct pollfd) * current_array_size);
+}
+
void handle_io(void)
{
- fd_set readfds, writefds;
int ret;
+ evtchn_port_or_error_t log_hv_evtchn = -1;
+ struct pollfd *xce_pollfd = NULL;
+ struct pollfd *xs_pollfd = NULL;
+ xc_evtchn *xce_handle = NULL;
if (log_hv) {
- xch = xc_interface_open(0,0,0);
- if (!xch) {
- dolog(LOG_ERR, "Failed to open xc handle: %d (%s)",
- errno, strerror(errno));
- goto out;
- }
xce_handle = xc_evtchn_open(NULL, 0);
if (xce_handle == NULL) {
dolog(LOG_ERR, "Failed to open xce handle: %d (%s)",
@@ -959,21 +998,17 @@ void handle_io(void)
for (;;) {
struct domain *d, *n;
- int max_fd = -1;
- struct timeval timeout;
+ int poll_timeout; /* timeout in milliseconds */
struct timespec ts;
long long now, next_timeout = 0;
- FD_ZERO(&readfds);
- FD_ZERO(&writefds);
+ reset_fds();
- FD_SET(xs_fileno(xs), &readfds);
- max_fd = MAX(xs_fileno(xs), max_fd);
+ xs_pollfd = set_fds(xs_fileno(xs), POLLIN|POLLPRI);
- if (log_hv) {
- FD_SET(xc_evtchn_fd(xce_handle), &readfds);
- max_fd = MAX(xc_evtchn_fd(xce_handle), max_fd);
- }
+ if (log_hv)
+ xce_pollfd = set_fds(xc_evtchn_fd(xce_handle),
+ POLLIN|POLLPRI);
if (clock_gettime(CLOCK_MONOTONIC, &ts) < 0)
return;
@@ -982,10 +1017,12 @@ void handle_io(void)
/* Re-calculate any event counter allowances & unblock
domains with new allowance */
for (d = dom_head; d; d = d->next) {
- /* Add 5ms of fuzz since select() often returns
- a couple of ms sooner than requested. Without
- the fuzz we typically do an extra spin in select()
- with a 1/2 ms timeout every other iteration */
+ /* CS 16257:955ee4fa1345 introduces a 5ms fuzz
+ * for select(), it is not clear poll() has
+ * similar behavior (returning a couple of ms
+ * sooner than requested) as well. Just leave
+ * the fuzz here. Remove it with a separate
+ * patch if necessary */
if ((now+5) > d->next_period) {
d->next_period = now + RATE_LIMIT_PERIOD;
if (d->event_count >= RATE_LIMIT_ALLOWANCE) {
@@ -1006,75 +1043,107 @@ void handle_io(void)
!d->buffer.max_capacity ||
d->buffer.size < d->buffer.max_capacity) {
int evtchn_fd = xc_evtchn_fd(d->xce_handle);
- FD_SET(evtchn_fd, &readfds);
- max_fd = MAX(evtchn_fd, max_fd);
+ d->xce_pollfd = set_fds(evtchn_fd,
+ POLLIN|POLLPRI);
}
}
if (d->master_fd != -1) {
+ short events = 0;
if (!d->is_dead && ring_free_bytes(d))
- FD_SET(d->master_fd, &readfds);
+ events |= POLLIN;
if (!buffer_empty(&d->buffer))
- FD_SET(d->master_fd, &writefds);
- max_fd = MAX(d->master_fd, max_fd);
+ events |= POLLOUT;
+
+ if (events)
+ d->master_pollfd =
+ set_fds(d->master_fd,
+ events|POLLPRI);
}
}
/* If any domain has been rate limited, we need to work
- out what timeout to supply to select */
+ out what timeout to supply to poll */
if (next_timeout) {
long long duration = (next_timeout - now);
if (duration <= 0) /* sanity check */
duration = 1;
- timeout.tv_sec = duration / 1000;
- timeout.tv_usec = ((duration - (timeout.tv_sec * 1000))
- * 1000);
+ poll_timeout = (int)duration;
}
- ret = select(max_fd + 1, &readfds, &writefds, 0,
- next_timeout ? &timeout : NULL);
+ ret = poll(fds, nr_fds, next_timeout ? poll_timeout : -1);
if (log_reload) {
handle_log_reload();
log_reload = 0;
}
- /* Abort if select failed, except for EINTR cases
+ /* Abort if poll failed, except for EINTR cases
which indicate a possible log reload */
if (ret == -1) {
if (errno == EINTR)
continue;
- dolog(LOG_ERR, "Failure in select: %d (%s)",
+ dolog(LOG_ERR, "Failure in poll: %d (%s)",
errno, strerror(errno));
break;
}
- if (log_hv && FD_ISSET(xc_evtchn_fd(xce_handle), &readfds))
- handle_hv_logs();
+ if (log_hv && xce_pollfd) {
+ if (xce_pollfd->revents & ~(POLLIN|POLLOUT|POLLPRI)) {
+ dolog(LOG_ERR,
+ "Failure in poll xce_handle: %d (%s)",
+ errno, strerror(errno));
+ break;
+ } else if (xce_pollfd->revents & POLLIN)
+ handle_hv_logs(xce_handle);
+
+ xce_pollfd = NULL;
+ }
if (ret <= 0)
continue;
- if (FD_ISSET(xs_fileno(xs), &readfds))
- handle_xs();
+ if (xs_pollfd) {
+ if (xs_pollfd->revents & ~(POLLIN|POLLOUT|POLLPRI)) {
+ dolog(LOG_ERR,
+ "Failure in poll xs_handle: %d (%s)",
+ errno, strerror(errno));
+ break;
+ } else if (xs_pollfd->revents & POLLIN)
+ handle_xs();
+
+ xs_pollfd = NULL;
+ }
for (d = dom_head; d; d = n) {
n = d->next;
if (d->event_count < RATE_LIMIT_ALLOWANCE) {
if (d->xce_handle != NULL &&
- FD_ISSET(xc_evtchn_fd(d->xce_handle),
- &readfds))
- handle_ring_read(d);
+ d->xce_pollfd &&
+ !(d->xce_pollfd->revents &
+ ~(POLLIN|POLLOUT|POLLPRI)) &&
+ (d->xce_pollfd->revents &
+ POLLIN))
+ handle_ring_read(d);
}
- if (d->master_fd != -1 && FD_ISSET(d->master_fd,
- &readfds))
- handle_tty_read(d);
+ if (d->master_fd != -1 && d->master_pollfd) {
+ if (d->master_pollfd->revents &
+ ~(POLLIN|POLLOUT|POLLPRI))
+ domain_handle_broken_tty(d,
+ domain_is_valid(d->domid));
+ else {
+ if (d->master_pollfd->revents &
+ POLLIN)
+ handle_tty_read(d);
+ if (d->master_pollfd->revents &
+ POLLOUT)
+ handle_tty_write(d);
+ }
+ }
- if (d->master_fd != -1 && FD_ISSET(d->master_fd,
- &writefds))
- handle_tty_write(d);
+ d->xce_pollfd = d->master_pollfd = NULL;
if (d->last_seen != enum_pass)
shutdown_domain(d);
@@ -1084,15 +1153,14 @@ void handle_io(void)
}
}
+ free(fds);
+ current_array_size = 0;
+
out:
if (log_hv_fd != -1) {
close(log_hv_fd);
log_hv_fd = -1;
}
- if (xch) {
- xc_interface_close(xch);
- xch = 0;
- }
if (xce_handle != NULL) {
xc_evtchn_close(xce_handle);
xce_handle = NULL;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [xen-unstable bisection] complete test-amd64-amd64-xl
2013-01-14 14:08 ` Wei Liu
@ 2013-01-17 13:53 ` Ian Campbell
0 siblings, 0 replies; 8+ messages in thread
From: Ian Campbell @ 2013-01-17 13:53 UTC (permalink / raw)
To: Wei Liu
Cc: Keir (Xen.org), xen-devel@lists.xensource.com, Ian Jackson,
Stefano Stabellini
On Mon, 2013-01-14 at 14:08 +0000, Wei Liu wrote:
[...]
> Subject: [PATCH] Switch from select() to poll() in xenconsoled's IO loop
>
> In Linux select() typically supports up to 1024 file descriptors. This can be
> a problem when user tries to boot up many guests. Switching to poll() has
> minimum impact on existing code and has better scalibility.
>
> pollfd array is dynamically allocated / reallocated. If the array fails to
> expand, we just ignore the incoming fd.
>
> Updated: reset *_pollfd after use.
>
> This fixes regression 14869.
>
> Also remove unused slave_pollfd in strcut domain.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Acked + applied.
^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <E1UVggG-0008W0-B5@woking.cam.xci-test.com>]
* Re: [xen-unstable bisection] complete test-amd64-amd64-xl
[not found] <E1UVggG-0008W0-B5@woking.cam.xci-test.com>
@ 2013-04-26 11:26 ` Ian Campbell
2013-05-01 15:33 ` Ian Jackson
0 siblings, 1 reply; 8+ messages in thread
From: Ian Campbell @ 2013-04-26 11:26 UTC (permalink / raw)
To: xen.org
Cc: xen-devel@lists.xensource.com, Keir (Xen.org), Dave Scott,
Stefano Stabellini
On Fri, 2013-04-26 at 12:19 +0100, xen.org wrote:
> branch xen-unstable
> xen branch xen-unstable
> job test-amd64-amd64-xl
> test guest-stop
>
> Tree: linux git://xenbits.xen.org/linux-pvops.git
> Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
> Tree: qemu git://xenbits.xen.org/staging/qemu-xen-unstable.git
> Tree: qemuu git://xenbits.xen.org/staging/qemu-upstream-unstable.git
> Tree: xen git://xenbits.xen.org/xen.git
>
> *** Found and reproduced problem changeset ***
>
> Bug is in tree: xen git://xenbits.xen.org/xen.git
> Bug introduced: a8a1f236a2964506a22d1779648d8e1c8668cb1a
> Bug not present: 3051bdedc3ef82eb5f14978823dec00784d69d0e
Did this not used to include the relevant changlog entry?
Anyway, this is a change which I've just independently discovered is
broken and I'm investigating:
commit a8a1f236a2964506a22d1779648d8e1c8668cb1a
Author: David Scott <dave.scott@eu.citrix.com>
Date: Tue Apr 23 10:59:26 2013 +0100
libxl: Only call stat() when adding a disk if we expect a device to exist.
We consider calling stat() a helpful error check in the following
circumstances only:
1. the disk backend type must be PHYsical
2. the disk backend domain must be the same as the running libxl
code (ie LIBXL_TOOLSTACK_DOMID)
3. there must not be a hotplug script because this would imply that
the device won't be created until after the hotplug script has
run.
With this fix, it is possible to use qemu's built-in block drivers
such as ceph/rbd, with a xl config disk spec like this:
disk=[ 'backendtype=qdisk,format=raw,vdev=hda,access=rw,target=rbd:rbd/ubun
Signed-off-by: David Scott <dave.scott@eu.citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
>
>
>
> For bisection revision-tuple graph see:
> http://www.chiark.greenend.org.uk/~xensrcts/results/bisect.xen-unstable.test-amd64-amd64-xl.guest-stop.html
> Revision IDs in each graph node refer, respectively, to the Trees above.
>
> ----------------------------------------
> Searching for failure / basis pass:
> 17816 fail [host=itch-mite] / 17791 [host=gall-mite] 17786 [host=potato-beetle] 17783 [host=fire-frog] 17781 [host=bush-cricket] 17780 [host=earwig] 17778 [host=lake-frog] 17776 [host=leaf-beetle] 17774 [host=moss-bug] 17752 [host=fire-frog] 17740 [host=gall-mite] 17726 ok.
> Failure / basis pass flights: 17816 / 17726
> Tree: linux git://xenbits.xen.org/linux-pvops.git
> Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
> Tree: qemu git://xenbits.xen.org/staging/qemu-xen-unstable.git
> Tree: qemuu git://xenbits.xen.org/staging/qemu-upstream-unstable.git
> Tree: xen git://xenbits.xen.org/xen.git
> Latest a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b86eb6bb95e67d22185967657c97fb6a2f131198 e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44 66425df7ce61865f94506ba57b2ab47a2ba18e41
> Basis pass a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b86eb6bb95e67d22185967657c97fb6a2f131198 e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44 764012376a096a45bced88ee2ec1a6c17c6c22c7
> Generating revisions with ./adhoc-revtuple-generator git://xenbits.xen.org/linux-pvops.git#a938a246d34912423c560f475ccf1ce0c71d9d00-a938a246d34912423c560f475ccf1ce0c71d9d00 git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/staging/qemu-xen-unstable.git#b86eb6bb95e67d22185967657c97fb6a2f131198-b86eb6bb95e67d22185967657c97fb6a2f131198 git://xenbits.xen.org/staging/qemu-upstream-unstable.git#e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44-e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44 git://xenbits.xen.org/xen.git#764012376a096a45bced88ee2ec1a6c17c6c22c7-66425df7ce61865f94506ba57b2ab47a2ba18e41
> using cache /export/home/osstest/repos/git-cache...
> using cache /export/home/osstest/repos/git-cache...
> locked cache /export/home/osstest/repos/git-cache...
> processing ./cacheing-git clone --bare git://xenbits.xen.org/xen.git /export/home/osstest/repos/xen...
> Initialized empty Git repository in /export/home/osstest/repos/xen/
> updating cache /export/home/osstest/repos/git-cache xen...
> using cache /export/home/osstest/repos/git-cache...
> using cache /export/home/osstest/repos/git-cache...
> locked cache /export/home/osstest/repos/git-cache...
> processing ./cacheing-git clone --bare git://xenbits.xen.org/xen.git /export/home/osstest/repos/xen...
> Initialized empty Git repository in /export/home/osstest/repos/xen/
> updating cache /export/home/osstest/repos/git-cache xen...
> Loaded 1001 nodes in revision graph
> Searching for test results:
> 17719 [host=woodlouse]
> 17726 pass a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b86eb6bb95e67d22185967657c97fb6a2f131198 e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44 764012376a096a45bced88ee2ec1a6c17c6c22c7
> 17740 [host=gall-mite]
> 17752 [host=fire-frog]
> 17793 fail a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b86eb6bb95e67d22185967657c97fb6a2f131198 e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44 66425df7ce61865f94506ba57b2ab47a2ba18e41
> 17774 [host=moss-bug]
> 17776 [host=leaf-beetle]
> 17801 pass a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b86eb6bb95e67d22185967657c97fb6a2f131198 e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44 764012376a096a45bced88ee2ec1a6c17c6c22c7
> 17820 pass a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b86eb6bb95e67d22185967657c97fb6a2f131198 e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44 3051bdedc3ef82eb5f14978823dec00784d69d0e
> 17778 [host=lake-frog]
> 17802 fail a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b86eb6bb95e67d22185967657c97fb6a2f131198 e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44 66425df7ce61865f94506ba57b2ab47a2ba18e41
> 17780 [host=earwig]
> 17816 fail a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b86eb6bb95e67d22185967657c97fb6a2f131198 e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44 66425df7ce61865f94506ba57b2ab47a2ba18e41
> 17781 [host=bush-cricket]
> 17803 pass a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b86eb6bb95e67d22185967657c97fb6a2f131198 e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44 beb0975bcfd49d0ddd89267af8860c520d2db251
> 17805 pass a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b86eb6bb95e67d22185967657c97fb6a2f131198 e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44 6e96c186d23873597896051b043cfeb119c4a7d5
> 17821 fail a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b86eb6bb95e67d22185967657c97fb6a2f131198 e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44 a8a1f236a2964506a22d1779648d8e1c8668cb1a
> 17783 [host=fire-frog]
> 17806 fail a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b86eb6bb95e67d22185967657c97fb6a2f131198 e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44 b4feab57f0e740df7f04cf71b334a5bdd5d52fbc
> 17800 fail a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b86eb6bb95e67d22185967657c97fb6a2f131198 e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44 66425df7ce61865f94506ba57b2ab47a2ba18e41
> 17823 pass a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b86eb6bb95e67d22185967657c97fb6a2f131198 e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44 3051bdedc3ef82eb5f14978823dec00784d69d0e
> 17786 [host=potato-beetle]
> 17807 fail a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b86eb6bb95e67d22185967657c97fb6a2f131198 e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44 d6d33360662d87d3e456e4618a3eafd38db5b09c
> 17791 [host=gall-mite]
> 17792 fail a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b86eb6bb95e67d22185967657c97fb6a2f131198 e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44 66425df7ce61865f94506ba57b2ab47a2ba18e41
> 17824 fail a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b86eb6bb95e67d22185967657c97fb6a2f131198 e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44 a8a1f236a2964506a22d1779648d8e1c8668cb1a
> 17826 pass a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b86eb6bb95e67d22185967657c97fb6a2f131198 e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44 3051bdedc3ef82eb5f14978823dec00784d69d0e
> 17827 fail a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b86eb6bb95e67d22185967657c97fb6a2f131198 e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44 a8a1f236a2964506a22d1779648d8e1c8668cb1a
> 17808 fail a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b86eb6bb95e67d22185967657c97fb6a2f131198 e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44 66425df7ce61865f94506ba57b2ab47a2ba18e41
> Searching for interesting versions
> Result found: flight 17726 (pass), for basis pass
> Result found: flight 17792 (fail), for basis failure
> Repro found: flight 17801 (pass), for basis pass
> Repro found: flight 17802 (fail), for basis failure
> 0 revisions at a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b86eb6bb95e67d22185967657c97fb6a2f131198 e2155ddd22fe4378030cbbdbbb089a6fa2f3ad44 3051bdedc3ef82eb5f14978823dec00784d69d0e
> No revisions left to test, checking graph state.
> Result found: flight 17820 (pass), for last pass
> Result found: flight 17821 (fail), for first failure
> Repro found: flight 17823 (pass), for last pass
> Repro found: flight 17824 (fail), for first failure
> Repro found: flight 17826 (pass), for last pass
> Repro found: flight 17827 (fail), for first failure
>
> *** Found and reproduced problem changeset ***
>
> Bug is in tree: xen git://xenbits.xen.org/xen.git
> Bug introduced: a8a1f236a2964506a22d1779648d8e1c8668cb1a
> Bug not present: 3051bdedc3ef82eb5f14978823dec00784d69d0e
>
> using cache /export/home/osstest/repos/git-cache...
> using cache /export/home/osstest/repos/git-cache...
> locked cache /export/home/osstest/repos/git-cache...
> processing ./cacheing-git clone --bare git://xenbits.xen.org/xen.git /export/home/osstest/repos/xen...
> Initialized empty Git repository in /export/home/osstest/repos/xen/
> updating cache /export/home/osstest/repos/git-cache xen...
>
> Revision graph left in /home/xc_osstest/results/bisect.xen-unstable.test-amd64-amd64-xl.guest-stop.{dot,ps,png,html}.
> ----------------------------------------
> 17827: tolerable ALL FAIL
>
> flight 17827 xen-unstable real-bisect [real]
> http://www.chiark.greenend.org.uk/~xensrcts/logs/17827/
>
> Failures :-/ but no regressions.
>
> Tests which did not succeed,
> including tests which could not be run:
> test-amd64-amd64-xl 15 guest-stop fail baseline untested
>
>
> jobs:
> test-amd64-amd64-xl fail
>
>
> ------------------------------------------------------------
> sg-report-flight on woking.cam.xci-test.com
> logs: /home/xc_osstest/logs
> images: /home/xc_osstest/images
>
> Logs, config files, etc. are available at
> http://www.chiark.greenend.org.uk/~xensrcts/logs
>
> Test harness code can be found at
> http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [xen-unstable bisection] complete test-amd64-amd64-xl
2013-04-26 11:26 ` Ian Campbell
@ 2013-05-01 15:33 ` Ian Jackson
0 siblings, 0 replies; 8+ messages in thread
From: Ian Jackson @ 2013-05-01 15:33 UTC (permalink / raw)
To: Ian Campbell
Cc: xen-devel@lists.xensource.com, Keir (Xen.org), Dave Scott,
Stefano Stabellini
Ian Campbell writes ("Re: [Xen-devel] [xen-unstable bisection] complete test-amd64-amd64-xl"):
> Did this not used to include the relevant changlog entry?
Yes. It is supposed to. I will investigate. I think the change to
git may be related.
Ian.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [xen-unstable bisection] complete test-amd64-amd64-xl
@ 2013-07-21 11:31 xen.org
0 siblings, 0 replies; 8+ messages in thread
From: xen.org @ 2013-07-21 11:31 UTC (permalink / raw)
To: xen-devel; +Cc: ian.jackson, keir, stefano.stabellini
branch xen-unstable
xen branch xen-unstable
job test-amd64-amd64-xl
test xen-install
Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: qemu git://xenbits.xen.org/staging/qemu-xen-unstable.git
Tree: qemuu git://xenbits.xen.org/staging/qemu-upstream-unstable.git
Tree: xen git://xenbits.xen.org/xen.git
*** Found and reproduced problem changeset ***
Bug is in tree: xen git://xenbits.xen.org/xen.git
Bug introduced: 524b93def23b9f75fd7851063f5291886e63d1ed
Bug not present: 09a08ef52a21d171cc48b54a975f13e7704c912f
commit 524b93def23b9f75fd7851063f5291886e63d1ed
Author: Ian Campbell <ian.campbell@citrix.com>
Date: Thu Jul 18 09:41:41 2013 +0100
xen: x86: drop the ".gz" suffix when installing
As Jan says it is pretty meaningless under /boot anyway. However I am slightly
concerned about breaking bootloaders (or more specifically their help scripts
which automatically generate config files). By inspection at least grub 2's
update-grub script (as present in Debian Wheezy) seems to cope (it matches on
xen* not xen*.gz)
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Keir Fraser <keir@xen.org>
Acked-by: Julien Grall <julien.grall@linaro.org>
Acked-by: Jan Beulich <jbeulich@suse.com>
For bisection revision-tuple graph see:
http://www.chiark.greenend.org.uk/~xensrcts/results/bisect.xen-unstable.test-amd64-amd64-xl.xen-install.html
Revision IDs in each graph node refer, respectively, to the Trees above.
----------------------------------------
Searching for failure / basis pass:
18558 fail [host=field-cricket] / 18485 [host=leaf-beetle] 18484 [host=bush-cricket] 18466 [host=earwig] 18454 [host=lake-frog] 18438 [host=lace-bug] 18431 [host=itch-mite] 18430 [host=fire-frog] 18428 [host=gall-mite] 18426 [host=woodlouse] 18423 [host=moss-bug] 18422 [host=potato-beetle] 18421 [host=leaf-beetle] 18419 [host=earwig] 18418 [host=bush-cricket] 18417 ok.
Failure / basis pass flights: 18558 / 18417
Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: qemu git://xenbits.xen.org/staging/qemu-xen-unstable.git
Tree: qemuu git://xenbits.xen.org/staging/qemu-upstream-unstable.git
Tree: xen git://xenbits.xen.org/xen.git
Latest a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 13c144d96e825f145e5b37f97e5f6210c2c645e9 7483e7f15139603380c45ebcd8cc2a57dda5583c 2a6327bf2bfaf5de5e07aed583d2c337c9d368c0
Basis pass a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 13c144d96e825f145e5b37f97e5f6210c2c645e9 7483e7f15139603380c45ebcd8cc2a57dda5583c 395f777ae0eed67b03596fe38d6d90f307ddd036
Generating revisions with ./adhoc-revtuple-generator git://xenbits.xen.org/linux-pvops.git#a938a246d34912423c560f475ccf1ce0c71d9d00-a938a246d34912423c560f475ccf1ce0c71d9d00 git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/staging/qemu-xen-unstable.git#13c144d96e825f145e5b37f97e5f6210c2c645e9-13c144d96e825f145e5b37f97e5f6210c2c645e9 git://xenbits.xen.org/staging/qemu-upstream-unstable.git#7483e7f15139603380c45ebcd8cc2a57dda5583c-7483e7f15139603380c45ebcd8cc2a57dda5583c git://xenbits.xen.org/xen.git#395f777ae0eed67b03596fe38d6d90f307ddd036-2a6327bf2bfaf5de5e07aed583d2c337c9d368c0
using cache /export/home/osstest/repos/git-cache...
using cache /export/home/osstest/repos/git-cache...
locked cache /export/home/osstest/repos/git-cache...
processing ./cacheing-git clone --bare git://xenbits.xen.org/xen.git /export/home/osstest/repos/xen...
Initialized empty Git repository in /export/home/osstest/repos/xen/
updating cache /export/home/osstest/repos/git-cache xen...
using cache /export/home/osstest/repos/git-cache...
using cache /export/home/osstest/repos/git-cache...
locked cache /export/home/osstest/repos/git-cache...
processing ./cacheing-git clone --bare git://xenbits.xen.org/xen.git /export/home/osstest/repos/xen...
Initialized empty Git repository in /export/home/osstest/repos/xen/
updating cache /export/home/osstest/repos/git-cache xen...
Loaded 1001 nodes in revision graph
Searching for test results:
18419 [host=earwig]
18431 [host=itch-mite]
18421 [host=leaf-beetle]
18422 [host=potato-beetle]
18423 [host=moss-bug]
18410 [host=itch-mite]
18433 []
18414 [host=fire-frog]
18417 pass a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 13c144d96e825f145e5b37f97e5f6210c2c645e9 7483e7f15139603380c45ebcd8cc2a57dda5583c 395f777ae0eed67b03596fe38d6d90f307ddd036
18418 [host=bush-cricket]
18426 [host=woodlouse]
18428 [host=gall-mite]
18430 [host=fire-frog]
18466 [host=earwig]
18438 [host=lace-bug]
18454 [host=lake-frog]
18528 fail a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 13c144d96e825f145e5b37f97e5f6210c2c645e9 7483e7f15139603380c45ebcd8cc2a57dda5583c 2a6327bf2bfaf5de5e07aed583d2c337c9d368c0
18479 []
18480 []
18559 pass a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 13c144d96e825f145e5b37f97e5f6210c2c645e9 7483e7f15139603380c45ebcd8cc2a57dda5583c 09a08ef52a21d171cc48b54a975f13e7704c912f
18483 []
18496 fail a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 13c144d96e825f145e5b37f97e5f6210c2c645e9 7483e7f15139603380c45ebcd8cc2a57dda5583c 2a6327bf2bfaf5de5e07aed583d2c337c9d368c0
18484 [host=bush-cricket]
18485 [host=leaf-beetle]
18491 fail a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 13c144d96e825f145e5b37f97e5f6210c2c645e9 7483e7f15139603380c45ebcd8cc2a57dda5583c 2a6327bf2bfaf5de5e07aed583d2c337c9d368c0
18519 fail a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 13c144d96e825f145e5b37f97e5f6210c2c645e9 7483e7f15139603380c45ebcd8cc2a57dda5583c 2a6327bf2bfaf5de5e07aed583d2c337c9d368c0
18538 pass a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 13c144d96e825f145e5b37f97e5f6210c2c645e9 7483e7f15139603380c45ebcd8cc2a57dda5583c 395f777ae0eed67b03596fe38d6d90f307ddd036
18539 fail a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 13c144d96e825f145e5b37f97e5f6210c2c645e9 7483e7f15139603380c45ebcd8cc2a57dda5583c 2a6327bf2bfaf5de5e07aed583d2c337c9d368c0
18540 pass a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 13c144d96e825f145e5b37f97e5f6210c2c645e9 7483e7f15139603380c45ebcd8cc2a57dda5583c 4d1759b5153ce5b0903e56fefcfdca8a03b7c246
18543 fail a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 13c144d96e825f145e5b37f97e5f6210c2c645e9 7483e7f15139603380c45ebcd8cc2a57dda5583c 2a6327bf2bfaf5de5e07aed583d2c337c9d368c0
18541 pass a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 13c144d96e825f145e5b37f97e5f6210c2c645e9 7483e7f15139603380c45ebcd8cc2a57dda5583c 3eb214917f45e567af87605c06c28cea4208faf4
18537 fail a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 13c144d96e825f145e5b37f97e5f6210c2c645e9 7483e7f15139603380c45ebcd8cc2a57dda5583c 2a6327bf2bfaf5de5e07aed583d2c337c9d368c0
18542 blocked a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 13c144d96e825f145e5b37f97e5f6210c2c645e9 7483e7f15139603380c45ebcd8cc2a57dda5583c 23e37f599e8bc220aca9abd097171ee17f5630ab
18558 fail a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 13c144d96e825f145e5b37f97e5f6210c2c645e9 7483e7f15139603380c45ebcd8cc2a57dda5583c 2a6327bf2bfaf5de5e07aed583d2c337c9d368c0
18551 fail a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 13c144d96e825f145e5b37f97e5f6210c2c645e9 7483e7f15139603380c45ebcd8cc2a57dda5583c 2a6327bf2bfaf5de5e07aed583d2c337c9d368c0
18560 fail a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 13c144d96e825f145e5b37f97e5f6210c2c645e9 7483e7f15139603380c45ebcd8cc2a57dda5583c 524b93def23b9f75fd7851063f5291886e63d1ed
18557 fail a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 13c144d96e825f145e5b37f97e5f6210c2c645e9 7483e7f15139603380c45ebcd8cc2a57dda5583c 47d1a51480ad0f602d747e460d619436c907deea
18564 pass a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 13c144d96e825f145e5b37f97e5f6210c2c645e9 7483e7f15139603380c45ebcd8cc2a57dda5583c 09a08ef52a21d171cc48b54a975f13e7704c912f
18562 pass a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 13c144d96e825f145e5b37f97e5f6210c2c645e9 7483e7f15139603380c45ebcd8cc2a57dda5583c 09a08ef52a21d171cc48b54a975f13e7704c912f
18563 fail a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 13c144d96e825f145e5b37f97e5f6210c2c645e9 7483e7f15139603380c45ebcd8cc2a57dda5583c 524b93def23b9f75fd7851063f5291886e63d1ed
18566 fail a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 13c144d96e825f145e5b37f97e5f6210c2c645e9 7483e7f15139603380c45ebcd8cc2a57dda5583c 524b93def23b9f75fd7851063f5291886e63d1ed
Searching for interesting versions
Result found: flight 18417 (pass), for basis pass
Result found: flight 18491 (fail), for basis failure
Repro found: flight 18538 (pass), for basis pass
Repro found: flight 18539 (fail), for basis failure
0 revisions at a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 13c144d96e825f145e5b37f97e5f6210c2c645e9 7483e7f15139603380c45ebcd8cc2a57dda5583c 09a08ef52a21d171cc48b54a975f13e7704c912f
No revisions left to test, checking graph state.
Result found: flight 18559 (pass), for last pass
Result found: flight 18560 (fail), for first failure
Repro found: flight 18562 (pass), for last pass
Repro found: flight 18563 (fail), for first failure
Repro found: flight 18564 (pass), for last pass
Repro found: flight 18566 (fail), for first failure
*** Found and reproduced problem changeset ***
Bug is in tree: xen git://xenbits.xen.org/xen.git
Bug introduced: 524b93def23b9f75fd7851063f5291886e63d1ed
Bug not present: 09a08ef52a21d171cc48b54a975f13e7704c912f
using cache /export/home/osstest/repos/git-cache...
using cache /export/home/osstest/repos/git-cache...
locked cache /export/home/osstest/repos/git-cache...
processing ./cacheing-git clone --bare git://xenbits.xen.org/xen.git /export/home/osstest/repos/xen...
Initialized empty Git repository in /export/home/osstest/repos/xen/
updating cache /export/home/osstest/repos/git-cache xen...
commit 524b93def23b9f75fd7851063f5291886e63d1ed
Author: Ian Campbell <ian.campbell@citrix.com>
Date: Thu Jul 18 09:41:41 2013 +0100
xen: x86: drop the ".gz" suffix when installing
As Jan says it is pretty meaningless under /boot anyway. However I am slightly
concerned about breaking bootloaders (or more specifically their help scripts
which automatically generate config files). By inspection at least grub 2's
update-grub script (as present in Debian Wheezy) seems to cope (it matches on
xen* not xen*.gz)
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Keir Fraser <keir@xen.org>
Acked-by: Julien Grall <julien.grall@linaro.org>
Acked-by: Jan Beulich <jbeulich@suse.com>
Revision graph left in /home/xc_osstest/results/bisect.xen-unstable.test-amd64-amd64-xl.xen-install.{dot,ps,png,html}.
----------------------------------------
18566: tolerable ALL FAIL
flight 18566 xen-unstable real-bisect [real]
http://www.chiark.greenend.org.uk/~xensrcts/logs/18566/
Failures :-/ but no regressions.
Tests which did not succeed,
including tests which could not be run:
test-amd64-amd64-xl 4 xen-install fail baseline untested
jobs:
test-amd64-amd64-xl fail
------------------------------------------------------------
sg-report-flight on woking.cam.xci-test.com
logs: /home/xc_osstest/logs
images: /home/xc_osstest/images
Logs, config files, etc. are available at
http://www.chiark.greenend.org.uk/~xensrcts/logs
Test harness code can be found at
http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary
^ permalink raw reply [flat|nested] 8+ messages in thread* [xen-unstable bisection] complete test-amd64-amd64-xl
@ 2013-08-28 21:15 xen.org
0 siblings, 0 replies; 8+ messages in thread
From: xen.org @ 2013-08-28 21:15 UTC (permalink / raw)
To: xen-devel; +Cc: ian.jackson, keir, stefano.stabellini
branch xen-unstable
xen branch xen-unstable
job test-amd64-amd64-xl
test xen-boot
Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: qemu git://xenbits.xen.org/staging/qemu-xen-unstable.git
Tree: qemuu git://xenbits.xen.org/staging/qemu-upstream-unstable.git
Tree: xen git://xenbits.xen.org/xen.git
*** Found and reproduced problem changeset ***
Bug is in tree: xen git://xenbits.xen.org/xen.git
Bug introduced: d838ac2539cf1987bea6e15662fd6a80a58fe26d
Bug not present: 850188e1278cecd1dfb9b936024bee2d8dfdcc18
commit d838ac2539cf1987bea6e15662fd6a80a58fe26d
Author: Jan Beulich <jbeulich@suse.com>
Date: Tue Aug 27 11:12:12 2013 +0200
x86: don't allow Dom0 access to the HT address range
In particular, MMIO assignments should not be done using this area.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
For bisection revision-tuple graph see:
http://www.chiark.greenend.org.uk/~xensrcts/results/bisect.xen-unstable.test-amd64-amd64-xl.xen-boot.html
Revision IDs in each graph node refer, respectively, to the Trees above.
----------------------------------------
Searching for failure / basis pass:
18780 fail [host=fire-frog] / 18778 [host=leaf-beetle] 18773 [host=field-cricket] 18770 [host=bush-cricket] 18767 [host=earwig] 18765 [host=lake-frog] 18763 [host=itch-mite] 18762 [host=potato-beetle] 18758 [host=gall-mite] 18753 [host=moss-bug] 18750 ok.
Failure / basis pass flights: 18780 / 18750
Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: qemu git://xenbits.xen.org/staging/qemu-xen-unstable.git
Tree: qemuu git://xenbits.xen.org/staging/qemu-upstream-unstable.git
Tree: xen git://xenbits.xen.org/xen.git
Latest a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 84411871262363200e70fa087d7b21647091a450 7483e7f15139603380c45ebcd8cc2a57dda5583c 44db24103ff1c53a13afebf4d72ad853cee07786
Basis pass a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 84411871262363200e70fa087d7b21647091a450 7483e7f15139603380c45ebcd8cc2a57dda5583c 69962e19ed432570f6cdcfdb5f6f22d6e3c54e6c
Generating revisions with ./adhoc-revtuple-generator git://xenbits.xen.org/linux-pvops.git#a938a246d34912423c560f475ccf1ce0c71d9d00-a938a246d34912423c560f475ccf1ce0c71d9d00 git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/staging/qemu-xen-unstable.git#84411871262363200e70fa087d7b21647091a450-84411871262363200e70fa087d7b21647091a450 git://xenbits.xen.org/staging/qemu-upstream-unstable.git#7483e7f15139603380c45ebcd8cc2a57dda5583c-7483e7f15139603380c45ebcd8cc2a57dda5583c git://xenbits.xen.org/xen.git#69962e19ed432570f6cdcfdb5f6f22d6e3c54e6c-44db24103ff1c53a13afebf4d72ad853cee07786
using cache /export/home/osstest/repos/git-cache...
using cache /export/home/osstest/repos/git-cache...
locked cache /export/home/osstest/repos/git-cache...
processing ./cacheing-git clone --bare git://xenbits.xen.org/xen.git /export/home/osstest/repos/xen...
Initialized empty Git repository in /export/home/osstest/repos/xen/
updating cache /export/home/osstest/repos/git-cache xen...
using cache /export/home/osstest/repos/git-cache...
using cache /export/home/osstest/repos/git-cache...
locked cache /export/home/osstest/repos/git-cache...
processing ./cacheing-git clone --bare git://xenbits.xen.org/xen.git /export/home/osstest/repos/xen...
Initialized empty Git repository in /export/home/osstest/repos/xen/
updating cache /export/home/osstest/repos/git-cache xen...
Loaded 1001 nodes in revision graph
Searching for test results:
18753 [host=moss-bug]
18770 [host=bush-cricket]
18758 [host=gall-mite]
18750 pass a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 84411871262363200e70fa087d7b21647091a450 7483e7f15139603380c45ebcd8cc2a57dda5583c 69962e19ed432570f6cdcfdb5f6f22d6e3c54e6c
18762 [host=potato-beetle]
18763 [host=itch-mite]
18780 fail a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 84411871262363200e70fa087d7b21647091a450 7483e7f15139603380c45ebcd8cc2a57dda5583c 44db24103ff1c53a13afebf4d72ad853cee07786
18765 [host=lake-frog]
18767 [host=earwig]
18773 [host=field-cricket]
18778 [host=leaf-beetle]
18800 pass a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 84411871262363200e70fa087d7b21647091a450 7483e7f15139603380c45ebcd8cc2a57dda5583c 69962e19ed432570f6cdcfdb5f6f22d6e3c54e6c
18804 fail a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 84411871262363200e70fa087d7b21647091a450 7483e7f15139603380c45ebcd8cc2a57dda5583c 44db24103ff1c53a13afebf4d72ad853cee07786
18810 pass a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 84411871262363200e70fa087d7b21647091a450 7483e7f15139603380c45ebcd8cc2a57dda5583c 3829655bd3ad2b1150bd94955fc6988dec6b98f2
18814 pass a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 84411871262363200e70fa087d7b21647091a450 7483e7f15139603380c45ebcd8cc2a57dda5583c 850188e1278cecd1dfb9b936024bee2d8dfdcc18
18817 fail a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 84411871262363200e70fa087d7b21647091a450 7483e7f15139603380c45ebcd8cc2a57dda5583c 3e787021fb2420851c7bdc3911ea53c728ba5ac0
18819 fail a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 84411871262363200e70fa087d7b21647091a450 7483e7f15139603380c45ebcd8cc2a57dda5583c d838ac2539cf1987bea6e15662fd6a80a58fe26d
18822 pass a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 84411871262363200e70fa087d7b21647091a450 7483e7f15139603380c45ebcd8cc2a57dda5583c 850188e1278cecd1dfb9b936024bee2d8dfdcc18
18823 fail a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 84411871262363200e70fa087d7b21647091a450 7483e7f15139603380c45ebcd8cc2a57dda5583c d838ac2539cf1987bea6e15662fd6a80a58fe26d
18824 pass a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 84411871262363200e70fa087d7b21647091a450 7483e7f15139603380c45ebcd8cc2a57dda5583c 850188e1278cecd1dfb9b936024bee2d8dfdcc18
18825 fail a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 84411871262363200e70fa087d7b21647091a450 7483e7f15139603380c45ebcd8cc2a57dda5583c d838ac2539cf1987bea6e15662fd6a80a58fe26d
Searching for interesting versions
Result found: flight 18750 (pass), for basis pass
Result found: flight 18780 (fail), for basis failure
Repro found: flight 18800 (pass), for basis pass
Repro found: flight 18804 (fail), for basis failure
0 revisions at a938a246d34912423c560f475ccf1ce0c71d9d00 c530a75c1e6a472b0eb9558310b518f0dfcd8860 84411871262363200e70fa087d7b21647091a450 7483e7f15139603380c45ebcd8cc2a57dda5583c 850188e1278cecd1dfb9b936024bee2d8dfdcc18
No revisions left to test, checking graph state.
Result found: flight 18814 (pass), for last pass
Result found: flight 18819 (fail), for first failure
Repro found: flight 18822 (pass), for last pass
Repro found: flight 18823 (fail), for first failure
Repro found: flight 18824 (pass), for last pass
Repro found: flight 18825 (fail), for first failure
*** Found and reproduced problem changeset ***
Bug is in tree: xen git://xenbits.xen.org/xen.git
Bug introduced: d838ac2539cf1987bea6e15662fd6a80a58fe26d
Bug not present: 850188e1278cecd1dfb9b936024bee2d8dfdcc18
using cache /export/home/osstest/repos/git-cache...
using cache /export/home/osstest/repos/git-cache...
locked cache /export/home/osstest/repos/git-cache...
processing ./cacheing-git clone --bare git://xenbits.xen.org/xen.git /export/home/osstest/repos/xen...
Initialized empty Git repository in /export/home/osstest/repos/xen/
updating cache /export/home/osstest/repos/git-cache xen...
commit d838ac2539cf1987bea6e15662fd6a80a58fe26d
Author: Jan Beulich <jbeulich@suse.com>
Date: Tue Aug 27 11:12:12 2013 +0200
x86: don't allow Dom0 access to the HT address range
In particular, MMIO assignments should not be done using this area.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Revision graph left in /home/xc_osstest/results/bisect.xen-unstable.test-amd64-amd64-xl.xen-boot.{dot,ps,png,html}.
----------------------------------------
18825: tolerable ALL FAIL
flight 18825 xen-unstable real-bisect [real]
http://www.chiark.greenend.org.uk/~xensrcts/logs/18825/
Failures :-/ but no regressions.
Tests which did not succeed,
including tests which could not be run:
test-amd64-amd64-xl 5 xen-boot fail baseline untested
jobs:
test-amd64-amd64-xl fail
------------------------------------------------------------
sg-report-flight on woking.cam.xci-test.com
logs: /home/xc_osstest/logs
images: /home/xc_osstest/images
Logs, config files, etc. are available at
http://www.chiark.greenend.org.uk/~xensrcts/logs
Test harness code can be found at
http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary
^ permalink raw reply [flat|nested] 8+ messages in thread* [xen-unstable bisection] complete test-amd64-amd64-xl
@ 2015-03-30 8:36 xen.org
0 siblings, 0 replies; 8+ messages in thread
From: xen.org @ 2015-03-30 8:36 UTC (permalink / raw)
To: xen-devel; +Cc: ian.jackson, keir, stefano.stabellini
branch xen-unstable
xen branch xen-unstable
job test-amd64-amd64-xl
test guest-localmigrate
Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: qemu git://xenbits.xen.org/staging/qemu-xen-unstable.git
Tree: qemuu git://xenbits.xen.org/staging/qemu-upstream-unstable.git
Tree: xen git://xenbits.xen.org/xen.git
*** Found and reproduced problem changeset ***
Bug is in tree: xen git://xenbits.xen.org/xen.git
Bug introduced: d639e6a05a0f8ee0e61c6cc4eebba78934ef3648
Bug not present: 88a2372c6ba44dd42b915a95a823cf9d4d260e25
commit d639e6a05a0f8ee0e61c6cc4eebba78934ef3648
Author: Jan Beulich <jbeulich@suse.com>
Date: Mon Mar 23 16:51:14 2015 +0100
x86: allow 64-bit PV guest kernels to suppress user mode exposure of M2P
Xen L4 entries being uniformly installed into any L4 table and 64-bit
PV kernels running in ring 3 means that user mode was able to see the
read-only M2P presented by Xen to the guests. While apparently not
really representing an exploitable information leak, this still very
certainly was never meant to be that way.
Building on the fact that these guests already have separate kernel and
user mode page tables we can allow guest kernels to tell Xen that they
don't want user mode to see this table. We can't, however, do this by
default: There is no ABI requirement that kernel and user mode page
tables be separate. Therefore introduce a new VM-assist flag allowing
the guest to control respective hypervisor behavior:
- when not set, L4 tables get created with the respective slot blank,
and whenever the L4 table gets used as a kernel one the missing
mapping gets inserted,
- when set, L4 tables get created with the respective slot initialized
as before, and whenever the L4 table gets used as a user one the
mapping gets zapped.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Tim Deegan <tim@xen.org>
For bisection revision-tuple graph see:
http://www.chiark.greenend.org.uk/~xensrcts/results/bisect.xen-unstable.test-amd64-amd64-xl.guest-localmigrate.html
Revision IDs in each graph node refer, respectively, to the Trees above.
----------------------------------------
Searching for failure / basis pass:
36772 fail [host=grain-weevil] / 36622 [host=rice-weevil] 36540 [host=moss-bug] 36514 [host=gall-mite] 35957 [host=scape-moth] 35887 [host=fire-frog] 35810 [host=rice-weevil] 35556 [host=lace-bug] 35257 [host=lake-frog] 34715 [host=leaf-beetle] 34629 [host=scape-moth] 34574 [host=lake-frog] 34529 [host=fire-frog] 34484 [host=rice-weevil] 34426 [host=gall-mite] 34341 [host=field-cricket] 34257 [host=bush-cricket] 34181 [host=lake-frog] 34137 ok.
Failure / basis pass flights: 36772 / 34137
(tree with no url: ovmf)
(tree with no url: seabios)
Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
Tree: qemu git://xenbits.xen.org/staging/qemu-xen-unstable.git
Tree: qemuu git://xenbits.xen.org/staging/qemu-upstream-unstable.git
Tree: xen git://xenbits.xen.org/xen.git
Latest 8a5f782c33c04ea5c9b3ca6fb32d6039e2e5c0c9 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a4b276b4ce49c8d70dd841ff885b900ec652b994 42ffdf360dd9df66b0a4a7ada059c02a3cf3a8de 84066dd4ef4bb5983e246c629a26ef4f3394e5d5
Basis pass c3b70f0bbb6a883f4afa639286043d3f71fbbddf c530a75c1e6a472b0eb9558310b518f0dfcd8860 a4b276b4ce49c8d70dd841ff885b900ec652b994 0d37748342e29854db7c9f6c47d7f58c6cfba6b2 a1b4af132077de694054d757fea4573d482c8b3a
Generating revisions with ./adhoc-revtuple-generator git://xenbits.xen.org/linux-pvops.git#c3b70f0bbb6a883f4afa639286043d3f71fbbddf-8a5f782c33c04ea5c9b3ca6fb32d6039e2e5c0c9 git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/staging/qemu-xen-unstable.git#a4b276b4ce49c8d70dd841ff885b900ec652b994-a4b276b4ce49c8d70dd841ff885b900ec652b994 git://xenbits.xen.org/staging/qemu-upstream-unstable.git#0d37748342e29854db7c9f6c47d7f58c6cfba6b2-42ffdf360dd9df66b0a4a7ada059c02a3cf3a8de git://xenbits.xen.org/xen.git#a1b4af132077de694054d757fea4573d482c8b3a-84066dd4ef4bb5983e246c629a26ef4f3394e5d5
+ exec
+ sh -xe
+ cd /export/home/osstest/repos/linux-pvops
+ git remote set-url origin git://drall.uk.xensource.com:9419/git://xenbits.xen.org/linux-pvops.git
+ git fetch -p origin +refs/heads/*:refs/remotes/origin/*
+ exec
+ sh -xe
+ cd /export/home/osstest/repos/qemu-upstream-unstable
+ git remote set-url origin git://drall.uk.xensource.com:9419/git://xenbits.xen.org/staging/qemu-upstream-unstable.git
+ git fetch -p origin +refs/heads/*:refs/remotes/origin/*
+ exec
+ sh -xe
+ cd /export/home/osstest/repos/xen
+ git remote set-url origin git://drall.uk.xensource.com:9419/git://xenbits.xen.org/xen.git
+ git fetch -p origin +refs/heads/*:refs/remotes/origin/*
+ exec
+ sh -xe
+ cd /export/home/osstest/repos/linux-pvops
+ git remote set-url origin git://drall.uk.xensource.com:9419/git://xenbits.xen.org/linux-pvops.git
+ git fetch -p origin +refs/heads/*:refs/remotes/origin/*
+ exec
+ sh -xe
+ cd /export/home/osstest/repos/qemu-upstream-unstable
+ git remote set-url origin git://drall.uk.xensource.com:9419/git://xenbits.xen.org/staging/qemu-upstream-unstable.git
+ git fetch -p origin +refs/heads/*:refs/remotes/origin/*
+ exec
+ sh -xe
+ cd /export/home/osstest/repos/xen
+ git remote set-url origin git://drall.uk.xensource.com:9419/git://xenbits.xen.org/xen.git
+ git fetch -p origin +refs/heads/*:refs/remotes/origin/*
Loaded 10530 nodes in revision graph
Searching for test results:
34137 pass c3b70f0bbb6a883f4afa639286043d3f71fbbddf c530a75c1e6a472b0eb9558310b518f0dfcd8860 a4b276b4ce49c8d70dd841ff885b900ec652b994 0d37748342e29854db7c9f6c47d7f58c6cfba6b2 a1b4af132077de694054d757fea4573d482c8b3a
34257 [host=bush-cricket]
34181 [host=lake-frog]
34341 [host=field-cricket]
34426 [host=gall-mite]
34484 [host=rice-weevil]
34574 [host=lake-frog]
34529 [host=fire-frog]
34629 [host=scape-moth]
34715 [host=leaf-beetle]
35257 [host=lake-frog]
35556 [host=lace-bug]
35709 []
35758 []
35810 [host=rice-weevil]
35887 [host=fire-frog]
35957 [host=scape-moth]
36514 [host=gall-mite]
36540 [host=moss-bug]
36622 [host=rice-weevil]
36772 fail 8a5f782c33c04ea5c9b3ca6fb32d6039e2e5c0c9 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a4b276b4ce49c8d70dd841ff885b900ec652b994 42ffdf360dd9df66b0a4a7ada059c02a3cf3a8de 84066dd4ef4bb5983e246c629a26ef4f3394e5d5
36728 fail irrelevant
36875 pass 413cb08cebe9fd8107f556eee48b2d40773cacde c530a75c1e6a472b0eb9558310b518f0dfcd8860 a4b276b4ce49c8d70dd841ff885b900ec652b994 be11dc1e9172f91e798a8f831b30c14b479e08e8 27fa184b9c2faacb16dfd22773b5bfe9a35e740f
36856 pass c3b70f0bbb6a883f4afa639286043d3f71fbbddf c530a75c1e6a472b0eb9558310b518f0dfcd8860 a4b276b4ce49c8d70dd841ff885b900ec652b994 0d37748342e29854db7c9f6c47d7f58c6cfba6b2 a1b4af132077de694054d757fea4573d482c8b3a
36901 pass 8a5f782c33c04ea5c9b3ca6fb32d6039e2e5c0c9 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a4b276b4ce49c8d70dd841ff885b900ec652b994 42ffdf360dd9df66b0a4a7ada059c02a3cf3a8de 78d22f2dfcff39336ba0861f4bb5f8d0f380b7d4
36859 fail 8a5f782c33c04ea5c9b3ca6fb32d6039e2e5c0c9 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a4b276b4ce49c8d70dd841ff885b900ec652b994 42ffdf360dd9df66b0a4a7ada059c02a3cf3a8de 84066dd4ef4bb5983e246c629a26ef4f3394e5d5
36888 pass f563d4825241ad7c9fd8fd3538efece0607d5869 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a4b276b4ce49c8d70dd841ff885b900ec652b994 42ffdf360dd9df66b0a4a7ada059c02a3cf3a8de fe3cafd89ab7a9e171a4e8542b00f5f08c7b4f2f
36877 pass a74f1d1204a5c892466b52ac68ee6443c1e459d7 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a4b276b4ce49c8d70dd841ff885b900ec652b994 be11dc1e9172f91e798a8f831b30c14b479e08e8 4f3283fea384229366b6df101c6c0e008b35105b
36862 pass 8a5f782c33c04ea5c9b3ca6fb32d6039e2e5c0c9 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a4b276b4ce49c8d70dd841ff885b900ec652b994 42ffdf360dd9df66b0a4a7ada059c02a3cf3a8de 916735e1814d4d6df0d90b871b0666cdfaf134cd
36863 pass 8a5f782c33c04ea5c9b3ca6fb32d6039e2e5c0c9 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a4b276b4ce49c8d70dd841ff885b900ec652b994 42ffdf360dd9df66b0a4a7ada059c02a3cf3a8de 51f2224552cc1e6cb22b8b169999cd9711bc8cbc
36879 pass 413cb08cebe9fd8107f556eee48b2d40773cacde c530a75c1e6a472b0eb9558310b518f0dfcd8860 a4b276b4ce49c8d70dd841ff885b900ec652b994 be11dc1e9172f91e798a8f831b30c14b479e08e8 d568f5b668b19b8f257dc60eb3252b74bf70ec10
36865 pass 8a5f782c33c04ea5c9b3ca6fb32d6039e2e5c0c9 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a4b276b4ce49c8d70dd841ff885b900ec652b994 42ffdf360dd9df66b0a4a7ada059c02a3cf3a8de e32e9c76bcfc235cb29575c542709f327ba72cb4
36866 pass e8f616ae4f32159f77e60f73a4267b5806c418bd c530a75c1e6a472b0eb9558310b518f0dfcd8860 a4b276b4ce49c8d70dd841ff885b900ec652b994 42ffdf360dd9df66b0a4a7ada059c02a3cf3a8de 2bd6add4f5fa4ea2ba9297d6139e9dea42ea70a9
36881 pass b55e8b26547e1aed16b1a6d6a179f651747f8f29 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a4b276b4ce49c8d70dd841ff885b900ec652b994 be11dc1e9172f91e798a8f831b30c14b479e08e8 56c002976f18dc0ff1a43bb14a339096c977a9da
36869 pass e8f616ae4f32159f77e60f73a4267b5806c418bd c530a75c1e6a472b0eb9558310b518f0dfcd8860 a4b276b4ce49c8d70dd841ff885b900ec652b994 42ffdf360dd9df66b0a4a7ada059c02a3cf3a8de cde92647ea4f5c487059a3c89f2e3f1aec9a42d3
36871 blocked e8f616ae4f32159f77e60f73a4267b5806c418bd c530a75c1e6a472b0eb9558310b518f0dfcd8860 a4b276b4ce49c8d70dd841ff885b900ec652b994 42ffdf360dd9df66b0a4a7ada059c02a3cf3a8de 879b181f38b0e4e3c7314de980289f4ecd1c5982
36902 pass 8a5f782c33c04ea5c9b3ca6fb32d6039e2e5c0c9 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a4b276b4ce49c8d70dd841ff885b900ec652b994 42ffdf360dd9df66b0a4a7ada059c02a3cf3a8de 88a2372c6ba44dd42b915a95a823cf9d4d260e25
36873 blocked e8f616ae4f32159f77e60f73a4267b5806c418bd c530a75c1e6a472b0eb9558310b518f0dfcd8860 a4b276b4ce49c8d70dd841ff885b900ec652b994 42ffdf360dd9df66b0a4a7ada059c02a3cf3a8de 72c7e0ffd15f48f346e1b740d074679d5207e5d1
36892 pass 8a5f782c33c04ea5c9b3ca6fb32d6039e2e5c0c9 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a4b276b4ce49c8d70dd841ff885b900ec652b994 42ffdf360dd9df66b0a4a7ada059c02a3cf3a8de 207fe9adc2e77b2a9684fc223d9441e915878245
36884 pass e8f616ae4f32159f77e60f73a4267b5806c418bd c530a75c1e6a472b0eb9558310b518f0dfcd8860 a4b276b4ce49c8d70dd841ff885b900ec652b994 42ffdf360dd9df66b0a4a7ada059c02a3cf3a8de daf525ab15e337fe09b4f2d95442ccd37bc51525
36909 fail 8a5f782c33c04ea5c9b3ca6fb32d6039e2e5c0c9 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a4b276b4ce49c8d70dd841ff885b900ec652b994 42ffdf360dd9df66b0a4a7ada059c02a3cf3a8de d639e6a05a0f8ee0e61c6cc4eebba78934ef3648
36886 pass a16f0642cca75fc126566fc70b8fe9fb4da870f1 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a4b276b4ce49c8d70dd841ff885b900ec652b994 42ffdf360dd9df66b0a4a7ada059c02a3cf3a8de fe3cafd89ab7a9e171a4e8542b00f5f08c7b4f2f
36896 fail 8a5f782c33c04ea5c9b3ca6fb32d6039e2e5c0c9 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a4b276b4ce49c8d70dd841ff885b900ec652b994 42ffdf360dd9df66b0a4a7ada059c02a3cf3a8de 289eea77b6d9d59ccdceca94c5033b0f094e9065
36911 pass 8a5f782c33c04ea5c9b3ca6fb32d6039e2e5c0c9 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a4b276b4ce49c8d70dd841ff885b900ec652b994 42ffdf360dd9df66b0a4a7ada059c02a3cf3a8de 88a2372c6ba44dd42b915a95a823cf9d4d260e25
36898 pass 8a5f782c33c04ea5c9b3ca6fb32d6039e2e5c0c9 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a4b276b4ce49c8d70dd841ff885b900ec652b994 42ffdf360dd9df66b0a4a7ada059c02a3cf3a8de 2090f14c5cbd659c3adebc8cd27d423fae8b6b54
36904 fail 8a5f782c33c04ea5c9b3ca6fb32d6039e2e5c0c9 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a4b276b4ce49c8d70dd841ff885b900ec652b994 42ffdf360dd9df66b0a4a7ada059c02a3cf3a8de d639e6a05a0f8ee0e61c6cc4eebba78934ef3648
36907 pass 8a5f782c33c04ea5c9b3ca6fb32d6039e2e5c0c9 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a4b276b4ce49c8d70dd841ff885b900ec652b994 42ffdf360dd9df66b0a4a7ada059c02a3cf3a8de 88a2372c6ba44dd42b915a95a823cf9d4d260e25
36912 fail 8a5f782c33c04ea5c9b3ca6fb32d6039e2e5c0c9 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a4b276b4ce49c8d70dd841ff885b900ec652b994 42ffdf360dd9df66b0a4a7ada059c02a3cf3a8de d639e6a05a0f8ee0e61c6cc4eebba78934ef3648
Searching for interesting versions
Result found: flight 34137 (pass), for basis pass
Result found: flight 36772 (fail), for basis failure
Repro found: flight 36856 (pass), for basis pass
Repro found: flight 36859 (fail), for basis failure
0 revisions at 8a5f782c33c04ea5c9b3ca6fb32d6039e2e5c0c9 c530a75c1e6a472b0eb9558310b518f0dfcd8860 a4b276b4ce49c8d70dd841ff885b900ec652b994 42ffdf360dd9df66b0a4a7ada059c02a3cf3a8de 88a2372c6ba44dd42b915a95a823cf9d4d260e25
No revisions left to test, checking graph state.
Result found: flight 36902 (pass), for last pass
Result found: flight 36904 (fail), for first failure
Repro found: flight 36907 (pass), for last pass
Repro found: flight 36909 (fail), for first failure
Repro found: flight 36911 (pass), for last pass
Repro found: flight 36912 (fail), for first failure
*** Found and reproduced problem changeset ***
Bug is in tree: xen git://xenbits.xen.org/xen.git
Bug introduced: d639e6a05a0f8ee0e61c6cc4eebba78934ef3648
Bug not present: 88a2372c6ba44dd42b915a95a823cf9d4d260e25
+ exec
+ sh -xe
+ cd /export/home/osstest/repos/xen
+ git remote set-url origin git://drall.uk.xensource.com:9419/git://xenbits.xen.org/xen.git
+ git fetch -p origin +refs/heads/*:refs/remotes/origin/*
commit d639e6a05a0f8ee0e61c6cc4eebba78934ef3648
Author: Jan Beulich <jbeulich@suse.com>
Date: Mon Mar 23 16:51:14 2015 +0100
x86: allow 64-bit PV guest kernels to suppress user mode exposure of M2P
Xen L4 entries being uniformly installed into any L4 table and 64-bit
PV kernels running in ring 3 means that user mode was able to see the
read-only M2P presented by Xen to the guests. While apparently not
really representing an exploitable information leak, this still very
certainly was never meant to be that way.
Building on the fact that these guests already have separate kernel and
user mode page tables we can allow guest kernels to tell Xen that they
don't want user mode to see this table. We can't, however, do this by
default: There is no ABI requirement that kernel and user mode page
tables be separate. Therefore introduce a new VM-assist flag allowing
the guest to control respective hypervisor behavior:
- when not set, L4 tables get created with the respective slot blank,
and whenever the L4 table gets used as a kernel one the missing
mapping gets inserted,
- when set, L4 tables get created with the respective slot initialized
as before, and whenever the L4 table gets used as a user one the
mapping gets zapped.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Tim Deegan <tim@xen.org>
dot: graph is too large for cairo-renderer bitmaps. Scaling by 0.696622 to fit
Revision graph left in /home/xc_osstest/results/bisect.xen-unstable.test-amd64-amd64-xl.guest-localmigrate.{dot,ps,png,html}.
----------------------------------------
36912: tolerable ALL FAIL
flight 36912 xen-unstable real-bisect [real]
http://www.chiark.greenend.org.uk/~xensrcts/logs/36912/
Failures :-/ but no regressions.
Tests which did not succeed,
including tests which could not be run:
test-amd64-amd64-xl 12 guest-localmigrate fail baseline untested
jobs:
test-amd64-amd64-xl fail
------------------------------------------------------------
sg-report-flight on osstest.cam.xci-test.com
logs: /home/xc_osstest/logs
images: /home/xc_osstest/images
Logs, config files, etc. are available at
http://www.chiark.greenend.org.uk/~xensrcts/logs
Test harness code can be found at
http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-03-30 8:36 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-12 20:36 [xen-unstable bisection] complete test-amd64-amd64-xl xen.org
2013-01-14 14:08 ` Wei Liu
2013-01-17 13:53 ` Ian Campbell
[not found] <E1UVggG-0008W0-B5@woking.cam.xci-test.com>
2013-04-26 11:26 ` Ian Campbell
2013-05-01 15:33 ` Ian Jackson
-- strict thread matches above, loose matches on Subject: below --
2013-07-21 11:31 xen.org
2013-08-28 21:15 xen.org
2015-03-30 8:36 xen.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).