From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
annie.li@oracle.com, msw@amazon.com
Subject: [PATCH] xen/grant-table: Force to use v1 of grants.
Date: Wed, 16 Jan 2013 16:22:49 -0500 [thread overview]
Message-ID: <1358371369-19089-1-git-send-email-konrad.wilk@oracle.com> (raw)
We have the framework to use v2, but there are no backends that
actually use it. The end result is that on PV we use v2 grants
and on PVHVM v1. The v1 has a capacity of 512 grants per page while
the v2 has 256 grants per page. This means we lose about 50%
capacity - and if we want more than 16 VIFs (each VIF takes
512 grants), then we are hitting the max per guest of 32.
Note: The hypervisor provides an over-ride for the default
of 32 frames (pages) per guest: gnttab_max_nr_frames=X
Oracle-bug: 16039922
CC: annie.li@oracle.com
CC: msw@amazon.com
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
drivers/xen/grant-table.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c
index 95ce9d0..568fd8f 100644
--- a/drivers/xen/grant-table.c
+++ b/drivers/xen/grant-table.c
@@ -1108,10 +1108,8 @@ static void gnttab_request_version(void)
int rc;
struct gnttab_set_version gsv;
- if (xen_hvm_domain())
- gsv.version = 1;
- else
- gsv.version = 2;
+ gsv.version = 1;
+
rc = HYPERVISOR_grant_table_op(GNTTABOP_set_version, &gsv, 1);
if (rc == 0 && gsv.version == 2) {
grant_table_version = 2;
--
1.8.0.2
next reply other threads:[~2013-01-16 21:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 21:22 Konrad Rzeszutek Wilk [this message]
2013-01-17 12:22 ` [PATCH] xen/grant-table: Force to use v1 of grants Matt Wilson
2013-01-17 13:05 ` [Xen-devel] " Jan Beulich
2013-01-18 2:32 ` konrad wilk
2013-01-17 13:12 ` Ian Campbell
2013-01-18 14:46 ` Konrad Rzeszutek Wilk
[not found] <1388502919-8601-1-git-send-email-konrad.wilk@oracle.com>
2013-12-31 15:15 ` Konrad Rzeszutek Wilk
[not found] ` <1388502919-8601-2-git-send-email-konrad.wilk@oracle.com>
2014-01-02 14:54 ` David Vrabel
[not found] ` <52C57D9A.8050804@citrix.com>
2014-01-02 19:17 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358371369-19089-1-git-send-email-konrad.wilk@oracle.com \
--to=konrad.wilk@oracle.com \
--cc=annie.li@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=msw@amazon.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).