From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: [PATCH 04/10] device-tree: get_val cannot cope with cells > 2, add early_panic Date: Fri, 18 Jan 2013 16:40:30 +0000 Message-ID: <1358527236-2486-4-git-send-email-ian.campbell@citrix.com> References: <1358526135.3279.103.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1358526135.3279.103.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org Cc: tim@xen.org, stefano.stabellini@citrix.com, Ian Campbell List-Id: xen-devel@lists.xenproject.org Signed-off-by: Ian Campbell Acked-by: Tim Deegan --- v3: early_panic instead of BUG_ON v2: drop unrelated white space fixup --- xen/common/device_tree.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c index 8b4ef2f..260c2d4 100644 --- a/xen/common/device_tree.c +++ b/xen/common/device_tree.c @@ -84,6 +84,9 @@ static void __init get_val(const u32 **cell, u32 cells, u64 *val) { *val = 0; + if ( cells > 2 ) + early_panic("dtb value contains > 2 cells\n"); + while ( cells-- ) { *val <<= 32; -- 1.7.9.1