From: Ian Campbell <ian.campbell@citrix.com>
To: xen-devel@lists.xen.org
Cc: tim@xen.org, stefano.stabellini@citrix.com,
Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH 09/10] xen: arm: parse modules from DT during early boot.
Date: Fri, 18 Jan 2013 16:40:35 +0000 [thread overview]
Message-ID: <1358527236-2486-9-git-send-email-ian.campbell@citrix.com> (raw)
In-Reply-To: <1358526135.3279.103.camel@zakaz.uk.xensource.com>
The bootloader should populate /chosen/modules/module@<N>/ for each
module it wishes to pass to the hypervisor. The content of these nodes
is described in docs/misc/arm/device-tree/booting.txt
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
v5: Moved later in the series
v4: Use /chosen/modules/module@N
Identify module type by compatible property not number.
v3: Use a reg = < > property for the module address/length.
v2: Reserve the zeroeth module for Xen itself (not used yet)
Use a more idiomatic DT layout
Document said layout
---
docs/misc/arm/device-tree/booting.txt | 25 ++++++++++
xen/common/device_tree.c | 86 +++++++++++++++++++++++++++++++++
2 files changed, 111 insertions(+), 0 deletions(-)
create mode 100644 docs/misc/arm/device-tree/booting.txt
diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt
new file mode 100644
index 0000000..94cd3f1
--- /dev/null
+++ b/docs/misc/arm/device-tree/booting.txt
@@ -0,0 +1,25 @@
+Xen is passed the dom0 kernel and initrd via a reference in the /chosen
+node of the device tree.
+
+Each node has the form /chosen/modules/module@<N> and contains the following
+properties:
+
+- compatible
+
+ Must be:
+
+ "xen,<type>", "xen,multiboot-module"
+
+ where <type> must be one of:
+
+ - "linux-zimage" -- the dom0 kernel
+ - "linux-initrd" -- the dom0 ramdisk
+
+- reg
+
+ Specifies the physical address of the module in RAM and the
+ length of the module.
+
+- bootargs (optional)
+
+ Command line associated with this module
diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
index 260c2d4..9e6a4d4 100644
--- a/xen/common/device_tree.c
+++ b/xen/common/device_tree.c
@@ -337,6 +337,90 @@ static void __init process_gic_node(const void *fdt, int node,
early_info.gic.gic_vcpu_addr = start;
}
+static int __init process_chosen_modules_node(const void *fdt, int node,
+ const char *name, int *depth,
+ u32 address_cells, u32 size_cells)
+{
+ const struct fdt_property *prop;
+ const u32 *cell;
+ int nr, nr_modules = 0;
+ struct dt_mb_module *mod;
+ int len;
+
+ for ( *depth = 1;
+ *depth >= 1;
+ node = fdt_next_node(fdt, node, depth) )
+ {
+ name = fdt_get_name(fdt, node, NULL);
+ if ( strncmp(name, "module@", strlen("module@")) == 0 ) {
+
+ if ( fdt_node_check_compatible(fdt, node,
+ "xen,multiboot-module" ) != 0 )
+ early_panic("%s not a compatible module node\n", name);
+
+ if ( fdt_node_check_compatible(fdt, node,
+ "xen,linux-zimage") == 0 )
+ nr = 1;
+ else if ( fdt_node_check_compatible(fdt, node,
+ "xen,linux-initrd") == 0)
+ nr = 2;
+ else
+ early_panic("%s not a known xen multiboot byte\n");
+
+ if ( nr > nr_modules )
+ nr_modules = nr;
+
+ mod = &early_info.modules.module[nr];
+
+ prop = fdt_get_property(fdt, node, "reg", NULL);
+ if ( !prop )
+ early_panic("node %s missing `reg' property\n", name);
+
+ cell = (const u32 *)prop->data;
+ device_tree_get_reg(&cell, address_cells, size_cells,
+ &mod->start, &mod->size);
+
+ prop = fdt_get_property(fdt, node, "bootargs", &len);
+ if ( prop )
+ {
+ if ( len > sizeof(mod->cmdline) )
+ early_panic("module %d command line too long\n", nr);
+
+ safe_strcpy(mod->cmdline, prop->data);
+ }
+ else
+ mod->cmdline[0] = 0;
+ }
+ }
+
+ for ( nr = 1 ; nr < nr_modules ; nr++ )
+ {
+ mod = &early_info.modules.module[nr];
+ if ( !mod->start || !mod->size )
+ early_panic("module %d missing / invalid\n", nr);
+ }
+
+ early_info.modules.nr_mods = nr_modules;
+ return node;
+}
+
+static void __init process_chosen_node(const void *fdt, int node,
+ const char *name,
+ u32 address_cells, u32 size_cells)
+{
+ int depth;
+
+ for ( depth = 0;
+ depth >= 0;
+ node = fdt_next_node(fdt, node, &depth) )
+ {
+ name = fdt_get_name(fdt, node, NULL);
+ if ( depth == 1 && strcmp(name, "modules") == 0 )
+ node = process_chosen_modules_node(fdt, node, name, &depth,
+ address_cells, size_cells);
+ }
+}
+
static int __init early_scan_node(const void *fdt,
int node, const char *name, int depth,
u32 address_cells, u32 size_cells,
@@ -348,6 +432,8 @@ static int __init early_scan_node(const void *fdt,
process_cpu_node(fdt, node, name, address_cells, size_cells);
else if ( device_tree_node_compatible(fdt, node, "arm,cortex-a15-gic") )
process_gic_node(fdt, node, name, address_cells, size_cells);
+ else if ( device_tree_node_matches(fdt, node, "chosen") )
+ process_chosen_node(fdt, node, name, address_cells, size_cells);
return 0;
}
--
1.7.9.1
next prev parent reply other threads:[~2013-01-18 16:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 16:22 [PATCH 00/10 V5] arm: support for initial modules (e.g. dom0) and DTB supplied in RAM Ian Campbell
2013-01-18 16:40 ` [PATCH 01/10] xen: arm: introduce concept of modules which can be in RAM at start of day Ian Campbell
2013-01-21 11:35 ` Stefano Stabellini
2013-01-21 12:41 ` Ian Campbell
2013-01-18 16:40 ` [PATCH 02/10] arm: avoid placing Xen over any modules Ian Campbell
2013-01-18 16:40 ` [PATCH 03/10] arm: avoid allocating the heaps over modules or xen itself Ian Campbell
2013-01-18 16:40 ` [PATCH 04/10] device-tree: get_val cannot cope with cells > 2, add early_panic Ian Campbell
2013-01-18 16:40 ` [PATCH 05/10] arm: load dom0 kernel from first boot module Ian Campbell
2013-01-18 16:40 ` [PATCH 06/10] arm: discard boot modules after building domain 0 Ian Campbell
2013-01-18 16:40 ` [PATCH 07/10] arm: use module provided command line for domain 0 command line Ian Campbell
2013-01-18 16:40 ` [PATCH 08/10] xen/arm: flush dcache after memcpy'ing the kernel image Ian Campbell
2013-01-18 16:40 ` Ian Campbell [this message]
2013-01-18 16:40 ` [PATCH 10/10] xen: strip /chosen/modules/module@<N>/* from dom0 device tree Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358527236-2486-9-git-send-email-ian.campbell@citrix.com \
--to=ian.campbell@citrix.com \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).