[PATCH] xen: print "debug=y|n" during hypervisor startup

[PATCH] xen: print "debug=y|n" during hypervisor startup

[Dario Faggioli]

So that we can easily figure out whether or not we are running a
debug build of Xen (e.g., via `xl dmesg').

Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>

diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c
--- a/xen/drivers/char/console.c
+++ b/xen/drivers/char/console.c
@@ -577,6 +577,11 @@ void __init console_init_preirq(void)
 {
     char *p;
     int sh;
+    char debug = 'n';
+
+#ifndef NDEBUG
+    debug = 'y';
+#endif
 
     serial_init_preirq();
 
@@ -608,9 +613,9 @@ void __init console_init_preirq(void)
     spin_lock(&console_lock);
     __putstr(xen_banner());
     spin_unlock(&console_lock);
-    printk("Xen version %d.%d%s (%s@%s) (%s) %s\n",
+    printk("Xen version %d.%d%s (%s@%s debug=%c) (%s) %s\n",
            xen_major_version(), xen_minor_version(), xen_extra_version(),
-           xen_compile_by(), xen_compile_domain(),
+           xen_compile_by(), xen_compile_domain(), debug,
            xen_compiler(), xen_compile_date());
     printk("Latest ChangeSet: %s\n", xen_changeset());

Re: [PATCH] xen: print "debug=y|n" during hypervisor startup

[Andrew Cooper]

On 30/01/13 12:29, Dario Faggioli wrote:
> So that we can easily figure out whether or not we are running a
> debug build of Xen (e.g., via `xl dmesg').
>
> Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
>
> diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c
> --- a/xen/drivers/char/console.c
> +++ b/xen/drivers/char/console.c
> @@ -577,6 +577,11 @@ void __init console_init_preirq(void)
>  {
>      char *p;
>      int sh;
> +    char debug = 'n';
> +
> +#ifndef NDEBUG
> +    debug = 'y';
> +#endif

While the compiler should certainly do the right thing,


#ifndef NDEBUG
char debug = 'y';
#else
char debug = 'n';
#endif

is arguably neater.

~Andrew

>  
>      serial_init_preirq();
>  
> @@ -608,9 +613,9 @@ void __init console_init_preirq(void)
>      spin_lock(&console_lock);
>      __putstr(xen_banner());
>      spin_unlock(&console_lock);
> -    printk("Xen version %d.%d%s (%s@%s) (%s) %s\n",
> +    printk("Xen version %d.%d%s (%s@%s debug=%c) (%s) %s\n",
>             xen_major_version(), xen_minor_version(), xen_extra_version(),
> -           xen_compile_by(), xen_compile_domain(),
> +           xen_compile_by(), xen_compile_domain(), debug,
>             xen_compiler(), xen_compile_date());
>      printk("Latest ChangeSet: %s\n", xen_changeset());
>  
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

Re: [PATCH] xen: print "debug=y|n" during hypervisor startup

[Keir Fraser]

On 30/01/2013 04:29, "Dario Faggioli" <dario.faggioli@citrix.com> wrote:

> So that we can easily figure out whether or not we are running a
> debug build of Xen (e.g., via `xl dmesg').
> 
> Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
>
> diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c
> --- a/xen/drivers/char/console.c
> +++ b/xen/drivers/char/console.c
> @@ -577,6 +577,11 @@ void __init console_init_preirq(void)
>  {
>      char *p;
>      int sh;
> +    char debug = 'n';
> +
> +#ifndef NDEBUG
> +    debug = 'y';
> +#endif
>  
>      serial_init_preirq();
>  
> @@ -608,9 +613,9 @@ void __init console_init_preirq(void)
>      spin_lock(&console_lock);
>      __putstr(xen_banner());
>      spin_unlock(&console_lock);
> -    printk("Xen version %d.%d%s (%s@%s) (%s) %s\n",
> +    printk("Xen version %d.%d%s (%s@%s debug=%c) (%s) %s\n",
>             xen_major_version(), xen_minor_version(), xen_extra_version(),
> -           xen_compile_by(), xen_compile_domain(),
> +           xen_compile_by(), xen_compile_domain(), debug,
>             xen_compiler(), xen_compile_date());

Rather odd to put it in with the xen_compile_by() info. How about before
xen_compile_date(), and not inside any brackets?

 -- Keir

>      printk("Latest ChangeSet: %s\n", xen_changeset());
>  

Re: [PATCH] xen: print "debug=y|n" during hypervisor startup

[Dario Faggioli]

[-- Attachment #1.1: Type: text/plain, Size: 1149 bytes --]

On Wed, 2013-01-30 at 05:51 -0800, Keir Fraser wrote: 
> > @@ -608,9 +613,9 @@ void __init console_init_preirq(void)
> >      spin_lock(&console_lock);
> >      __putstr(xen_banner());
> >      spin_unlock(&console_lock);
> > -    printk("Xen version %d.%d%s (%s@%s) (%s) %s\n",
> > +    printk("Xen version %d.%d%s (%s@%s debug=%c) (%s) %s\n",
> >             xen_major_version(), xen_minor_version(), xen_extra_version(),
> > -           xen_compile_by(), xen_compile_domain(),
> > +           xen_compile_by(), xen_compile_domain(), debug,
> >             xen_compiler(), xen_compile_date());
> 
> Rather odd to put it in with the xen_compile_by() info. How about before
> xen_compile_date(), and not inside any brackets?
> 
Yeah... I couldn't really make up my mind about where it was better to
put it! :-)

I'll go for what you suggest, thanks.
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)



[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel