From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH 05/13] xen: introduce test_and_set_mask
Date: Fri, 1 Feb 2013 23:08:13 +0100
Message-ID: <1359756493.29345.1.camel@hastur.hellion.org.uk>
References: <1359643627-29486-1-git-send-email-wei.liu2@citrix.com>
	<1359643627-29486-6-git-send-email-wei.liu2@citrix.com>
	<510BA877.40200@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <510BA877.40200@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: David Vrabel <david.vrabel@citrix.com>
Cc: "konrad.wilk@oracle.com" <konrad.wilk@oracle.com>, Wei Liu <wei.liu2@citrix.com>, "jbeulich@suse.com" <jbeulich@suse.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Fri, 2013-02-01 at 11:35 +0000, David Vrabel wrote:
> On 31/01/13 14:46, Wei Liu wrote:
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > ---
> >  drivers/xen/events.c |   10 ++++++++--
> >  1 file changed, 8 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/xen/events.c b/drivers/xen/events.c
> > index 93a3648..0fae3f9 100644
> > --- a/drivers/xen/events.c
> > +++ b/drivers/xen/events.c
> > @@ -345,6 +345,12 @@ static inline int test_evtchn(int port)
> >  	return sync_test_bit(port, &s->evtchn_pending[0]);
> >  }
> >  
> > +static inline int test_and_set_mask(int port)
> 
> This name is too generic.  Suggest test_and_set_evtchn_mask() or similar.

For a static function inside drivers/xen/events.c that seems like
overkill.

Ian.