From: Wei Liu <wei.liu2@citrix.com>
To: xen-devel@lists.xen.org
Cc: david.vrabel@citrix.com, Wei Liu <wei.liu2@citrix.com>,
ian.campbell@citrix.com, jbeulich@suse.com,
konrad.wilk@oracle.com
Subject: [PATCH V2 03/13] xen: fix error handling path if xen_allocate_irq_dynamic fails
Date: Mon, 4 Feb 2013 17:23:44 +0000 [thread overview]
Message-ID: <1359998635-16866-4-git-send-email-wei.liu2@citrix.com> (raw)
In-Reply-To: <1359998635-16866-1-git-send-email-wei.liu2@citrix.com>
The call to xen_allocate_irq_dynamic() might return -ev error codes, not
lietral -1.
Reviewed-by: David Vrabel <david.vrabel@citrix.com>
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
drivers/xen/events.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/xen/events.c b/drivers/xen/events.c
index d937bf8..96ed76f 100644
--- a/drivers/xen/events.c
+++ b/drivers/xen/events.c
@@ -820,7 +820,7 @@ int bind_evtchn_to_irq(unsigned int evtchn)
if (irq == -1) {
irq = xen_allocate_irq_dynamic();
- if (irq == -1)
+ if (irq < 0)
goto out;
irq_set_chip_and_handler_name(irq, &xen_dynamic_chip,
@@ -923,7 +923,7 @@ int bind_virq_to_irq(unsigned int virq, unsigned int cpu)
if (irq == -1) {
irq = xen_allocate_irq_dynamic();
- if (irq == -1)
+ if (irq < 0)
goto out;
irq_set_chip_and_handler_name(irq, &xen_percpu_chip,
--
1.7.10.4
next prev parent reply other threads:[~2013-02-04 17:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-04 17:23 [PATCH V2] Implement 3-level event channel in Linux Wei Liu
2013-02-04 17:23 ` [PATCH V2 01/13] xen: add KERN_DEBUG in printk Wei Liu
2013-02-04 17:23 ` [PATCH V2 02/13] xen: fix output of xen_debug_interrupt Wei Liu
2013-02-04 17:23 ` Wei Liu [this message]
2013-02-04 17:23 ` [PATCH V2 04/13] xen: close evtchn port if binding to irq fails Wei Liu
2013-02-06 8:05 ` Jan Beulich
2013-02-04 17:23 ` [PATCH V2 05/13] xen: sync public headers Wei Liu
2013-02-04 17:23 ` [PATCH V2 06/13] xen: introduce test_and_set_mask Wei Liu
2013-02-04 17:23 ` [PATCH V2 07/13] xen: replace raw bit ops with functions Wei Liu
2013-02-04 17:23 ` [PATCH V2 08/13] xen: generalized event channel operations Wei Liu
2013-02-04 17:23 ` [PATCH V2 09/13] xen: dynamically allocate cpu_evtchn_mask Wei Liu
2013-02-04 17:23 ` [PATCH V2 10/13] xen: implement 3-level event channel routines Wei Liu
2013-02-04 17:23 ` [PATCH V2 11/13] xen: introduce xen_event_channel_register_3level Wei Liu
2013-02-04 17:23 ` [PATCH V2 12/13] xen: introduce xen_event_channel_register_nlevel Wei Liu
2013-02-04 17:23 ` [PATCH V2 13/13] xen: register 3-level event channel Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359998635-16866-4-git-send-email-wei.liu2@citrix.com \
--to=wei.liu2@citrix.com \
--cc=david.vrabel@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=jbeulich@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).