From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: [PATCH 4.0-testing 07/10] ACPI: acpi_table_parse() should return handler's error code Date: Mon, 11 Feb 2013 13:12:50 +0000 Message-ID: <1360588373-779-7-git-send-email-ian.campbell@citrix.com> References: <1360588355.20449.34.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1360588355.20449.34.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org Cc: Boris Ostrovsky List-Id: xen-devel@lists.xenproject.org From: Boris Ostrovsky Currently, the error code returned by acpi_table_parse()'s handler is ignored. This patch will propagate handler's return value to acpi_table_parse()'s caller. Signed-off-by: Boris Ostrovsky Committed-by: Jan Beulich xen-unstable changeset: 26516:32d4516a97f0 xen-unstable date: Tue Feb 5 14:18:18 UTC 2013 --- xen/drivers/acpi/tables.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/xen/drivers/acpi/tables.c b/xen/drivers/acpi/tables.c index a25d9b2..151bda6 100644 --- a/xen/drivers/acpi/tables.c +++ b/xen/drivers/acpi/tables.c @@ -237,7 +237,7 @@ acpi_table_parse_madt(enum acpi_madt_type id, * @handler: handler to run * * Scan the ACPI System Descriptor Table (STD) for a table matching @id, - * run @handler on it. Return 0 if table found, return on if not. + * run @handler on it. */ int acpi_table_parse(char *id, acpi_table_handler handler) { @@ -252,8 +252,7 @@ int acpi_table_parse(char *id, acpi_table_handler handler) acpi_get_table(id, 0, &table); if (table) { - handler(table); - return 0; + return handler(table); } else return 1; } -- 1.7.2.5