From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xu Zhang Subject: [PATCH 4/6] mini-os/x86-64 entry: remove unnecessary event blocking Date: Fri, 8 Mar 2013 15:30:17 -0600 Message-ID: <1362778219-8576-5-git-send-email-xzhang@cs.uic.edu> References: <1362778219-8576-1-git-send-email-xzhang@cs.uic.edu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1362778219-8576-1-git-send-email-xzhang@cs.uic.edu> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org Cc: samuel.thibault@ens-lyon.org, jeremy@goop.org, Xu Zhang , gm281@cam.ac.uk, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org We don't need to block events here because: - if we came from "hypervisor_callback", events are disabled at this point, no need to block again; - if we came from "error_entry", we shouldn't touch event mask, for exception hanlding are meant to be interrupted by Xen events (virtual irq). Signed-off-by: Xu Zhang --- extras/mini-os/arch/x86/x86_64.S | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/extras/mini-os/arch/x86/x86_64.S b/extras/mini-os/arch/x86/x86_64.S index 79e893f..5e0021b 100644 --- a/extras/mini-os/arch/x86/x86_64.S +++ b/extras/mini-os/arch/x86/x86_64.S @@ -185,7 +185,6 @@ ENTRY(hypervisor_callback2) error_exit: RESTORE_REST - XEN_BLOCK_EVENTS(%rsi) retint_kernel: retint_restore_args: -- 1.7.7.6