From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH 10 of 11 v4] xl: add node-affinity to the
 output of `xl list`
Date: Mon, 18 Mar 2013 15:22:23 +0100
Message-ID: <1363616543.3042.6.camel@Solace>
References: <patchbomb.1363314642@hit-nxdomain.opendns.com>
	<0197084457098065914d.1363314652@hit-nxdomain.opendns.com>
	<1363616031.2963.6.camel@zakaz.uk.xensource.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5306523184049735695=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1363616031.2963.6.camel@zakaz.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Marcus Granado <Marcus.Granado@eu.citrix.com>, Dan Magenheimer <dan.magenheimer@oracle.com>, Matt Wilson <msw@amazon.com>, Anil Madhavapeddy <anil@recoil.org>, George Dunlap <George.Dunlap@eu.citrix.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>, Juergen Gross <juergen.gross@ts.fujitsu.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Xen-Devel <xen-devel@lists.xen.org>, Jan Beulich <JBeulich@suse.com>, Daniel De Graaf <dgdegra@tycho.nsa.gov>
List-Id: xen-devel@lists.xenproject.org

--===============5306523184049735695==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-n0DEOC9B7GF+/WLMtj6A"

--=-n0DEOC9B7GF+/WLMtj6A
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On lun, 2013-03-18 at 14:13 +0000, Ian Campbell wrote:
> On Fri, 2013-03-15 at 02:30 +0000, Dario Faggioli wrote:
> > Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
> > Acked-by: Juergen Gross <juergen.gross@ts.fujitsu.com>
>=20
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
Thanks!

> [...]
> >              if (rc < 0)
> > -                printf("  -");
> > +                printf("                -");
> >              else {
> > -                printf("  %s", buf);
> > +                printf(" %16s", buf);
> >                  free(buf);
>=20
> If you do end up respinning for any reason then this could be made less
> manual/error prone by using "%16s" even in the "-" case. Might even be
> possible to combine the whole lot, since free(NULL) is safe:
> 	printf(" %16s", rc < 0 : "" ? buf);
> 	free(buf);
> (assuming buf =3D=3D NULL whenever rc < 0, I didn't check)
>=20
I am respinning, and I'll take a look at this.

Thanks again,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-n0DEOC9B7GF+/WLMtj6A
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (GNU/Linux)

iEYEABECAAYFAlFHIx8ACgkQk4XaBE3IOsQkjgCghQD9s0YkNZltwcQuah3vvXKl
AWgAoIhFkb/bsdhIb3uESl+utI0M7Lz4
=jzfW
-----END PGP SIGNATURE-----

--=-n0DEOC9B7GF+/WLMtj6A--


--===============5306523184049735695==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============5306523184049735695==--