From: David Scott <dave.scott@eu.citrix.com>
To: xen-devel@lists.xen.org
Cc: jonathan.ludlam@eu.citrix.com, David Scott <dave.scott@eu.citrix.com>
Subject: [PATCH 2/4] ocaml: eventchn: in the interface, we don't have to give implementation details
Date: Wed, 20 Mar 2013 20:24:43 +0000 [thread overview]
Message-ID: <1363811085-6700-3-git-send-email-dave.scott@eu.citrix.com> (raw)
In-Reply-To: <1363811085-6700-1-git-send-email-dave.scott@eu.citrix.com>
Remove the mention of the C function names from the .mli -- this is only
needed in the implementation .ml
Signed-off-by: David Scott <dave.scott@eu.citrix.com>
---
tools/ocaml/libs/eventchn/xeneventchn.mli | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/tools/ocaml/libs/eventchn/xeneventchn.mli b/tools/ocaml/libs/eventchn/xeneventchn.mli
index 2b582cd..74e581b 100644
--- a/tools/ocaml/libs/eventchn/xeneventchn.mli
+++ b/tools/ocaml/libs/eventchn/xeneventchn.mli
@@ -23,14 +23,13 @@ type t
val to_int: t -> int
val of_int: int -> t
-external init : unit -> handle = "stub_eventchn_init"
-external fd: handle -> Unix.file_descr = "stub_eventchn_fd"
+val init: unit -> handle
+val fd: handle -> Unix.file_descr
-external notify : handle -> t -> unit = "stub_eventchn_notify"
-external bind_interdomain : handle -> int -> int -> t
- = "stub_eventchn_bind_interdomain"
-external bind_dom_exc_virq : handle -> t = "stub_eventchn_bind_dom_exc_virq"
-external unbind : handle -> t -> unit = "stub_eventchn_unbind"
-external pending : handle -> t = "stub_eventchn_pending"
-external unmask : handle -> t -> unit
- = "stub_eventchn_unmask"
+val notify : handle -> t -> unit
+val bind_interdomain : handle -> int -> int -> t
+
+val bind_dom_exc_virq : handle -> t
+val unbind : handle -> t -> unit
+val pending : handle -> t
+val unmask : handle -> t -> unit
--
1.8.1.2
next prev parent reply other threads:[~2013-03-20 20:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 20:24 ocaml: eventchn: tidy up the module David Scott
2013-03-20 20:24 ` [PATCH 1/4] ocaml: eventchn: add a 'type t' to represent an event channel David Scott
2013-03-20 20:24 ` David Scott [this message]
2013-03-20 20:24 ` [PATCH 3/4] ocaml: eventchn: add ocamldoc strings to the interface David Scott
2013-03-20 20:24 ` [PATCH 4/4] ocaml: eventchn: remove the unused exception 'Eventchn.Error' David Scott
2013-04-11 11:16 ` ocaml: eventchn: tidy up the module Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363811085-6700-3-git-send-email-dave.scott@eu.citrix.com \
--to=dave.scott@eu.citrix.com \
--cc=jonathan.ludlam@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).