xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: xen-devel@lists.xensource.com, ian.campbell@citrix.com
Cc: Marcos Matsunaga <Marcos.Matsunaga@oracle.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: [PATCH] xend: Fix xm list bug reporting incorrect memory size
Date: Tue,  2 Apr 2013 13:38:47 -0400	[thread overview]
Message-ID: <1364924327-31151-1-git-send-email-konrad.wilk@oracle.com> (raw)

From: Marcos Matsunaga <Marcos.Matsunaga@oracle.com>

Make sure memory is updated every time XendConfig.update is called.

Without this patch, if a guest self-balloons, the amount of memory
that 'xend' thinks the guest is using is based on last cached value.
This means the reported value is nowhere close to what the real
value is.

This change allows xend to double-check the xcinfo info (which
hypercall it had already do) and use the up-to-date contents.

'xl' already does this by using the xcinfo.

Oracle-Bug: 14553104 ( MEM(K) IN XENTOP MISMATCH MEMTOTAL IN /PROC/MEMINFO AND MEM IN "XM LIST")
Signed-off-by: Marcos Matsunaga <Marcos.Matsunaga@oracle.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
 tools/python/xen/xend/XendConfig.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tools/python/xen/xend/XendConfig.py b/tools/python/xen/xend/XendConfig.py
index 4a226a7..d8a2535 100644
--- a/tools/python/xen/xend/XendConfig.py
+++ b/tools/python/xen/xend/XendConfig.py
@@ -1041,7 +1041,10 @@ class XendConfig(dict):
         @param dominfo: Domain information via xc.domain_getinfo()
         @type dominfo: dict
         """
-        self._dominfo_to_xapi(dominfo)
+	if dominfo['paused']:
+           self._dominfo_to_xapi(dominfo)
+        else:
+           self._dominfo_to_xapi(dominfo, update_mem = True)
         self.validate()
 
     def update_with_xenapi_config(self, xapi):
-- 
1.8.0.2

             reply	other threads:[~2013-04-02 17:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-02 17:38 Konrad Rzeszutek Wilk [this message]
2013-04-08 17:06 ` [PATCH] xend: Fix xm list bug reporting incorrect memory size Ian Jackson
2013-04-12 15:15   ` Marcos E. Matsunaga
2013-05-06 20:31     ` Konrad Rzeszutek Wilk
2013-06-05 19:01 ` Matt Wilson
2013-06-27  9:29   ` Marcos E. Matsunaga

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1364924327-31151-1-git-send-email-konrad.wilk@oracle.com \
    --to=konrad.wilk@oracle.com \
    --cc=Marcos.Matsunaga@oracle.com \
    --cc=ian.campbell@citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).