xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: xen-devel@lists.xen.org
Cc: tim@xen.org, Ian Campbell <ian.campbell@citrix.com>,
	stefano.stabellini@eu.citrix.com
Subject: [PATCH] xen: arm: enable aborts on all physical processors.
Date: Thu, 25 Apr 2013 15:45:50 +0100	[thread overview]
Message-ID: <1366901150-26676-1-git-send-email-ian.campbell@citrix.com> (raw)

I'm not sure how this ended up in construct dom0 where it only affects the
boot cpu and doesn't logically fit.

Enable aborts at the same time as we enable interrupts.

I'm not sure what the behaviour of an "abort worthy" operation while aborts
are disable is, but it must surely be worse than calling do_unexpected_trap,
which is what happens from now on.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
 xen/arch/arm/domain_build.c |    2 --
 xen/arch/arm/setup.c        |    1 +
 xen/arch/arm/smpboot.c      |    1 +
 3 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 81a759c..1913f87 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -455,8 +455,6 @@ int construct_dom0(struct domain *d)
     }
 #endif
 
-    local_abort_enable();
-
     return 0;
 }
 
diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
index cfe3d94..9be1fc9 100644
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/arm/setup.c
@@ -473,6 +473,7 @@ void __init start_xen(unsigned long boot_phys_offset,
     arch_init_memory();
 
     local_irq_enable();
+    local_abort_enable();
 
     smp_prepare_cpus(cpus);
 
diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c
index bd353c8..507936d 100644
--- a/xen/arch/arm/smpboot.c
+++ b/xen/arch/arm/smpboot.c
@@ -177,6 +177,7 @@ void __cpuinit start_secondary(unsigned long boot_phys_offset,
     wmb();
 
     local_irq_enable();
+    local_abort_enable();
 
     printk(XENLOG_DEBUG "CPU %u booted.\n", smp_processor_id());
 
-- 
1.7.2.5

             reply	other threads:[~2013-04-25 14:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-25 14:45 Ian Campbell [this message]
2013-07-18 12:13 ` [PATCH] xen: arm: enable aborts on all physical processors Ian Campbell
2013-07-18 17:01   ` Tim Deegan
2013-07-19 14:17     ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1366901150-26676-1-git-send-email-ian.campbell@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).