* [PATCH] arm64: Fix compilation error with EARLY_PRINTK disabled
@ 2013-04-25 18:39 Julien Grall
2013-04-26 8:50 ` Ian Campbell
0 siblings, 1 reply; 3+ messages in thread
From: Julien Grall @ 2013-04-25 18:39 UTC (permalink / raw)
To: xen-devel; +Cc: patches, Ian.Campbell, Julien Grall, Stefano.Stabellini
arm64/head.S: Assembler messages:
arm64/head.S:391: Error: operand 1 should be an integer register -- `mov pc,lr'
Signed-off-by: Julien Grall <julien.grall@linaro.org>
---
xen/arch/arm/arm64/head.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
index f0d9066..ef02899 100644
--- a/xen/arch/arm/arm64/head.S
+++ b/xen/arch/arm/arm64/head.S
@@ -388,6 +388,6 @@ init_uart:
.global early_puts
early_puts:
puts:
-putn: mov pc, lr
+putn: ret
#endif /* EARLY_UART_ADDRESS */
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: Fix compilation error with EARLY_PRINTK disabled
2013-04-25 18:39 [PATCH] arm64: Fix compilation error with EARLY_PRINTK disabled Julien Grall
@ 2013-04-26 8:50 ` Ian Campbell
2013-04-26 15:34 ` Ian Campbell
0 siblings, 1 reply; 3+ messages in thread
From: Ian Campbell @ 2013-04-26 8:50 UTC (permalink / raw)
To: Julien Grall
Cc: xen-devel@lists.xensource.com, patches@linaro.org,
Stefano Stabellini
On Thu, 2013-04-25 at 19:39 +0100, Julien Grall wrote:
> arm64/head.S: Assembler messages:
> arm64/head.S:391: Error: operand 1 should be an integer register -- `mov pc,lr'
>
> Signed-off-by: Julien Grall <julien.grall@linaro.org>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
> ---
> xen/arch/arm/arm64/head.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
> index f0d9066..ef02899 100644
> --- a/xen/arch/arm/arm64/head.S
> +++ b/xen/arch/arm/arm64/head.S
> @@ -388,6 +388,6 @@ init_uart:
> .global early_puts
> early_puts:
> puts:
> -putn: mov pc, lr
> +putn: ret
>
> #endif /* EARLY_UART_ADDRESS */
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: Fix compilation error with EARLY_PRINTK disabled
2013-04-26 8:50 ` Ian Campbell
@ 2013-04-26 15:34 ` Ian Campbell
0 siblings, 0 replies; 3+ messages in thread
From: Ian Campbell @ 2013-04-26 15:34 UTC (permalink / raw)
To: Julien Grall
Cc: xen-devel@lists.xensource.com, Stefano Stabellini,
patches@linaro.org
On Fri, 2013-04-26 at 09:50 +0100, Ian Campbell wrote:
> On Thu, 2013-04-25 at 19:39 +0100, Julien Grall wrote:
> > arm64/head.S: Assembler messages:
> > arm64/head.S:391: Error: operand 1 should be an integer register -- `mov pc,lr'
> >
> > Signed-off-by: Julien Grall <julien.grall@linaro.org>
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-26 15:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-25 18:39 [PATCH] arm64: Fix compilation error with EARLY_PRINTK disabled Julien Grall
2013-04-26 8:50 ` Ian Campbell
2013-04-26 15:34 ` Ian Campbell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).