From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xensource.com
Cc: mattjd@gmail.com, Ian Jackson <ian.jackson@eu.citrix.com>
Subject: [PATCH 08/16] tools/xcutils/readnotes: adjust print_l1_mfn_valid_note
Date: Mon, 3 Jun 2013 16:41:43 +0100 [thread overview]
Message-ID: <1370274111-18377-9-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1370274111-18377-1-git-send-email-ian.jackson@eu.citrix.com>
Use the new PTRVAL macros and elf_access_unsigned in
print_l1_mfn_valid_note.
No functional change unless the input is wrong, or we are reading a
file for a different endianness.
Separated out from the previous patch because this change does produce
a difference in the generated code.
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
v2: Split out into its own patch.
---
tools/xcutils/readnotes.c | 11 ++++++-----
1 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/tools/xcutils/readnotes.c b/tools/xcutils/readnotes.c
index 2af047d..7ff2530 100644
--- a/tools/xcutils/readnotes.c
+++ b/tools/xcutils/readnotes.c
@@ -77,22 +77,23 @@ static void print_numeric_note(const char *prefix, struct elf_binary *elf,
}
static void print_l1_mfn_valid_note(const char *prefix, struct elf_binary *elf,
- const elf_note *note)
+ ELF_HANDLE_DECL(elf_note) note)
{
int descsz = elf_uval(elf, note, descsz);
- const uint32_t *desc32 = elf_note_desc(elf, note);
- const uint64_t *desc64 = elf_note_desc(elf, note);
+ ELF_PTRVAL_CONST_VOID desc = elf_note_desc(elf, note);
/* XXX should be able to cope with a list of values. */
switch ( descsz / 2 )
{
case 8:
printf("%s: mask=%#"PRIx64" value=%#"PRIx64"\n", prefix,
- desc64[0], desc64[1]);
+ elf_access_unsigned(elf, desc, 0, 8),
+ elf_access_unsigned(elf, desc, 8, 8));
break;
case 4:
printf("%s: mask=%#"PRIx32" value=%#"PRIx32"\n", prefix,
- desc32[0],desc32[1]);
+ (uint32_t)elf_access_unsigned(elf, desc, 0, 4),
+ (uint32_t)elf_access_unsigned(elf, desc, 4, 4));
break;
}
--
1.7.2.5
next prev parent reply other threads:[~2013-06-03 15:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 15:41 [PATCH v3.1 00/16] XSA55 libelf fixes for unstable Ian Jackson
2013-06-03 15:41 ` [PATCH 01/16] libelf: abolish libelf-relocate.c Ian Jackson
2013-06-03 15:41 ` [PATCH 02/16] libxc: introduce xc_dom_seg_to_ptr_pages Ian Jackson
2013-06-03 15:41 ` [PATCH 03/16] libelf: add `struct elf_binary*' parameter to elf_load_image Ian Jackson
2013-06-03 15:41 ` [PATCH 04/16] libelf: abolish elf_sval and elf_access_signed Ian Jackson
2013-06-03 15:41 ` [PATCH 05/16] libelf: move include of <asm/guest_access.h> to top of file Ian Jackson
2013-06-03 15:41 ` [PATCH 06/16] libelf/xc_dom_load_elf_symtab: Do not use "syms" uninitialised Ian Jackson
2013-06-03 15:41 ` [PATCH 07/16] libelf: introduce macros for memory access and pointer handling Ian Jackson
2013-06-03 15:41 ` Ian Jackson [this message]
2013-06-03 15:41 ` [PATCH 09/16] libelf: check nul-terminated strings properly Ian Jackson
2013-06-04 14:49 ` Matthew Daley
2013-06-04 15:15 ` Ian Jackson
2013-06-04 15:27 ` Matthew Daley
2013-06-04 17:13 ` Ian Jackson
2013-06-05 2:08 ` Matthew Daley
2013-06-05 7:24 ` Ian Campbell
2013-06-03 15:41 ` [PATCH 10/16] libelf: check all pointer accesses Ian Jackson
2013-06-04 14:55 ` Matthew Daley
2013-06-04 15:11 ` Ian Jackson
2013-06-03 15:41 ` [PATCH 11/16] libelf: Check pointer references in elf_is_elfbinary Ian Jackson
2013-06-03 15:41 ` [PATCH 12/16] libelf: Make all callers call elf_check_broken Ian Jackson
2013-06-03 15:41 ` [PATCH 13/16] libelf: use C99 bool for booleans Ian Jackson
2013-06-03 15:41 ` [PATCH 14/16] libelf: use only unsigned integers Ian Jackson
2013-06-04 10:50 ` Ian Jackson
2013-06-03 15:41 ` [PATCH 15/16] libelf: check loops for running away Ian Jackson
2013-06-03 15:41 ` [PATCH 16/16] libelf: abolish obsolete macros Ian Jackson
2013-06-03 16:08 ` [PATCH v3.1 00/16] XSA55 libelf fixes for unstable Ian Jackson
-- strict thread matches above, loose matches on Subject: below --
2013-06-04 17:59 [PATCH 4 " Ian Jackson
2013-06-04 17:59 ` [PATCH 08/16] tools/xcutils/readnotes: adjust print_l1_mfn_valid_note Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370274111-18377-9-git-send-email-ian.jackson@eu.citrix.com \
--to=ian.jackson@eu.citrix.com \
--cc=mattjd@gmail.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).