[PATCH] LIBXL_HAVE_<xxx> for claim related visible fields

[PATCH] LIBXL_HAVE_<xxx> for claim related visible fields

[Dario Faggioli]

Hi,

This small and pretty trivial patch adds the LIBXL_HAVE_<foo> symbols we
decided we want whenever adding something to the API, for two fields related to
the claim mechanism that are part of user visible structs.

So, Konrad, can you please check the comments and see whether I got the
description of what those two fields accommodates right?

Also, George, release-wise, I think this is rather harmless, wrt the
possibility of introducing new bugs! :-) Moreover, even if one might not
consider it a proper bugfix, I think it is something we need if we really want
to honour what we said we would be doing when adding stuff to the libxl API,
from 4.2 on.  For that reason, I'm requesting a freeze exception, for allowing
this to go in 4.3.

Thanks and Regards,
Dario

---

Dario Faggioli (1):
      libxl: add LIBXL_HAVE_<foo> for outstanding_pages and outstanding_memkb


 tools/libxl/libxl.h |   18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

[PATCH] libxl: add LIBXL_HAVE_<foo> for outstanding_pages and outstanding_memkb

[Dario Faggioli]

Commits d0782481 and bec8f17e added these two fields in libxl_physinfo
and in libxl_dominfo, respectively, but did not include the needed
LIBXL_HAVE_<foo> runes. Adding them.

Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
---
 tools/libxl/libxl.h |   18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h
index 0bc005e..3d3bbdd 100644
--- a/tools/libxl/libxl.h
+++ b/tools/libxl/libxl.h
@@ -318,6 +318,24 @@
 #define LIBXL_HAVE_NONCONST_EVENT_OCCURS_EVENT_ARG 1
 #endif
 
+/*
+ * LIBXL_HAVE_PHYSINFO_OUTSTANDING_PAGES
+ *
+ * If this is defined, libxl_physinfo structure will contain an uint64 field
+ * called outstanding_pages, containing the number of pages claimed but not
+ * yet allocated.
+ */
+#define LIBXL_HAVE_PHYSINFO_OUTSTANDING_PAGES 1
+
+/*
+ * LIBXL_HAVE_DOMINFO_OUTSTANDING_MEMKB 1
+ *
+ * If this is defined, libxl_dominfo will contain a MemKB type field called
+ * outstanding_memkb, containing the amount of claimed but not yet allocated
+ * memory for a specific domain.
+ */
+#define LIBXL_HAVE_DOMINFO_OUTSTANDING_MEMKB 1
+
 /* Functions annotated with LIBXL_EXTERNAL_CALLERS_ONLY may not be
  * called from within libxl itself. Callers outside libxl, who
  * do not #include libxl_internal.h, are fine. */

Re: [PATCH] libxl: add LIBXL_HAVE_<foo> for outstanding_pages and outstanding_memkb

[Konrad Rzeszutek Wilk]

On Fri, Jun 07, 2013 at 12:50:41AM +0200, Dario Faggioli wrote:
> Commits d0782481 and bec8f17e added these two fields in libxl_physinfo

One usually includes right after the git commit the title
of the patches, so:

d0782481 ("xl: export 'outstanding_pages' value from xcinfo") and
...
> and in libxl_dominfo, respectively, but did not include the needed
> LIBXL_HAVE_<foo> runes. Adding them.
> 
> Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>

Besides the above mention commit description part (And one tweak below)
please also add
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

or Acked-by - whichever George is looking for.

> ---
>  tools/libxl/libxl.h |   18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h
> index 0bc005e..3d3bbdd 100644
> --- a/tools/libxl/libxl.h
> +++ b/tools/libxl/libxl.h
> @@ -318,6 +318,24 @@
>  #define LIBXL_HAVE_NONCONST_EVENT_OCCURS_EVENT_ARG 1
>  #endif
>  
> +/*
> + * LIBXL_HAVE_PHYSINFO_OUTSTANDING_PAGES
> + *
> + * If this is defined, libxl_physinfo structure will contain an uint64 field
> + * called outstanding_pages, containing the number of pages claimed but not
> + * yet allocated.

.. for all domains.

> + */
> +#define LIBXL_HAVE_PHYSINFO_OUTSTANDING_PAGES 1
> +
> +/*
> + * LIBXL_HAVE_DOMINFO_OUTSTANDING_MEMKB 1
> + *
> + * If this is defined, libxl_dominfo will contain a MemKB type field called
> + * outstanding_memkb, containing the amount of claimed but not yet allocated
> + * memory for a specific domain.
> + */
> +#define LIBXL_HAVE_DOMINFO_OUTSTANDING_MEMKB 1
> +
>  /* Functions annotated with LIBXL_EXTERNAL_CALLERS_ONLY may not be
>   * called from within libxl itself. Callers outside libxl, who
>   * do not #include libxl_internal.h, are fine. */
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
> 

Re: [PATCH] libxl: add LIBXL_HAVE_<foo> for outstanding_pages and outstanding_memkb

[Dario Faggioli]

[-- Attachment #1.1: Type: text/plain, Size: 1318 bytes --]

On ven, 2013-06-07 at 06:49 -0700, Konrad Rzeszutek Wilk wrote:
> On Fri, Jun 07, 2013 at 12:50:41AM +0200, Dario Faggioli wrote:
> > Commits d0782481 and bec8f17e added these two fields in libxl_physinfo
> 
> One usually includes right after the git commit the title
> of the patches, so:
> 
> d0782481 ("xl: export 'outstanding_pages' value from xcinfo") and
> ...
>
Ok, I think I see why that could be useful. Note taken, thanks. :-)

> > and in libxl_dominfo, respectively, but did not include the needed
> > LIBXL_HAVE_<foo> runes. Adding them.
> > 
> > Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
> 
> Besides the above mention commit description part (And one tweak below)
> please also add
> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> 
> or Acked-by - whichever George is looking for.
> 
Ok, thanks again. George, Ian, should I respin incorporating Konrad's
feedback (both to the changelog and to the code comment, of course)? Is
this fine for being picked up in 4.3?

Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] libxl: add LIBXL_HAVE_<foo> for outstanding_pages and outstanding_memkb

[Ian Campbell]

On Fri, 2013-06-07 at 15:54 +0200, Dario Faggioli wrote:
> On ven, 2013-06-07 at 06:49 -0700, Konrad Rzeszutek Wilk wrote:
> > On Fri, Jun 07, 2013 at 12:50:41AM +0200, Dario Faggioli wrote:
> > > Commits d0782481 and bec8f17e added these two fields in libxl_physinfo
> > 
> > One usually includes right after the git commit the title
> > of the patches, so:
> > 
> > d0782481 ("xl: export 'outstanding_pages' value from xcinfo") and
> > ...
> >
> Ok, I think I see why that could be useful. Note taken, thanks. :-)
> 
> > > and in libxl_dominfo, respectively, but did not include the needed
> > > LIBXL_HAVE_<foo> runes. Adding them.
> > > 
> > > Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
> > 
> > Besides the above mention commit description part (And one tweak below)
> > please also add
> > Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > 
> > or Acked-by - whichever George is looking for.
> > 
> Ok, thanks again. George, Ian, should I respin incorporating Konrad's
> feedback (both to the changelog and to the code comment, of course)?

Please do.

> Is this fine for being picked up in 4.3?

IMHO Yes.

Ian.

Re: [PATCH] libxl: add LIBXL_HAVE_<foo> for outstanding_pages and outstanding_memkb

[Dario Faggioli]

[-- Attachment #1.1: Type: text/plain, Size: 871 bytes --]

On mar, 2013-06-11 at 10:19 +0100, Ian Campbell wrote:
> On Fri, 2013-06-07 at 15:54 +0200, Dario Faggioli wrote:
> > Ok, thanks again. George, Ian, should I respin incorporating Konrad's
> > feedback (both to the changelog and to the code comment, of course)?
> 
> Please do.
> 
I think I did that already... Can you see message
<20130607161430.22121.65398.stgit@hit-nxdomain.opendns.com> ?

As far as I can tell, I sent it on the list on "Fri, 07 Jun 2013
18:14:35 +0200" with you, George and Konrad in Cc... Does that matches
the true, or is stgit somehow playing me? :-P

Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] libxl: add LIBXL_HAVE_<foo> for outstanding_pages and outstanding_memkb

[Ian Campbell]

On Tue, 2013-06-11 at 11:28 +0200, Dario Faggioli wrote:
> On mar, 2013-06-11 at 10:19 +0100, Ian Campbell wrote:
> > On Fri, 2013-06-07 at 15:54 +0200, Dario Faggioli wrote:
> > > Ok, thanks again. George, Ian, should I respin incorporating Konrad's
> > > feedback (both to the changelog and to the code comment, of course)?
> > 
> > Please do.
> > 
> I think I did that already... Can you see message
> <20130607161430.22121.65398.stgit@hit-nxdomain.opendns.com> ?
> 
> As far as I can tell, I sent it on the list on "Fri, 07 Jun 2013
> 18:14:35 +0200" with you, George and Konrad in Cc... Does that matches
> the true, or is stgit somehow playing me? :-P

I got it, I just hadn't got that far through my post-vacation backlog
yet.

Ian.

Re: [PATCH] libxl: add LIBXL_HAVE_<foo> for outstanding_pages and outstanding_memkb

[konrad wilk]

On 6/11/2013 5:28 AM, Dario Faggioli wrote:
> On mar, 2013-06-11 at 10:19 +0100, Ian Campbell wrote:
>> On Fri, 2013-06-07 at 15:54 +0200, Dario Faggioli wrote:
>>> Ok, thanks again. George, Ian, should I respin incorporating Konrad's
>>> feedback (both to the changelog and to the code comment, of course)?
>> Please do.
>>
> I think I did that already... Can you see message
> <20130607161430.22121.65398.stgit@hit-nxdomain.opendns.com> ?
>
> As far as I can tell, I sent it on the list on "Fri, 07 Jun 2013
> 18:14:35 +0200" with you, George and Konrad in Cc... Does that matches
> the true, or is stgit somehow playing me? :-P

I saw it too. I think we are waiting for Ian or George to check it in.
> Regards,
> Dario
>

Re: [PATCH] libxl: add LIBXL_HAVE_<foo> for outstanding_pages and outstanding_memkb

[George Dunlap]

On 07/06/13 14:49, Konrad Rzeszutek Wilk wrote:
> On Fri, Jun 07, 2013 at 12:50:41AM +0200, Dario Faggioli wrote:
>> Commits d0782481 and bec8f17e added these two fields in libxl_physinfo
> One usually includes right after the git commit the title
> of the patches, so:
>
> d0782481 ("xl: export 'outstanding_pages' value from xcinfo") and
> ...
>> and in libxl_dominfo, respectively, but did not include the needed
>> LIBXL_HAVE_<foo> runes. Adding them.
>>
>> Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
> Besides the above mention commit description part (And one tweak below)
> please also add
> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>
> or Acked-by - whichever George is looking for.

Both are good, now that I understand what "reviewed-by" actually means. :-)

BTW, I've been meaning to take a look to see if these are the right 
thing; but from a release standpoint, obviously these kinds of things 
are really important, and we should actually go through the libxl 
interface and see if there are any other bits we need to add something 
like this for.

So re the release:

Acked-by: George Dunlap <george.dunlap@eu.citrix.com>

I'll probably come by later and do a proper review.

  -George