From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: xen-devel@lists.xensource.com
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: [v2] ring/macro: Add a new macro to detect whether there is an overflow in requests and response.
Date: Mon, 10 Jun 2013 12:02:01 -0400 [thread overview]
Message-ID: <1370880121-7690-2-git-send-email-konrad.wilk@oracle.com> (raw)
In-Reply-To: <1370880121-7690-1-git-send-email-konrad.wilk@oracle.com>
We want to be able to exit if the difference between the request
produced (what the frontend tells us) and the requests consumed
(what we have so far processed) is greater than the ring size.
If so, we should terminate the loop as the request produced
is not trusted and it means it is bogus.
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
[v1: Make sure we have both _prod and _cons in the macro, not just _prod)
---
xen/include/public/io/ring.h | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/xen/include/public/io/ring.h b/xen/include/public/io/ring.h
index d9884f5..277d296 100644
--- a/xen/include/public/io/ring.h
+++ b/xen/include/public/io/ring.h
@@ -234,6 +234,12 @@ typedef struct __name##_back_ring __name##_back_ring_t
#define RING_REQUEST_CONS_OVERFLOW(_r, _cons) \
(((_cons) - (_r)->rsp_prod_pvt) >= RING_SIZE(_r))
+/* Loop termination condition: Is the difference between request produced
+ * and request consumed greater than the ring size. If so, terminate the
+ * loop. */
+#define RING_REQUEST_PROD_OVERFLOW(_r, _cons, _prod) \
+ (((_prod) - (_cons)) > RING_SIZE(_r))
+
#define RING_PUSH_REQUESTS(_r) do { \
xen_wmb(); /* back sees requests /before/ updated producer index */ \
(_r)->sring->req_prod = (_r)->req_prod_pvt; \
--
1.8.1.4
next prev parent reply other threads:[~2013-06-10 16:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-10 16:02 [PATCH] Macro for checking insance amounts of data on the ring (Xen patch) Konrad Rzeszutek Wilk
2013-06-10 16:02 ` Konrad Rzeszutek Wilk [this message]
2013-06-11 8:23 ` [PATCH v3] io/ring.h: new macro to detect whether there are too many requests on the ring Jan Beulich
2013-06-11 10:10 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370880121-7690-2-git-send-email-konrad.wilk@oracle.com \
--to=konrad.wilk@oracle.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).